This is an archive of the discontinued LLVM Phabricator instance.

Differential D135552

[OpenMP] kmp_affinity.h: add missing #else
ClosedPublic

Authored by wzssyqa on Oct 9 2022, 8:31 PM.

Details

Reviewers
MaskRay
atanasyan
jdoerfert
Commits
rG3f9d51ab5a1d: [OpenMP] kmp_affinity.h: add missing #else
Summary

When detect __NR_sched_getaffinity. the last #else is missing,
which make the last platform MIPS64 failed to build with an error:

"Unknown or unsupported architecture"

Diff Detail

Event Timeline

wzssyqa created this revision.Oct 9 2022, 8:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 9 2022, 8:31 PM
Herald added subscribers: StephenFan, guansong, arichardson and 2 others. · View Herald Transcript
wzssyqa requested review of this revision.Oct 9 2022, 8:31 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptOct 9 2022, 8:31 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: openmp-commits, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B191208: Diff 466417.Oct 9 2022, 8:34 PM
MaskRay accepted this revision.Oct 9 2022, 10:37 PM

Looks great!

This revision is now accepted and ready to land.Oct 9 2022, 10:37 PM
MaskRay retitled this revision from openmp: kmp_affinity.h add missing #else to [OpenMP] kmp_affinity.h: add missing #else.Oct 25 2022, 7:53 PM
Closed by commit rG3f9d51ab5a1d: [OpenMP] kmp_affinity.h: add missing #else (authored by wzssyqa, committed by MaskRay). · Explain WhyOct 25 2022, 7:53 PM
This revision was automatically updated to reflect the committed changes.
MaskRay added a commit: rG3f9d51ab5a1d: [OpenMP] kmp_affinity.h: add missing #else.
Ami-zhang mentioned this in D137604: [OpenMP] kmp_affinity.h: add LoongArch64 support.Nov 7 2022, 7:58 PM
SixWeining mentioned this in rGdb8a96731f98: [OpenMP] kmp_affinity.h: add LoongArch64 support.Nov 16 2022, 7:59 PM
yabinc mentioned this in D138241: [OpenMP] kmp_affinity.h: add RISCV64 support.Nov 17 2022, 3:33 PM
pirama mentioned this in rG622d329148bd: [OpenMP] kmp_affinity.h: add RISCV64 support.Nov 17 2022, 4:04 PM

Revision Contents

PathSize
openmp/
runtime/
src/
1 line

Diff 466417

openmp/runtime/src/kmp_affinity.h

Show First 20 Lines • Show All 248 Lines • ▼ Show 20 Lines
#elif __NR_sched_setaffinity != 5195 #elif __NR_sched_setaffinity != 5195
#error Wrong code for setaffinity system call. #error Wrong code for setaffinity system call.
#endif /* __NR_sched_setaffinity */ #endif /* __NR_sched_setaffinity */
#ifndef __NR_sched_getaffinity #ifndef __NR_sched_getaffinity
#define __NR_sched_getaffinity 5196 #define __NR_sched_getaffinity 5196
#elif __NR_sched_getaffinity != 5196 #elif __NR_sched_getaffinity != 5196
#error Wrong code for getaffinity system call. #error Wrong code for getaffinity system call.
#endif /* __NR_sched_getaffinity */ #endif /* __NR_sched_getaffinity */
#else
#error Unknown or unsupported architecture #error Unknown or unsupported architecture
#endif /* KMP_ARCH_* */ #endif /* KMP_ARCH_* */
#elif KMP_OS_FREEBSD #elif KMP_OS_FREEBSD
#include <pthread.h> #include <pthread.h>
#include <pthread_np.h> #include <pthread_np.h>
#endif #endif
class KMPNativeAffinity : public KMPAffinity { class KMPNativeAffinity : public KMPAffinity {
class Mask : public KMPAffinity::Mask { class Mask : public KMPAffinity::Mask {
▲ Show 20 Lines • Show All 938 Lines • Show Last 20 Lines