This is an archive of the discontinued LLVM Phabricator instance.

Extended Documentation of LLVM_TARGETS_TO_BUILD by listing all possible values
ClosedPublic

Authored by adeelahmad81299 on Oct 7 2022, 1:22 AM.

Download Raw Diff

Details

Reviewers

kristof.beyls
thieta

Commits

rGc3e073bcbdc5: Extended Documentation of LLVM_TARGETS_TO_BUILD by listing all possible values

Summary

AT https://llvm.org/docs/CMake.html#frequently-used-llvm-related-variables listed all possible values for LLVM_TARGETS_TO_BUILD.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

adeelahmad81299 created this revision.Oct 7 2022, 1:22 AM

Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 1:22 AM

Herald added subscribers: s.egerton, simoncook, fedor.sergeev, dschuff. · View Herald Transcript

adeelahmad81299 requested review of this revision.Oct 7 2022, 1:22 AM

Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 1:22 AM

Herald added subscribers: llvm-commits, • pcwang-thead, aheejin. · View Herald Transcript

I just have one minor suggestion.
Otherwise, LGTM.

llvm/docs/CMake.rst
741–742	The backends available in LLVM can change over time. When a backend is removed/added, the people doing so may well forget to update the list here. Therefore, maybe it may be better to write: "The full list, as of October 2022, is:"?

Harbormaster completed remote builds in B190901: Diff 465998.Oct 7 2022, 2:42 AM

I have updated the file and have run 'arc diff' command.

In D135431#3842534, @adeelahmad81299 wrote:

I have updated the file and have run 'arc diff' command.

Hmm, I do not see the updated diff here in phabricator.
I do not use arc myself, so I'm not sure what the right command is to upload the most recent version of your patch here.
Looking at the documentation about arc at https://secure.phabricator.com/book/phabricator/article/arcanist_diff/, did you maybe forget to run the 'git commit -a' command before running 'arc diff'?

Added Month/Year for which the list of targets is complete

Harbormaster completed remote builds in B191218: Diff 466428.Oct 9 2022, 11:10 PM

I've reuploaded the changed diff. Can you see it now?

In D135431#3846049, @adeelahmad81299 wrote:

I've reuploaded the changed diff. Can you see it now?

I can, thank you.

This patch LGTM.

Do you want me to commit it for you?

This revision is now accepted and ready to land.Oct 9 2022, 11:54 PM

Yes, sure.

This revision was landed with ongoing or failed builds.Oct 10 2022, 1:35 AM

Closed by commit rGc3e073bcbdc5: Extended Documentation of LLVM_TARGETS_TO_BUILD by listing all possible values (authored by adeelahmad81299, committed by kristof.beyls). · Explain Why

This revision was automatically updated to reflect the committed changes.

kristof.beyls added a commit: rGc3e073bcbdc5: Extended Documentation of LLVM_TARGETS_TO_BUILD by listing all possible values.

Revision Contents

Path

Size

llvm/

docs/

CMake.rst

2 lines

Diff 466428

llvm/docs/CMake.rst

Show First 20 Lines • Show All 732 Lines • ▼ Show 20 Lines	LLVM_TARGET_ARCH:STRING
LLVM target to use for native code generation. This is required for JIT		LLVM target to use for native code generation. This is required for JIT
generation. It defaults to "host", meaning that it shall pick the architecture		generation. It defaults to "host", meaning that it shall pick the architecture
of the machine where LLVM is being built. If you are cross-compiling, set it		of the machine where LLVM is being built. If you are cross-compiling, set it
to the target architecture name.		to the target architecture name.

LLVM_TARGETS_TO_BUILD:STRING		LLVM_TARGETS_TO_BUILD:STRING
Semicolon-separated list of targets to build, or all for building all		Semicolon-separated list of targets to build, or all for building all
targets. Case-sensitive. Defaults to all. Example:		targets. Case-sensitive. Defaults to all. Example:
``-DLLVM_TARGETS_TO_BUILD="X86;PowerPC"``. The full list, as of October 2022, is:		``-DLLVM_TARGETS_TO_BUILD="X86;PowerPC"``. The full list, as of October 2022, is:
``AArch64;AMDGPU;ARM;AVR;BPF;Hexagon;Lanai;Mips;MSP430;NVPTX;PowerPC;RISCV;Sparc;SystemZ;VE;WebAssembly;X86;XCore``		``AArch64;AMDGPU;ARM;AVR;BPF;Hexagon;Lanai;Mips;MSP430;NVPTX;PowerPC;RISCV;Sparc;SystemZ;VE;WebAssembly;X86;XCore``
		kristof.beylsUnsubmitted Done Reply Inline Actions The backends available in LLVM can change over time. When a backend is removed/added, the people doing so may well forget to update the list here. Therefore, maybe it may be better to write: "The full list, as of October 2022, is:"? kristof.beyls: The backends available in LLVM can change over time. When a backend is removed/added, the…

LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN:BOOL		LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN:BOOL
If enabled, the compiler version check will only warn when using a toolchain		If enabled, the compiler version check will only warn when using a toolchain
which is about to be deprecated, instead of emitting an error.		which is about to be deprecated, instead of emitting an error.

LLVM_UBSAN_FLAGS:STRING		LLVM_UBSAN_FLAGS:STRING
Defines the set of compile flags used to enable UBSan. Only used if		Defines the set of compile flags used to enable UBSan. Only used if
``LLVM_USE_SANITIZER`` contains ``Undefined``. This can be used to override		``LLVM_USE_SANITIZER`` contains ``Undefined``. This can be used to override
▲ Show 20 Lines • Show All 343 Lines • Show Last 20 Lines