This is an archive of the discontinued LLVM Phabricator instance.

Extended Documentation of LLVM_TARGETS_TO_BUILD by listing all possible values
ClosedPublic

Authored by adeelahmad81299 on Oct 7 2022, 1:22 AM.

Diff Detail

Event Timeline

adeelahmad81299 created this revision.Oct 7 2022, 1:22 AM
adeelahmad81299 requested review of this revision.Oct 7 2022, 1:22 AM

I just have one minor suggestion.
Otherwise, LGTM.

llvm/docs/CMake.rst
741–742

The backends available in LLVM can change over time.
When a backend is removed/added, the people doing so may well forget to update the list here.
Therefore, maybe it may be better to write:
"The full list, as of October 2022, is:"?

adeelahmad81299 marked an inline comment as done.Oct 7 2022, 3:45 AM

I have updated the file and have run 'arc diff' command.

I have updated the file and have run 'arc diff' command.

Hmm, I do not see the updated diff here in phabricator.
I do not use arc myself, so I'm not sure what the right command is to upload the most recent version of your patch here.
Looking at the documentation about arc at https://secure.phabricator.com/book/phabricator/article/arcanist_diff/, did you maybe forget to run the 'git commit -a' command before running 'arc diff'?

adeelahmad81299 marked an inline comment as not done.

Added Month/Year for which the list of targets is complete

adeelahmad81299 marked an inline comment as done.Oct 9 2022, 11:14 PM

I've reuploaded the changed diff. Can you see it now?

kristof.beyls accepted this revision.Oct 9 2022, 11:54 PM

I've reuploaded the changed diff. Can you see it now?

I can, thank you.

This patch LGTM.

Do you want me to commit it for you?

This revision is now accepted and ready to land.Oct 9 2022, 11:54 PM
This revision was landed with ongoing or failed builds.Oct 10 2022, 1:35 AM
This revision was automatically updated to reflect the committed changes.