This is an archive of the discontinued LLVM Phabricator instance.

[lld/COFF] Ignore `/ASSEMBLYDEBUG[:NONE]` and `/EMITPOGOPHASEINFO`
ClosedPublic

Authored by oberrich on Oct 2 2022, 7:32 AM.

Details

Summary

Adds aforementioned link switches in lld-link and ignores them.

Diff Detail

Event Timeline

oberrich created this revision.Oct 2 2022, 7:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 2 2022, 7:32 AM
oberrich requested review of this revision.Oct 2 2022, 7:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 2 2022, 7:32 AM
hans accepted this revision.Oct 3 2022, 4:48 AM

lgtm

This revision is now accepted and ready to land.Oct 3 2022, 4:48 AM

Thanks for the review! Unfortunately I don't have commit access to llvm yet and need someone to land this change on my behalf.

hans added a comment.Oct 3 2022, 6:02 AM

Thanks for the review! Unfortunately I don't have commit access to llvm yet and need someone to land this change on my behalf.

I'll be happy to do that. What name should I put as the commit author?

I'll be happy to do that. What name should I put as the commit author?

oberrich <6305520+oberrich@users.noreply.github.com>

hans added a comment.Oct 3 2022, 6:16 AM

I'll be happy to do that. What name should I put as the commit author?

oberrich <6305520+oberrich@users.noreply.github.com>

Is that a working email address? I'm not sure on the exact policy, but I think a working email is expected.

Is that a working email address? I'm not sure on the exact policy, but I think a working email is expected.

In that case use oberrich <oberrich.llvm@proton.me>

This revision was automatically updated to reflect the committed changes.