lldProject
ActivePublic

Properties

Description

LLVM Linker

Recent Activity

Today

atanasyan added inline comments to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.
Tue, Nov 21, 2:37 AM · lld
ikudrin removed a dependency for D38790: [ELF] Do not keep symbols if they referenced only from discarded sections.: D40240: Garbage-collected symbols shouldn't make DSOs alive..
Tue, Nov 21, 12:36 AM · lld
ikudrin updated the diff for D38790: [ELF] Do not keep symbols if they referenced only from discarded sections..
  • Do not depend on D40240.
  • Mark test/ELF/gc-sections-shared.s to be in an intermediate state.
Tue, Nov 21, 12:36 AM · lld
ruiu added inline comments to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.
Tue, Nov 21, 12:31 AM · lld

Yesterday

ruiu accepted D40253: [ELF] Make tests with undefined symbols more explicit..

LGTM

Mon, Nov 20, 11:27 PM · lld
ruiu added a comment to D38790: [ELF] Do not keep symbols if they referenced only from discarded sections..

Can you upload a patch again? It seems like this patch is not against master but against my patch.

Mon, Nov 20, 11:24 PM · lld
ruiu added a comment to D39972: [LLD] [COFF] Support ENTRY and SUBSYSTEM in .drectve sections.

I think I can approve if you add a test.

Mon, Nov 20, 11:08 PM · lld
dmajor added a comment to D39972: [LLD] [COFF] Support ENTRY and SUBSYSTEM in .drectve sections.
Mon, Nov 20, 1:58 PM · lld
dmajor updated the diff for D39968: [COFF] Ignore semicolons in module definition identifiers.

Added a test. If this looks OK, do you mind landing it for me?

Mon, Nov 20, 9:20 AM · lld
ikudrin added a dependent revision for D40253: [ELF] Make tests with undefined symbols more explicit.: D38790: [ELF] Do not keep symbols if they referenced only from discarded sections..
Mon, Nov 20, 8:11 AM · lld
ikudrin added dependencies for D38790: [ELF] Do not keep symbols if they referenced only from discarded sections.: D40253: [ELF] Make tests with undefined symbols more explicit., D40240: Garbage-collected symbols shouldn't make DSOs alive..
Mon, Nov 20, 8:11 AM · lld
ikudrin added a comment to D38790: [ELF] Do not keep symbols if they referenced only from discarded sections..
In D38790#930021, @ruiu wrote:

I feel like this patch is a bit too complicated, but I can't really point out why I felt like that. This patch actually does two different things, no? Do you mind if I ask you to split it? I think one patch can be something like this https://reviews.llvm.org/D40240, and you can create another patch not to add dead symbols to the symbol table later.

Mon, Nov 20, 8:07 AM · lld
ikudrin updated the diff for D38790: [ELF] Do not keep symbols if they referenced only from discarded sections..
  • Extract corrections in the existing tests into D40253.
  • Use handling of DT_NEEDED from D40240.
  • Don't try to maintain actual Live flag for all symbols. Just mark symbols used in relocations in live sections and make the final decision later in includeInSymtab.
Mon, Nov 20, 7:59 AM · lld
ikudrin created D40253: [ELF] Make tests with undefined symbols more explicit..
Mon, Nov 20, 7:39 AM · lld
ruiu added a comment to D38790: [ELF] Do not keep symbols if they referenced only from discarded sections..

I feel like this patch is a bit too complicated, but I can't really point out why I felt like that. This patch actually does two different things, no? Do you mind if I ask you to split it? I think one patch can be something like this https://reviews.llvm.org/D40240, and you can create another patch not to add dead symbols to the symbol table later.

Mon, Nov 20, 1:22 AM · lld

Thu, Nov 16

atanasyan created D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.
Thu, Nov 16, 1:24 PM · lld
ikudrin added inline comments to D38790: [ELF] Do not keep symbols if they referenced only from discarded sections..
Thu, Nov 16, 3:41 AM · lld

Tue, Nov 14

ruiu added inline comments to D38790: [ELF] Do not keep symbols if they referenced only from discarded sections..
Tue, Nov 14, 12:21 AM · lld

Mon, Nov 13

mstorsjo added inline comments to D39972: [LLD] [COFF] Support ENTRY and SUBSYSTEM in .drectve sections.
Mon, Nov 13, 11:14 PM · lld
ruiu added a comment to D39968: [COFF] Ignore semicolons in module definition identifiers.

The NSS project's .def files make heavy use of semicolons in a frightening attempt at portability: https://hg.mozilla.org/projects/nss/raw-file/tip/lib/ckfw/capi/nsscapi.def

Mon, Nov 13, 5:38 PM · lld
ruiu added a comment to D39972: [LLD] [COFF] Support ENTRY and SUBSYSTEM in .drectve sections.

Can you add a test?

Mon, Nov 13, 5:25 PM · lld
dmajor created D39972: [LLD] [COFF] Support ENTRY and SUBSYSTEM in .drectve sections.
Mon, Nov 13, 12:46 PM · lld
dmajor updated subscribers of D39968: [COFF] Ignore semicolons in module definition identifiers.
Mon, Nov 13, 11:14 AM · lld
dmajor created D39968: [COFF] Ignore semicolons in module definition identifiers.
Mon, Nov 13, 10:40 AM · lld

Thu, Nov 9

ikudrin abandoned D34612: [ELF] Do not add a .tbss section into a PT_LOAD segment in case of using a linker script..
Thu, Nov 9, 8:27 PM · lld
ikudrin updated the diff for D38790: [ELF] Do not keep symbols if they referenced only from discarded sections..
  • Rebase on the top.
  • Add flag 'Live' to Symbol.
  • Determine most of the alive symbols during GC phase.
Thu, Nov 9, 3:17 AM · lld

Wed, Nov 8

ruiu added inline comments to D39322: [lld] Support RISC-V.
Wed, Nov 8, 4:03 PM · lld

Mon, Nov 6

PkmX updated the diff for D39324: [lld] Support TLS in RISC-V.

Rebase onto latest master

Mon, Nov 6, 11:13 PM · lld
PkmX updated the diff for D39323: [lld] Support dynamic linking in RISC-V.
  • Rebase onto latest master
  • Clean up #includes
Mon, Nov 6, 11:13 PM · lld
PkmX updated the diff for D39322: [lld] Support RISC-V.
  • Rebase onto latest master
  • Clean up #includes
Mon, Nov 6, 11:12 PM · lld

Wed, Nov 1

PkmX updated the diff for D39323: [lld] Support dynamic linking in RISC-V.

clang-format-diff RISCV::writePLT.

Wed, Nov 1, 1:49 AM · lld
PkmX updated the diff for D39322: [lld] Support RISC-V.

Make R_RISCV_CALL reuse R_RISCV_PCREL_HI20 and R_RISCV_PCREL_LO12_I.

Wed, Nov 1, 1:46 AM · lld

Tue, Oct 31

ruiu added inline comments to D39322: [lld] Support RISC-V.
Tue, Oct 31, 5:36 PM · lld
PkmX added a comment to D39322: [lld] Support RISC-V.

I believe the best place would be either the issue tracker on the psABI doc, or RISC-V's sw-dev mailing list.

Tue, Oct 31, 5:24 PM · lld
ruiu added a comment to D39322: [lld] Support RISC-V.

What do you think of lo20 relocations? If there's a better place to ask about the design of the RISC-V ABI, please let me know so that I can start a thread.

Tue, Oct 31, 4:01 PM · lld
iid_iunknown closed D39353: [lld] Fix --exclude-libs broken when --whole-archive is used.
Tue, Oct 31, 6:51 AM · lld
iid_iunknown updated the diff for D39353: [lld] Fix --exclude-libs broken when --whole-archive is used.

Use Optional in getArchiveName()

Tue, Oct 31, 6:44 AM · lld
iid_iunknown added inline comments to D39353: [lld] Fix --exclude-libs broken when --whole-archive is used.
Tue, Oct 31, 6:42 AM · lld
asb added a comment to D39322: [lld] Support RISC-V.

I'm not an LLD expert, but the RISC-V bits seem correct as far as I can see. I've just added a couple of minor comments.

Tue, Oct 31, 2:49 AM · lld

Mon, Oct 30

PkmX updated the diff for D39324: [lld] Support TLS in RISC-V.
  • Mark TLS_DTP_OFFSET as internal linkage.
Mon, Oct 30, 11:56 PM · lld
PkmX updated the diff for D39323: [lld] Support dynamic linking in RISC-V.
  • Use write32le.
  • Since __global_pointer$ is no longer absolute, remove workaround to make it a static link-time constant in PIE.
Mon, Oct 30, 11:54 PM · lld
PkmX updated the diff for D39322: [lld] Support RISC-V.
  • Use {read,write}32le to read/write insturctions.
  • Make __global_pointer$ non-absolute.
Mon, Oct 30, 11:52 PM · lld
ruiu accepted D39353: [lld] Fix --exclude-libs broken when --whole-archive is used.

LGTM with this change.

Mon, Oct 30, 4:12 PM · lld
jakehehrlich closed D38907: Give .note.gnu.build-id section alignment 4 by committing rL316961: Give .note.gnu.build-id section alignment 4.
Mon, Oct 30, 3:08 PM · lld
ruiu added inline comments to D39324: [lld] Support TLS in RISC-V.
Mon, Oct 30, 1:40 PM · lld
ruiu added inline comments to D39323: [lld] Support dynamic linking in RISC-V.
Mon, Oct 30, 1:38 PM · lld
ruiu added a comment to D39322: [lld] Support RISC-V.

Generally looking pretty good except lo12 relocations.

Mon, Oct 30, 1:29 PM · lld
PkmX updated the diff for D39324: [lld] Support TLS in RISC-V.

De-template RISCV class.

Mon, Oct 30, 4:26 AM · lld
PkmX updated the diff for D39323: [lld] Support dynamic linking in RISC-V.

De-template RISCV class and assume little-endian.

Mon, Oct 30, 4:25 AM · lld
PkmX updated the diff for D39322: [lld] Support RISC-V.
  • Renamed uint32_t to RelType.
  • Detemplate the RISCV class.
Mon, Oct 30, 4:24 AM · lld