lldProject
ActivePublic

Details

Description

LLVM Linker

Recent Activity

Fri, Jun 15

sidneym created D48235: Add R_HEX_B32_PCREL_X and R_HEX_B22_PCREL_X relocations.
Fri, Jun 15, 1:25 PM · lld

Wed, Jun 13

sidneym closed D47791: Initial support for Hexagon target..
Wed, Jun 13, 11:49 AM · lld
ruiu accepted D47791: Initial support for Hexagon target..
Wed, Jun 13, 10:54 AM · lld
sidneym updated the diff for D47791: Initial support for Hexagon target..

Use type instead of auto.

Wed, Jun 13, 6:10 AM · lld

Mon, Jun 11

atanasyan added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

Thanks for all for your support, review and comments.

Mon, Jun 11, 12:29 AM · lld
atanasyan closed D31528: [ELF][MIPS] Multi-GOT implementation.
Mon, Jun 11, 12:28 AM · lld

Sun, Jun 10

arichardson accepted D31528: [ELF][MIPS] Multi-GOT implementation.
Sun, Jun 10, 11:15 AM · lld
brad added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

OpenBSD/mips64 is looking at switching to LLVM/Clang and this would be required for us when we look at using lld for the linker.

Sun, Jun 10, 8:06 AM · lld

Fri, Jun 8

grimar accepted D31528: [ELF][MIPS] Multi-GOT implementation.

I think that:

  1. Simon is obviously an expert in MIPS. We have probably no other good reviewers on this platform here anyways.
  2. Patch has no critical stylish issues. I added few minor nits though. Anything else can be fixed after.
  3. It already took really too long to progress.
  4. Patch mostly affects MIPS parts of the LLD code (so it is isolated).
  5. Post-commit reviews are OK in general practice.
  6. It is important and desired patch for FreeBSD.
Fri, Jun 8, 3:58 AM · lld

Thu, Jun 7

ruiu added inline comments to D47791: Initial support for Hexagon target..
Thu, Jun 7, 4:34 PM · lld
sidneym updated the diff for D47791: Initial support for Hexagon target..

Integrated suggested changes.

Thu, Jun 7, 4:26 PM · lld
atanasyan updated the diff for D31528: [ELF][MIPS] Multi-GOT implementation.

Rebased against the trunk.

Thu, Jun 7, 8:28 AM · lld

Wed, Jun 6

ruiu added inline comments to D47791: Initial support for Hexagon target..
Wed, Jun 6, 11:29 AM · lld
sidneym updated the diff for D47791: Initial support for Hexagon target..

Adopted more of Rui's suggestions.

Wed, Jun 6, 9:01 AM · lld
joel_k_jones closed D47748: [lld] Add REQUIRES: x86 where needed to tests.
Wed, Jun 6, 7:01 AM · lld

Tue, Jun 5

labath updated subscribers of D47791: Initial support for Hexagon target..
Tue, Jun 5, 12:51 PM · lld
ruiu added inline comments to D47791: Initial support for Hexagon target..
Tue, Jun 5, 11:27 AM · lld
sidneym updated the diff for D47791: Initial support for Hexagon target..

Made the changes Rui suggested.

Tue, Jun 5, 11:23 AM · lld
ruiu added inline comments to D47791: Initial support for Hexagon target..
Tue, Jun 5, 11:09 AM · lld
sidneym created D47791: Initial support for Hexagon target..
Tue, Jun 5, 11:05 AM · lld
ruiu accepted D47748: [lld] Add REQUIRES: x86 where needed to tests.

LGTM

Tue, Jun 5, 7:59 AM · lld
peter.smith added reviewers for D47748: [lld] Add REQUIRES: x86 where needed to tests: ruiu, grimar.

This looks good to me. I've checked that each of the files has some requirement such as an x86 target triple. I've added the code owner Rui and a frequent contributor George to see if they have any objections.

Tue, Jun 5, 1:31 AM · lld

Mon, Jun 4

joel_k_jones created D47748: [lld] Add REQUIRES: x86 where needed to tests.
Mon, Jun 4, 4:28 PM · lld

Tue, May 29

emaste added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

Ping?

@ruiu could I use a post-commit review option in that case?

Tue, May 29, 10:55 AM · lld
emaste removed a reviewer for D31528: [ELF][MIPS] Multi-GOT implementation: espindola.
Tue, May 29, 10:25 AM · lld
atanasyan added a comment to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

@ruiu could I use a post-commit review option in that case?

Tue, May 29, 9:24 AM · lld
atanasyan added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

@ruiu could I use a post-commit review option in that case?

Tue, May 29, 9:23 AM · lld

Wed, May 23

arichardson accepted D31528: [ELF][MIPS] Multi-GOT implementation.

As I have mentioned before, having this patch is the difference between LLD being completely unusable for our purposes (linking FreeBSD MIPS n64) and being able to replace BFD.

Wed, May 23, 1:22 AM · lld

Tue, May 22

atanasyan added a comment to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

Ping?

Tue, May 22, 10:05 PM · lld
atanasyan added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

Ping?

Tue, May 22, 10:05 PM · lld

May 16 2018

lantictac added a comment to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).

Also: Just noticed that response files aren't being expanded inline in the stored command-line (as per MSVC link.exe). I'll open a bug for it.

May 16 2018, 2:55 PM · lld

May 15 2018

atanasyan added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

Ping?

May 15 2018, 5:29 AM · lld
atanasyan added a comment to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

Ping?

May 15 2018, 5:29 AM · lld

May 14 2018

lantictac added a comment to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).

A few issues. On the DOS command-line I can shoehorn in some escaped double-quotes using /manifestuac:"level='asInvoker' uiAccess=""false""" and still generate a PDB. However:

May 14 2018, 7:41 AM · lld

May 11 2018

pcc added a comment to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).

It looks like MSVC does not bother to quote quotation marks correctly.

/mnt/c/src/tmp$ cat quote.yaml
--- !COFF
header:
  Machine:         IMAGE_FILE_MACHINE_I386
  Characteristics: [  ]  
sections:
  - Name:            '.text'
    Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_MEM_READ, IMAGE_SCN_MEM_EXECUTE ]
    Alignment:       1   
    SectionData:     00  
symbols:
  - Name:            '"'
    Value:           0
    SectionNumber:   1
    SimpleType:      IMAGE_SYM_TYPE_NULL
    ComplexType:     IMAGE_SYM_DTYPE_NULL
    StorageClass:    IMAGE_SYM_CLASS_EXTERNAL
...
/mnt/c/src/tmp$ ../l/ra/bin/yaml2obj.exe quote.yaml  > quote.obj
May 11 2018, 11:17 AM · lld
lantictac added inline comments to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).
May 11 2018, 11:14 AM · lld
ruiu added inline comments to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).
May 11 2018, 10:58 AM · lld
lantictac added a comment to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).

Hi All, What's the consensus on the additional checks? I can try and add support for the theoretical corner cases but without being able to construct test cases I'm not sure how useful it'd be.

May 11 2018, 10:49 AM · lld

May 8 2018

lantictac added inline comments to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).
May 8 2018, 11:38 AM · lld
atanasyan closed D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output.
May 8 2018, 8:37 AM · lld
atanasyan updated the diff for D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

Rebased against the trunk.

May 8 2018, 7:07 AM · lld
atanasyan updated the diff for D31528: [ELF][MIPS] Multi-GOT implementation.

Rebased against the trunk.

May 8 2018, 7:06 AM · lld

May 7 2018

ruiu added inline comments to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).
May 7 2018, 4:04 PM · lld
amccarth added inline comments to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).
May 7 2018, 3:54 PM · lld
lantictac updated the diff for D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).

Extracted implementation to a quote() function.

May 7 2018, 3:54 PM · lld
lantictac added inline comments to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).
May 7 2018, 3:03 PM · lld

May 4 2018

zturner added inline comments to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).
May 4 2018, 3:21 PM · lld
ruiu added inline comments to D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).
May 4 2018, 3:13 PM · lld
lantictac created D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC).
May 4 2018, 6:01 AM · lld

Apr 26 2018

atanasyan updated the diff for D31528: [ELF][MIPS] Multi-GOT implementation.

Rebased against the trunk.

Apr 26 2018, 11:38 PM · lld