Page MenuHomePhabricator

lldProject
ActivePublic

Watchers

  • This project does not have any watchers.

Details

Description

LLVM Linker

Recent Activity

Yesterday

tmsriram updated the diff for D68065: Propeller: LLD Support for Basic Block Sections.
  • Bug fixes
  • clang format
Thu, Jan 16, 5:56 PM · Restricted Project, lld

Wed, Jan 15

rnk added a comment to D70557: [lld][COFF] Add support for /map.

A couple of nits, but I think it looks pretty good, thanks!

Wed, Jan 15, 12:05 PM · Restricted Project, lld
saudi added reviewers for D70557: [lld][COFF] Add support for /map: amccarth, mstorsjo.
Wed, Jan 15, 6:39 AM · Restricted Project, lld
ikudrin closed D72695: [MachO] Add a test for detecting reserved unit length..
Wed, Jan 15, 2:00 AM · Restricted Project, lld

Tue, Jan 14

dblaikie accepted D72695: [MachO] Add a test for detecting reserved unit length..
Tue, Jan 14, 8:22 AM · Restricted Project, lld
ikudrin added a comment to D71546: [MachO] Fix detecting malformed DWARF..

Was this fixing an existing buildbot/test failure? (if not, it should probably have a test? If it did fix an existing failure - could you mention what that failure was?)

Tue, Jan 14, 5:26 AM · Restricted Project, lld
ikudrin created D72695: [MachO] Add a test for detecting reserved unit length..
Tue, Jan 14, 5:16 AM · Restricted Project, lld

Mon, Jan 13

kiszk updated the diff for D72339: [lld] NFC: fix trivial typos in comments.

rebase with master

Mon, Jan 13, 8:49 PM · Restricted Project, lld

Thu, Jan 9

sidneym closed D71143: [ELF][Hexagon] Add support for TLS IE relocations.
Thu, Jan 9, 7:53 AM · Restricted Project, lld

Wed, Jan 8

MaskRay accepted D71143: [ELF][Hexagon] Add support for TLS IE relocations.
Wed, Jan 8, 11:55 AM · Restricted Project, lld
sidneym updated the diff for D71143: [ELF][Hexagon] Add support for TLS IE relocations.

Address testcase issues.

Wed, Jan 8, 11:36 AM · Restricted Project, lld
kiszk retitled D72339: [lld] NFC: fix trivial typos in comments from [lld] fix trivial typos in comments to [lld] NFC: fix trivial typos in comments.
Wed, Jan 8, 2:56 AM · Restricted Project, lld

Tue, Jan 7

MaskRay added inline comments to D71143: [ELF][Hexagon] Add support for TLS IE relocations.
Tue, Jan 7, 2:45 PM · Restricted Project, lld
Eugene.Zelenko added a reviewer for D72339: [lld] NFC: fix trivial typos in comments: ruiu.
Tue, Jan 7, 10:05 AM · Restricted Project, lld
sidneym updated the diff for D71143: [ELF][Hexagon] Add support for TLS IE relocations.

Move hasStaticTlsModel from R_GOT case to the suggested R_GOTPLT case.

Tue, Jan 7, 8:02 AM · Restricted Project, lld
sidneym updated the diff for D71143: [ELF][Hexagon] Add support for TLS IE relocations.

Add config->hasStaticTlsModel in R_GOT case.

Tue, Jan 7, 7:42 AM · Restricted Project, lld

Mon, Jan 6

sidneym added a comment to D71143: [ELF][Hexagon] Add support for TLS IE relocations.

I'd like to ask some questions which can help understand the situation better.

  • Does Hexagon have a binutils port or an alternative linker?

The binutils port was never made public. The internal linker can be downloaded with a click-thu license agreement, the same one needed to get to the ABI spec. That linker is a branch of mclinker.

Like @ruiu argued before, a click-thu license agreement may be unacceptable in many environments. I am also concerned whether a click-thru license agreement is considered 100% GPLv3 conformance.

All hexagon work on binutils/gcc was done during the GPLv2 timeframe. The downloadable linker I'm referring to is a branch from the old mclinker project.

Mon, Jan 6, 4:03 PM · Restricted Project, lld
MaskRay added a comment to D71143: [ELF][Hexagon] Add support for TLS IE relocations.

I'd like to ask some questions which can help understand the situation better.

  • Does Hexagon have a binutils port or an alternative linker?

The binutils port was never made public. The internal linker can be downloaded with a click-thu license agreement, the same one needed to get to the ABI spec. That linker is a branch of mclinker.

Mon, Jan 6, 3:22 PM · Restricted Project, lld
sidneym added a comment to D71143: [ELF][Hexagon] Add support for TLS IE relocations.

I'd like to ask some questions which can help understand the situation better.

  • Does Hexagon have a binutils port or an alternative linker?

The binutils port was never made public. The internal linker can be downloaded with a click-thu license agreement, the same one needed to get to the ABI spec. That linker is a branch of mclinker.

  • Is -pie and -shared used a lot on Hexagon?

-pie isn't but shared is.

  • How is Hexagon's dynamic loader ld.so implemented? Is the source code available?

The code isn't yet available from Qualcomm but we have a port of MUSL and I don't think much more than adding the #defines to reloc.h and the files dlsym.s/tlsdesc.s was done. Nothing weird for hexagon.

  • How is TLS going to be used on Hexagon?

There isn't anything out of the ordinary in how it is used and it is necessary for C++11 support.

  • Is text relocations acceptable?

No. The reason I needed to add the -z notext in the -shared test was because technically the wrong relocations were being used. I did that so that I could condense the IE patch into a single file testcase.

  • Is it really impossible to use a PC-relative GOT address load on Hexagon? R_GOT on EM_386 has severe limitations. EM_X86_64 fixed these issues. (I don't want to see newer architectures behave like it.)

The R_HEX_IE_GOT... are used for shared/pic code. As far as I know the R_HEX_IE_32_6_X/16_X.. are used only when building static code. The ABI has examples for both of these IE static and IE for PIC.

I shall also mention that this is unfortunate.

bool canRelax = config->emachine != EM_ARM &&
                config->emachine != EM_RISCV;

RISC-V TLS has several problems. Its design/implementation was copied from ARM/MIPS. The two architectures really do not provide the best reference for TLS implementations. The RISC-V TLS implementation has several defects. I've reported a few bugs on the binutils bugzilla.

Mon, Jan 6, 2:16 PM · Restricted Project, lld
MaskRay added a comment to D71143: [ELF][Hexagon] Add support for TLS IE relocations.

I'd like to ask some questions which can help understand the situation better.

Mon, Jan 6, 11:55 AM · Restricted Project, lld
sidneym updated the diff for D71143: [ELF][Hexagon] Add support for TLS IE relocations.

Update Check names.

Mon, Jan 6, 10:44 AM · Restricted Project, lld
MaskRay closed D72196: [lld] Fix trivial typos in comments.
Mon, Jan 6, 10:26 AM · Restricted Project, lld
MaskRay accepted D72196: [lld] Fix trivial typos in comments.
Mon, Jan 6, 10:25 AM · Restricted Project, lld
Mordante closed D72210: [NFC] Fixes -Wrange-loop-analysis warnings.
Mon, Jan 6, 8:38 AM · Restricted Project, lld
saudi added a comment to D70557: [lld][COFF] Add support for /map.

Ping!

Mon, Jan 6, 8:34 AM · Restricted Project, lld
MaskRay accepted D72210: [NFC] Fixes -Wrange-loop-analysis warnings.
Mon, Jan 6, 12:26 AM · Restricted Project, lld

Sun, Jan 5

kiszk added a comment to D72196: [lld] Fix trivial typos in comments.

I do not have commit rights to the repository. Could someone commit this change if it is OK?
Kazuaki Ishizaki <ishizaki@jp.ibm.com>

Sun, Jan 5, 11:30 PM · Restricted Project, lld
ruiu accepted D72196: [lld] Fix trivial typos in comments.

LGTM

Sun, Jan 5, 10:34 PM · Restricted Project, lld
nicolasvasilache accepted D72210: [NFC] Fixes -Wrange-loop-analysis warnings.

LGTM

Sun, Jan 5, 12:44 PM · Restricted Project, lld
Mordante updated the diff for D72210: [NFC] Fixes -Wrange-loop-analysis warnings.

Rebased on master. This adds one new fix and removes the ones done by others.

Sun, Jan 5, 5:43 AM · Restricted Project, lld

Sat, Jan 4

Mordante added a comment to D72210: [NFC] Fixes -Wrange-loop-analysis warnings.

You can drop changes to lld. I've fixed lld -Wrange-loop-analysis a few days ago in 681b1be774964a804beabfb7c5e3bdab8f979e4a . (Archive::Child c was also deleted).

For mlir, only mlir/lib/Dialect/Linalg/Utils/Utils.cpp:117:8 needs a fix. I've fixed others in eeef50b1fee91dbe993187324003d2665ceae331.

Sat, Jan 4, 12:52 PM · Restricted Project, lld
MaskRay added a comment to D72210: [NFC] Fixes -Wrange-loop-analysis warnings.

You can drop changes to lld. I've fixed lld -Wrange-loop-analysis a few days ago in 681b1be774964a804beabfb7c5e3bdab8f979e4a . (Archive::Child c was also deleted).

Sat, Jan 4, 12:33 PM · Restricted Project, lld
rriddle accepted D72210: [NFC] Fixes -Wrange-loop-analysis warnings.

MLIR looks fine to me.

Sat, Jan 4, 11:38 AM · Restricted Project, lld
Harbormaster failed remote builds in B43293: Diff 236192 for D72210: [NFC] Fixes -Wrange-loop-analysis warnings!
Sat, Jan 4, 11:30 AM · Restricted Project, lld
merge_guards_bot added a comment to D72210: [NFC] Fixes -Wrange-loop-analysis warnings.

Build artifacts: diff.json, console-log.txt

Sat, Jan 4, 11:30 AM · Restricted Project, lld
Mordante created D72210: [NFC] Fixes -Wrange-loop-analysis warnings.
Sat, Jan 4, 11:29 AM · Restricted Project, lld
Eugene.Zelenko added a reviewer for D72196: [lld] Fix trivial typos in comments: ruiu.
Sat, Jan 4, 7:41 AM · Restricted Project, lld

Fri, Jan 3

MaskRay added inline comments to D71143: [ELF][Hexagon] Add support for TLS IE relocations.
Fri, Jan 3, 5:07 PM · Restricted Project, lld
penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

yaml2obj is capable of producing binary .rdata section (which would host CET bit) from hex, but not individual debug directories that would go into it. Looks like all the tests dealing wit debug directories are using pre-built binaries - codeview tests are a good example).

Fri, Jan 3, 4:47 PM · Restricted Project, lld
sidneym updated the diff for D71143: [ELF][Hexagon] Add support for TLS IE relocations.

merge ie and iegot relocations
put the testcase into just a single file.

Fri, Jan 3, 1:39 PM · Restricted Project, lld

Thu, Jan 2

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

LLVM Release Schedule: 10.0.0: Jan 15, 2020: branch, then rc1

Thu, Jan 2, 8:16 PM · Restricted Project, Restricted Project, lld

Wed, Jan 1

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

Ping?

Wed, Jan 1, 6:34 AM · Restricted Project, Restricted Project, lld

Fri, Dec 27

dblaikie added a comment to D71546: [MachO] Fix detecting malformed DWARF..

Was this fixing an existing buildbot/test failure? (if not, it should probably have a test? If it did fix an existing failure - could you mention what that failure was?)

Fri, Dec 27, 2:37 PM · Restricted Project, lld

Thu, Dec 26

lygstate added a comment to D71887: fixes musl default stack size to small..

stack-size 2MB is the default stack size of glibc.

Thu, Dec 26, 1:36 AM · lld, Restricted Project
lygstate created D71887: fixes musl default stack size to small..
Thu, Dec 26, 1:27 AM · lld, Restricted Project

Fri, Dec 20

krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

@MaskRay I will mail you off-list with one question.

Fri, Dec 20, 3:38 PM · Restricted Project, Restricted Project, lld
krytarowski added a comment to D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld).

Ping?

Fri, Dec 20, 3:38 PM · Restricted Project, Restricted Project, lld

Dec 17 2019

ikudrin closed D71546: [MachO] Fix detecting malformed DWARF..
Dec 17 2019, 12:09 AM · Restricted Project, lld

Dec 16 2019

probinson accepted D71546: [MachO] Fix detecting malformed DWARF..

LGTM

Dec 16 2019, 6:52 AM · Restricted Project, lld
ikudrin created D71546: [MachO] Fix detecting malformed DWARF..
Dec 16 2019, 6:35 AM · Restricted Project, lld