lldProject
ActivePublic

Properties

Description

LLVM Linker

Recent Activity

Today

phosek closed D35706: [ELF] Remove processNonSectionCommands by committing rL308706: [ELF] Remove processNonSectionCommands.
Thu, Jul 20, 6:03 PM · lld
ruiu accepted D35706: [ELF] Remove processNonSectionCommands.

LGTM

Thu, Jul 20, 4:51 PM · lld
phosek closed D35651: [ELF] Align the value if needed when computing the expression.
Thu, Jul 20, 4:31 PM · lld
phosek created D35706: [ELF] Remove processNonSectionCommands.
Thu, Jul 20, 4:30 PM · lld
ruiu accepted D35651: [ELF] Align the value if needed when computing the expression.

LGTM

Thu, Jul 20, 3:42 PM · lld
phosek added a comment to D35651: [ELF] Align the value if needed when computing the expression.
In D35651#816244, @ruiu wrote:

The test you added doesn't seem to exercise the code you added. Don't you need something like ALIGN(3, 8) + 10 to test that?

Thu, Jul 20, 3:41 PM · lld
phosek updated the diff for D35651: [ELF] Align the value if needed when computing the expression.
Thu, Jul 20, 3:39 PM · lld
ruiu accepted D35537: [ELF] Avoid data race in ObjectFile<ELFT>::getDILineInfo()..

LGTM

Thu, Jul 20, 9:29 AM · lld
ruiu added a comment to D35651: [ELF] Align the value if needed when computing the expression.

The test you added doesn't seem to exercise the code you added. Don't you need something like ALIGN(3, 8) + 10 to test that?

Thu, Jul 20, 8:36 AM · lld

Yesterday

phosek added a comment to D35651: [ELF] Align the value if needed when computing the expression.

Added a test case, which revealed another issue: while trying PROVIDE_HIDDEN(newsym = ALIGN(_end, CONSTANT(MAXPAGESIZE)) + 5);, I noticed it was working fine in our project but not in LLD. Turned the problem is that we also use a linker script which defines PROVIDE_HIDDEN(_end = .). However, when using only input linker script, this breaks because LLD only finalizes the _end value in fixPredefinedSymbols after all symbol assignment commands have been processed, so newsym will get a wrong value. This change still fixes the case when script is being used.

Wed, Jul 19, 11:43 PM · lld
phosek updated the summary of D35651: [ELF] Align the value if needed when computing the expression.
Wed, Jul 19, 11:43 PM · lld
phosek updated the diff for D35651: [ELF] Align the value if needed when computing the expression.
Wed, Jul 19, 11:43 PM · lld
grimar added a comment to D35651: [ELF] Align the value if needed when computing the expression.

Testcase ? :)

Wed, Jul 19, 11:02 PM · lld
phosek added a comment to D35651: [ELF] Align the value if needed when computing the expression.
In D35651#815595, @ruiu wrote:

I think what you were looking for is ExprValue::getValue().

Wed, Jul 19, 8:59 PM · lld
ruiu added a comment to D35651: [ELF] Align the value if needed when computing the expression.

I think what you were looking for is ExprValue::getValue().

Wed, Jul 19, 8:18 PM · lld
phosek created D35651: [ELF] Align the value if needed when computing the expression.
Wed, Jul 19, 4:23 PM · lld

Tue, Jul 18

ikudrin created D35537: [ELF] Avoid data race in ObjectFile<ELFT>::getDILineInfo()..
Tue, Jul 18, 3:06 AM · lld

Mon, Jul 17

ncharlie added a comment to D33513: [ThinLTO] Fix ThinLTO crash while destroying context.

@dexonsmith @pcc any updates on this?

Mon, Jul 17, 6:15 AM · lld

Fri, Jul 14

ltr_ added a reviewer for D35387: [MACH-O] Fix the ASM code generated for __stub_helpers section: lhames.
Fri, Jul 14, 8:21 AM · lld
ikudrin closed D34232: [ELF] Fix writing the content of the .got section in a wrong place. by committing rL308003: [ELF] Fix writing the content of the .got section in a wrong place..
Fri, Jul 14, 1:11 AM · lld

Thu, Jul 13

ltr_ updated the summary of D35387: [MACH-O] Fix the ASM code generated for __stub_helpers section.
Thu, Jul 13, 3:07 PM · lld
ltr_ retitled D35387: [MACH-O] Fix the ASM code generated for __stub_helpers section from Fix the ASM code generated for __stub_helpers section to [MACH-O] Fix the ASM code generated for __stub_helpers section.
Thu, Jul 13, 3:06 PM · lld
ltr_ created D35387: [MACH-O] Fix the ASM code generated for __stub_helpers section.
Thu, Jul 13, 3:06 PM · lld

Wed, Jul 12

ltr_ added a member for lld: ltr_.
Wed, Jul 12, 2:47 PM

Tue, Jul 11

ruiu accepted D34232: [ELF] Fix writing the content of the .got section in a wrong place..

LGTM

Tue, Jul 11, 7:15 PM · lld

Thu, Jul 6

atanasyan updated the diff for D31528: [ELF][MIPS] Multi-GOT implementation.

Rebased against the trunk.

Thu, Jul 6, 10:11 PM · lld

Wed, Jul 5

dlj added a comment to D34853: Fix (benignly) incorrect GoogleTest specs in various lit configs..

Hi,

I believe that this "build mode" is intended for the Visual Studio MSVC build. This build is special in that it can produce builds for multiple configurations, e.g. Debug, Release & RelWithDebInfo, within the same top level build output directory. It is this configuration type that defines the "build mode". This means that the unit tests will only pick up the configuration that matches that of the lit that was run. Without the "build mode" I believe lit might end up running all configurations of unit tests that have been built, which is probably not the intended behaviour.

Cheers,
Andrew

Wed, Jul 5, 9:37 PM · Restricted Project, lld

Tue, Jul 4

andrewng added a comment to D34853: Fix (benignly) incorrect GoogleTest specs in various lit configs..

I believe that this "build mode" is intended for the Visual Studio MSVC build. This build is special in that it can produce builds for multiple configurations, e.g. Debug, Release & RelWithDebInfo, within the same top level build output directory. It is this configuration type that defines the "build mode". This means that the unit tests will only pick up the configuration that matches that of the lit that was run. Without the "build mode" I believe lit might end up running all configurations of unit tests that have been built, which is probably not the intended behaviour.

Tue, Jul 4, 12:35 AM · Restricted Project, lld

Mon, Jul 3

phosek closed D34800: [ELF] Remove unused synthetic sections from script commands by committing rL307037: [ELF] Remove unused synthetic sections from script commands.
Mon, Jul 3, 8:50 AM · lld

Thu, Jun 29

dlj created D34853: Fix (benignly) incorrect GoogleTest specs in various lit configs..
Thu, Jun 29, 5:52 PM · Restricted Project, lld
ruiu added a reviewer for D34800: [ELF] Remove unused synthetic sections from script commands: rafael.
Thu, Jun 29, 11:13 AM · lld

Wed, Jun 28

phosek created D34800: [ELF] Remove unused synthetic sections from script commands.
Wed, Jun 28, 6:35 PM · lld

Mon, Jun 26

ikudrin added inline comments to D34612: [ELF] Do not add a .tbss section into a PT_LOAD segment in case of using a linker script..
Mon, Jun 26, 8:52 PM · lld
ruiu added inline comments to D33630: [ELF] Fill the empty space in executable segments with instruction padding.
Mon, Jun 26, 9:21 AM · lld
ruiu added inline comments to D34612: [ELF] Do not add a .tbss section into a PT_LOAD segment in case of using a linker script..
Mon, Jun 26, 7:08 AM · lld
ikudrin created D34612: [ELF] Do not add a .tbss section into a PT_LOAD segment in case of using a linker script..
Mon, Jun 26, 3:27 AM · lld

Fri, Jun 23

evgeny777 added a comment to D34554: [ELF] FIx use-after-return of archive path .

Test case?

Fri, Jun 23, 9:28 AM · lld
ruiu added a comment to D34554: [ELF] FIx use-after-return of archive path .

I think a better approach would be to change the type of ArchiveName from StringRef to std::string. This patch may fix the issue, but I'm not 100% sure because it fixes only one path that can reach addFile function. There might be some other places at which we pass on-stack objects to the function.

Fri, Jun 23, 8:21 AM · lld
meadori added a comment to D34554: [ELF] FIx use-after-return of archive path .

Test case?

Fri, Jun 23, 8:10 AM · lld
evgeny777 created D34554: [ELF] FIx use-after-return of archive path .
Fri, Jun 23, 6:05 AM · lld

Thu, Jun 22

evgeny777 added a reviewer for D34459: [ELF] Better handling of _GLOBAL_OFFSET_TABLE_: davide.
Thu, Jun 22, 4:08 AM · lld
evgeny777 updated the diff for D34459: [ELF] Better handling of _GLOBAL_OFFSET_TABLE_.

Updated with a comment requested by @ruiu

Thu, Jun 22, 4:07 AM · lld
evgeny777 added a comment to D34459: [ELF] Better handling of _GLOBAL_OFFSET_TABLE_.

Does it help to set visibility to hidden?

Thu, Jun 22, 4:05 AM · lld
phosek added inline comments to D33630: [ELF] Fill the empty space in executable segments with instruction padding.
Thu, Jun 22, 12:15 AM · lld
phosek updated the diff for D33630: [ELF] Fill the empty space in executable segments with instruction padding.
Thu, Jun 22, 12:14 AM · lld

Wed, Jun 21

ikudrin closed D34442: [ELF] Add an apostrophe after a file name when reporting discarded sections. by committing rL305983: [ELF] Add an apostrophe after a file name when reporting discarded sections..
Wed, Jun 21, 9:08 PM · lld
ikudrin added a comment to D34232: [ELF] Fix writing the content of the .got section in a wrong place..

As far as I could check, other sections are not affected by the similar problem. Most of them don't call relocate*() methods. InputSection::writeTo uses unshifted Buf when calling relocate(). And EhInputSection avoids the problem because SectionBase::getOffset() doesn't add OutSecOff for them.

Wed, Jun 21, 8:55 PM · lld
ruiu added inline comments to D33630: [ELF] Fill the empty space in executable segments with instruction padding.
Wed, Jun 21, 2:30 PM · lld
phosek added inline comments to D33630: [ELF] Fill the empty space in executable segments with instruction padding.
Wed, Jun 21, 1:10 PM · lld
phosek updated the diff for D33630: [ELF] Fill the empty space in executable segments with instruction padding.
Wed, Jun 21, 1:10 PM · lld