Page MenuHomePhabricator

lldProject
ActivePublic

Watchers

  • This project does not have any watchers.

Details

Description

LLVM Linker

Recent Activity

Mon, Aug 19

sidneym closed D66260: [lld][Hexagon] Add GOTREL relocations.
Mon, Aug 19, 6:32 AM · Restricted Project, lld
ruiu added inline comments to D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive .
Mon, Aug 19, 4:39 AM · Restricted Project, lld
MaskRay closed D39324: [lld] Support TLS in RISC-V.
Mon, Aug 19, 2:57 AM · lld
ruiu added a comment to D39324: [lld] Support TLS in RISC-V.

This has been merged on July 2 as http://reviews.llvm.org/rL364813

Mon, Aug 19, 2:48 AM · lld
ruiu added a comment to D66105: Support HEX_32 when building shared objects.

LGTM

Mon, Aug 19, 1:06 AM · Restricted Project, lld

Sun, Aug 18

ruiu accepted D66260: [lld][Hexagon] Add GOTREL relocations.

LGTM

Sun, Aug 18, 11:43 PM · Restricted Project, lld

Fri, Aug 16

MaskRay accepted D66260: [lld][Hexagon] Add GOTREL relocations.
Fri, Aug 16, 6:54 PM · Restricted Project, lld
sidneym closed D66105: Support HEX_32 when building shared objects.
Fri, Aug 16, 8:35 AM · Restricted Project, lld

Thu, Aug 15

sidneym added a comment to D66260: [lld][Hexagon] Add GOTREL relocations.

Where can we find a psABI describing these relocation types?

Thu, Aug 15, 8:03 AM · Restricted Project, lld
sidneym updated the diff for D66260: [lld][Hexagon] Add GOTREL relocations.

Update filenames in testcase.

Thu, Aug 15, 7:16 AM · Restricted Project, lld
MaskRay closed D39323: [lld] Support dynamic linking in RISC-V.

Am I correct in thinking that this functionality has already been upstreamed into LLD, and that this patch can now been abandoned?

Thu, Aug 15, 3:14 AM · Restricted Project, lld
lenary added a comment to D39323: [lld] Support dynamic linking in RISC-V.

Am I correct in thinking that this functionality has already been upstreamed into LLD, and that this patch can now been abandoned?

Thu, Aug 15, 2:52 AM · Restricted Project, lld
lenary added a comment to D39324: [lld] Support TLS in RISC-V.

Am I correct in thinking that this functionality has already been upstreamed into LLD, and that this patch can now been abandoned?

Thu, Aug 15, 2:52 AM · lld

Wed, Aug 14

MaskRay added inline comments to D66260: [lld][Hexagon] Add GOTREL relocations.
Wed, Aug 14, 11:04 PM · Restricted Project, lld
MaskRay added a reviewer for D66260: [lld][Hexagon] Add GOTREL relocations: MaskRay.
Wed, Aug 14, 9:16 PM · Restricted Project, lld
MaskRay added a comment to D66260: [lld][Hexagon] Add GOTREL relocations.

Where can we find a psABI describing these relocation types?

Wed, Aug 14, 9:16 PM · Restricted Project, lld
sidneym created D66260: [lld][Hexagon] Add GOTREL relocations.
Wed, Aug 14, 4:16 PM · Restricted Project, lld
zero9178 added a reviewer for D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive : pcc.
Wed, Aug 14, 2:01 PM · Restricted Project, lld
zero9178 updated the diff for D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive .

Fixed test to show regression and verify output

Wed, Aug 14, 1:15 PM · Restricted Project, lld
zero9178 edited projects for D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive , added: lld; removed Restricted Project.
Wed, Aug 14, 12:38 PM · Restricted Project, lld
bcain accepted D66105: Support HEX_32 when building shared objects.
Wed, Aug 14, 7:00 AM · Restricted Project, lld

Tue, Aug 13

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

Folks, I would like to ask a question related to this review and DWARF standard:

Tue, Aug 13, 8:37 AM · lld, Restricted Project

Mon, Aug 12

sidneym added a reviewer for D66105: Support HEX_32 when building shared objects: shankare.
Mon, Aug 12, 12:45 PM · Restricted Project, lld
sidneym created D66105: Support HEX_32 when building shared objects.
Mon, Aug 12, 12:41 PM · Restricted Project, lld

Fri, Aug 9

ikudrin closed D65875: [ELF] For VS-style diagnostics, prefer using the full path..
Fri, Aug 9, 1:28 AM · Restricted Project, lld
ruiu accepted D65875: [ELF] For VS-style diagnostics, prefer using the full path..

I confirmed that these tests are not affected by the actual path on a machine running the tests. I missed the part that you added .line directive in this patch. Thank you for doing this.

Fri, Aug 9, 12:25 AM · Restricted Project, lld

Thu, Aug 8

ikudrin added a comment to D65875: [ELF] For VS-style diagnostics, prefer using the full path..

Well, I have checked the patch on Windows. All tests pass.

Thu, Aug 8, 6:31 AM · Restricted Project, lld
ikudrin added a comment to D65875: [ELF] For VS-style diagnostics, prefer using the full path..

We had that issue with D65810 (rL368153), windows build bots complained about different path separators. That was fixed in rL368169. Thus, I made similar adjustments in this patch.

Thu, Aug 8, 3:39 AM · Restricted Project, lld
ruiu added a comment to D65875: [ELF] For VS-style diagnostics, prefer using the full path..

Generally looking good, but do these tests pass on Windows on which a path separator is \? It seems like you hardcoded / as a path separator in the tests.

Thu, Aug 8, 2:58 AM · Restricted Project, lld

Wed, Aug 7

ikudrin created D65875: [ELF] For VS-style diagnostics, prefer using the full path..
Wed, Aug 7, 7:53 AM · Restricted Project, lld
ikudrin closed D65810: [ELF] Fix splitting messages for duplicate symbols..
Wed, Aug 7, 4:33 AM · Restricted Project, lld
MaskRay accepted D65810: [ELF] Fix splitting messages for duplicate symbols..
Wed, Aug 7, 3:09 AM · Restricted Project, lld
ruiu accepted D65810: [ELF] Fix splitting messages for duplicate symbols..

LGTM

Wed, Aug 7, 2:12 AM · Restricted Project, lld

Tue, Aug 6

ikudrin updated the diff for D65810: [ELF] Fix splitting messages for duplicate symbols..
  • Removed Inputs/vs-diagnostics-duplicate-split.s
  • Updated the test accordingly.
Tue, Aug 6, 11:56 PM · Restricted Project, lld
MaskRay added inline comments to D65810: [ELF] Fix splitting messages for duplicate symbols..
Tue, Aug 6, 9:55 PM · Restricted Project, lld
ikudrin created D65810: [ELF] Fix splitting messages for duplicate symbols..
Tue, Aug 6, 8:36 AM · Restricted Project, lld
ikudrin closed D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5).
Tue, Aug 6, 6:36 AM · Restricted Project, lld

Fri, Aug 2

ruiu accepted D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5).

LGTM

Fri, Aug 2, 2:36 AM · Restricted Project, lld
ikudrin added a child revision for D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5): D65641: Remove support for 32-bit offsets in utility classes (5/5).
Fri, Aug 2, 2:15 AM · Restricted Project, lld
ikudrin added a parent revision for D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5): D65638: Switch LLVM to use 64-bit offsets (2/5).
Fri, Aug 2, 2:07 AM · Restricted Project, lld
ikudrin created D65639: [MachO] Update LLD to use 64-bit offsets with DataExtractor (3/5).
Fri, Aug 2, 2:07 AM · Restricted Project, lld

Wed, Jul 31

ikudrin closed D65499: [ELF] Fix finding the location in messages for undefined hidden symbols..
Wed, Jul 31, 10:24 PM · lld, Restricted Project
ruiu accepted D65499: [ELF] Fix finding the location in messages for undefined hidden symbols..

LGTM

Wed, Jul 31, 6:23 PM · lld, Restricted Project
ikudrin updated the diff for D65499: [ELF] Fix finding the location in messages for undefined hidden symbols..
  • Combined all the suggestions to improve the regular expression.
  • Addressed @MaskRay's comments for the test.
Wed, Jul 31, 2:10 AM · lld, Restricted Project

Jul 25 2019

ihalip abandoned D63564: Add undefined symbols from linker script to output file.

Abandoning this, it's obvious it wasn't the right fix anyway.

Jul 25 2019, 11:12 PM · Restricted Project, lld

Jul 11 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

Thank you, I apologize for impatience.

Jul 11 2019, 2:32 PM · lld, Restricted Project
echristo added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

I am following, I've just been out for 3 weeks. I'm catching up now and this is in my queue.

Jul 11 2019, 2:22 PM · lld, Restricted Project
avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

I'm fine with this patch. We've discussed a lot about what is a desirable value for a "null" for debug info, but looks like as long as it does not appear as a valid address, it should be fine.

Is Eric fine with this?

Jul 11 2019, 2:17 PM · lld, Restricted Project

Jul 8 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.
Jul 8 2019, 8:06 AM · lld, Restricted Project

Jul 5 2019

MaskRay added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

Issues I noticed, some of which are possibly bugs, but it's hard to tell:

  • llvm-symbolizer reports the line number corresponding to the removed foo for the fourth case.
  • GNU addr2line line numbers are wrong in the first three cases, and foo is reported in the fourth.
  • GNU addr2line thinks foo is the right symbol for the fourth case, even though it has been removed. llvm-symbolizer just prints '??' (that's probably correct).

    I haven't checked to see how many of these issues are fixed by D60470.
Jul 5 2019, 6:50 AM · lld, Restricted Project