[lldb] Remove scoped timer from high firing and fast running SymbolFileDWARF::FindFunctions

[kastiglione]

Summary

Profiles show that SymbolFileDWARF::FindFunctions is both high firing (many thousands of calls) and fast running (35 µs mean).

Timers like this are noise and load for profiling systems, and can be removed.

rdar://100326595

[aprantl]

Probably because it just queries m_index.

Thanks!

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

 
 void SymbolFileDWARF::FindFunctions(const Module::LookupInfo &lookup_info,
                                     const CompilerDeclContext &parent_decl_ctx,
                                     bool include_inlines,
                                     SymbolContextList &sc_list) {
   std::lock_guard<std::recursive_mutex> guard(GetModuleMutex());
   ConstString name = lookup_info.GetLookupName();
   FunctionNameType name_type_mask = lookup_info.GetNameTypeMask();
-  LLDB_SCOPED_TIMERF("SymbolFileDWARF::FindFunctions (name = '%s')",
-                     name.AsCString());
 
   // eFunctionNameTypeAuto should be pre-resolved by a call to
   // Module::LookupInfo::LookupInfo()
   assert((name_type_mask & eFunctionNameTypeAuto) == 0);
 
   Log *log = GetLog(DWARFLog::Lookups);
 
   if (log) {