This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Update `mad-mix*` CodeGen tests
ClosedPublic

Authored by Pierre-vh on Sep 27 2022, 11:50 PM.

Details

Summary
  • Use fneg %a instead of fsub -0.0, %a
    • This is for D134354 as we don't currently support folding fsub -0.0, %a into fneg on GISel. Also, fneg is the canonical way to do the negation.
  • Switch to update_llc_test_checks-generated tests.
    • Better test coverage
    • Easier to update
    • Easier to see changes in future diffs
  • Remove unnecessary CL arguments in RUN lines

Motive for the patch: Preparation for D134354 - we would like to
put GISel tests in this file as well. Fixing the lack of fneg and
switching to generated testing makes it much easier.

Diff Detail

Event Timeline

Pierre-vh created this revision.Sep 27 2022, 11:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 27 2022, 11:50 PM
Pierre-vh requested review of this revision.Sep 27 2022, 11:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 27 2022, 11:50 PM
arsenm accepted this revision.Sep 28 2022, 8:45 AM
This revision is now accepted and ready to land.Sep 28 2022, 8:45 AM
This revision was automatically updated to reflect the committed changes.