Page MenuHomePhabricator

[utils][UpdateTestChecks] Add unnamed !noundef value support
AcceptedPublic

Authored by jmciver on Sep 21 2022, 10:18 PM.

Details

Summary

Add unnamed !noundef value support to Python module
UpdateTestChecks.common. This allows utilities such as update_cc_test_checks.py
to generated automatic tags for IR with unnamed !noundef metadata.

Diff Detail

Event Timeline

jmciver created this revision.Sep 21 2022, 10:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2022, 10:18 PM
Herald added a subscriber: luismarques. · View Herald Transcript
jmciver requested review of this revision.Sep 21 2022, 10:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2022, 10:18 PM

It looks like there was some issue with the Harbormaster build when you initially submitted this patch, but it seems to have been resolved since then. Can you rerun it?

Reran Harbormaster build; it is now passing.

jdoerfert accepted this revision.Sep 26 2022, 10:50 PM

Please add a test though, or add !noundef to an existing test.

This revision is now accepted and ready to land.Sep 26 2022, 10:50 PM

Thanks @jdoerfert for the feedback! Let me see what I can add in the way of tests independently of D134410.