This is an archive of the discontinued LLVM Phabricator instance.

[utils][UpdateTestChecks] Add unnamed !noundef value support
AcceptedPublic

Authored by jmciver on Sep 21 2022, 10:18 PM.

Download Raw Diff

Details

Reviewers

arichardson
kovdan01
jdoerfert
psoni2628

Summary

Add unnamed !noundef value support to Python module
UpdateTestChecks.common. This allows utilities such as update_cc_test_checks.py
to generated automatic tags for IR with unnamed !noundef metadata.

Diff Detail

Event Timeline

jmciver created this revision.Sep 21 2022, 10:18 PM

Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2022, 10:18 PM

Herald added a subscriber: luismarques. · View Herald Transcript

jmciver requested review of this revision.Sep 21 2022, 10:18 PM

Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2022, 10:18 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B188102: Diff 462080.Sep 21 2022, 10:19 PM

jmciver added a child revision: D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 5).Sep 21 2022, 11:31 PM

It looks like there was some issue with the Harbormaster build when you initially submitted this patch, but it seems to have been resolved since then. Can you rerun it?

Reran Harbormaster build; it is now passing.

Please add a test though, or add !noundef to an existing test.

This revision is now accepted and ready to land.Sep 26 2022, 10:50 PM

Thanks @jdoerfert for the feedback! Let me see what I can add in the way of tests independently of D134410.

Revision Contents

Path

Size

llvm/

utils/

UpdateTestChecks/

common.py

1 line

Diff 462080

llvm/utils/UpdateTestChecks/common.py

	Show First 20 Lines • Show All 733 Lines • ▼ Show 20 Lines
	# (local) ssa values, (debug) metadata, etc.			# (local) ssa values, (debug) metadata, etc.
	ir_nameless_values = [			ir_nameless_values = [
	NamelessValue(r'TMP' , '%' , r'%' , None , None , r'[\w$.-]+?' , None , False) ,			NamelessValue(r'TMP' , '%' , r'%' , None , None , r'[\w$.-]+?' , None , False) ,
	NamelessValue(r'ATTR' , '#' , r'#' , None , None , r'[0-9]+' , None , False) ,			NamelessValue(r'ATTR' , '#' , r'#' , None , None , r'[0-9]+' , None , False) ,
	NamelessValue(r'ATTR' , '#' , None , r'attributes #' , r'[0-9]+' , None , r'{[^}]*}' , False) ,			NamelessValue(r'ATTR' , '#' , None , r'attributes #' , r'[0-9]+' , None , r'{[^}]*}' , False) ,
	NamelessValue(r'GLOB' , '@' , r'@' , None , None , r'[0-9]+' , None , False) ,			NamelessValue(r'GLOB' , '@' , r'@' , None , None , r'[0-9]+' , None , False) ,
	NamelessValue(r'GLOB' , '@' , None , r'@' , r'[a-zA-Z0-9_$"\\.-]+' , None , r'.+' , True) ,			NamelessValue(r'GLOB' , '@' , None , r'@' , r'[a-zA-Z0-9_$"\\.-]+' , None , r'.+' , True) ,
	NamelessValue(r'DBG' , '!' , r'!dbg ' , None , None , r'![0-9]+' , None , False) ,			NamelessValue(r'DBG' , '!' , r'!dbg ' , None , None , r'![0-9]+' , None , False) ,
				NamelessValue(r'NOUNDEF' , '!' , r'!noundef ' , None , None , r'![0-9]+' , None , False) ,
	NamelessValue(r'PROF' , '!' , r'!prof ' , None , None , r'![0-9]+' , None , False) ,			NamelessValue(r'PROF' , '!' , r'!prof ' , None , None , r'![0-9]+' , None , False) ,
	NamelessValue(r'TBAA' , '!' , r'!tbaa ' , None , None , r'![0-9]+' , None , False) ,			NamelessValue(r'TBAA' , '!' , r'!tbaa ' , None , None , r'![0-9]+' , None , False) ,
	NamelessValue(r'RNG' , '!' , r'!range ' , None , None , r'![0-9]+' , None , False) ,			NamelessValue(r'RNG' , '!' , r'!range ' , None , None , r'![0-9]+' , None , False) ,
	NamelessValue(r'LOOP' , '!' , r'!llvm.loop ' , None , None , r'![0-9]+' , None , False) ,			NamelessValue(r'LOOP' , '!' , r'!llvm.loop ' , None , None , r'![0-9]+' , None , False) ,
	NamelessValue(r'META' , '!' , r'metadata ' , None , None , r'![0-9]+' , None , False) ,			NamelessValue(r'META' , '!' , r'metadata ' , None , None , r'![0-9]+' , None , False) ,
	NamelessValue(r'META' , '!' , None , r'' , r'![0-9]+' , None , r'(?:distinct \|)!.*' , False) ,			NamelessValue(r'META' , '!' , None , r'' , r'![0-9]+' , None , r'(?:distinct \|)!.*' , False) ,
	NamelessValue(r'ACC_GRP' , '!' , r'!llvm.access.group ' , None , None , r'![0-9]+' , None , False) ,			NamelessValue(r'ACC_GRP' , '!' , r'!llvm.access.group ' , None , None , r'![0-9]+' , None , False) ,
	]			]
	▲ Show 20 Lines • Show All 521 Lines • Show Last 20 Lines