Page MenuHomePhabricator

[TableGen] Add div bang operator
ClosedPublic

Authored by michaelmaitland on Sep 15 2022, 5:45 PM.

Details

Summary

This patch adds the div bang operator which performs division.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2022, 5:45 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
michaelmaitland requested review of this revision.Sep 15 2022, 5:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2022, 5:45 PM

Replace semicolon at end of file

craig.topper added inline comments.
llvm/docs/TableGen/ProgRef.rst
1626

clarify whether this is a signed or unsigned division?

llvm/lib/TableGen/Record.cpp
1192

INT64_MIN / -1 should also be an error.

craig.topper added inline comments.Sep 15 2022, 7:24 PM
llvm/lib/TableGen/Record.cpp
1190

Wrapping this in Twine is probably unnecessary

error for INT64_MIN / -1; clarify signed division; simplify errors

error for INT64_MIN / -1; clarify signed division; simplify errors

craig.topper added inline comments.Sep 21 2022, 6:21 PM
llvm/docs/TableGen/ProgRef.rst
1627

It's division of INT64_MIN by -1

Changed documentation string to division of INT64_MIN by -1.

This revision is now accepted and ready to land.Sep 30 2022, 9:50 AM
This revision was landed with ongoing or failed builds.Sep 30 2022, 12:09 PM
This revision was automatically updated to reflect the committed changes.