This is an archive of the discontinued LLVM Phabricator instance.

Change PowerPC64 bots to build runtimes with -DLLVM_ENABLE_RUNTIMES

Authored by kamaub on Sep 15 2022, 6:28 AM.



All of the powerpc 64-bit little and big endian buildbots build their
runtimes with -DLLVM_ENABLE_PROJECTS in the cmake command; this method
is deprecated.
This patch updates all of the ppc64 bots, except the sanitizer bot,
to build runtimes with -DLLVM_ENABLE_RUNTIMES and adds a check-runtimes
test step as check-all does not currently check runtimes.

Diff Detail

Event Timeline

kamaub created this revision.Sep 15 2022, 6:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2022, 6:28 AM
kamaub requested review of this revision.Sep 15 2022, 6:28 AM
amyk added inline comments.Sep 15 2022, 8:17 AM


Does enable_runtimes="auto" basically mean to do -DLLVM_ENABLE_RUNTIMES=compiler-rt? Is that why bots with these option on do not have the -DLLVM_ENABLE_RUNTIMES=compiler-rt CMake variable?

kamaub marked an inline comment as done.Sep 19 2022, 7:28 AM

Thanks for the review! :)


Yes, by adding "compiler-rt" in the depends_on_projects variable and setting enable_runtimes to "auto" we allow line$51 to run all runtimes in the depends_on_projects variable as -DLLVM_ENABLE_RUNTIMES

amyk accepted this revision.Sep 19 2022, 8:34 AM

Thanks for the patch and answering the question I had! I think all in all this LGTM.


Gotcha! Thanks for answering my question. :)

This revision is now accepted and ready to land.Sep 19 2022, 8:34 AM
lei added inline comments.Sep 26 2022, 7:56 AM

This seems not related to changing how we build compiler-rt. Is it intentional?

kamaub marked 3 inline comments as done.Oct 4 2022, 7:28 AM
kamaub added inline comments.

I was incorrectly trying to mirror the little endian bot, but we should keep a shared and non-shared library build, I have removed this pre-commit as requested.