Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Paths

Table of Contentst

Generate ENABLE_RUNTIMES in ClangBuilder
ClosedPublic
Actions

Authored by DavidSpickett on Feb 27 2023, 2:15 AM.

Details

Reviewers

gkistanova
kamaub

Commits

rZORGa6278185d8fd: Generate ENABLE_RUNTIMES in ClangBuilder

Summary

In ca793509f5a9b26395400dcb92b344b1e055e949 I passed down
enable_runtimes to ClangBuilder but did not realise that
it was not LLVMBuildFactory that generates the CMake arguments.

LLVMBuildFactory simply holds properties of the build. In this
case what projects and runtimes we rely on.

ClangBuilder is the one making the CMake arguments, so I've updated
that to emit the right options this time instead of putting everything
in PROJECTS.

I've adjusted two of the PPC bots that were manually putting compiler-rt
into RUNTIMES.

Diff Detail

Repository: rZORG LLVM Github Zorg

Event Timeline

DavidSpickett created this revision.Feb 27 2023, 2:15 AM

Herald added a reviewer: gkistanova. · View Herald TranscriptFeb 27 2023, 2:15 AM

Herald added a project: Restricted Project. · View Herald Transcript

DavidSpickett requested review of this revision.Feb 27 2023, 2:15 AM

Harbormaster completed remote builds in B216171: Diff 500713.Feb 27 2023, 2:15 AM

@kamaub for the PPC changes. Originally done in https://reviews.llvm.org/D133940.

I probably need to add check-runtimes to Linaro's bot also, but I'll deal with that later.

The patch looks good in general.

One thing does not look right, though.

buildbot/osuosl/master/config/builders.py
691	`LLVMBuildFactory` expects a list of runtimes, or one of the special values: `None` (for default behavior whatever it is), `"auto"`, or `"all"`. `True` is not one of them. Did you mean `"auto"` here?

This revision now requires changes to proceed.Feb 28 2023, 10:29 AM

Correct =True to ="auto" for enable_runtimes.

Harbormaster completed remote builds in B216660: Diff 501414.Mar 1 2023, 1:10 AM

DavidSpickett marked an inline comment as done.Mar 1 2023, 1:10 AM

DavidSpickett added inline comments.

buildbot/osuosl/master/config/builders.py
691	I did, fixed.

LGTM.

This revision is now accepted and ready to land.Mar 1 2023, 10:34 AM

@kamaub Any comments?

If there's no response by tomorrow I'm going to land this and test it on staging. If it works there on the AArch64 bot I doubt there will be an issue with ppc, the configurations are very similar architecture aside.

Closed by commit rZORGa6278185d8fd: Generate ENABLE_RUNTIMES in ClangBuilder (authored by DavidSpickett). · Explain WhyMar 9 2023, 1:24 AM

This revision was automatically updated to reflect the committed changes.

DavidSpickett added a commit: rZORGa6278185d8fd: Generate ENABLE_RUNTIMES in ClangBuilder.