Page MenuHomePhabricator
Differential D133904

[mlir] Add gpu.memzero operation
AcceptedPublic
Actions

Authored by ezhulenev on Sep 14 2022, 3:47 PM.

Details

Reviewers
bondhugula
ThomasRaoux
herhut
nicolasvasilache

Diff Detail

Event Timeline

ezhulenev created this revision.Sep 14 2022, 3:47 PM
Herald added a reviewer: bondhugula. · View Herald TranscriptSep 14 2022, 3:47 PM
Herald added a reviewer: ThomasRaoux. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 19 others. · View Herald Transcript
ezhulenev requested review of this revision.Sep 14 2022, 3:47 PM
Herald added a reviewer: herhut. · View Herald TranscriptSep 14 2022, 3:47 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
ezhulenev edited the summary of this revision. (Show Details)Sep 14 2022, 3:50 PM
Harbormaster completed remote builds in B186746: Diff 460255.Sep 14 2022, 4:07 PM
herhut accepted this revision.Sep 15 2022, 7:02 AM
This revision is now accepted and ready to land.Sep 15 2022, 7:02 AM
bondhugula accepted this revision.Mar 23 2023, 5:38 AM

LGTM.

Do you plan to add a lowering via CUDA memset? If not, this could be a useful starter issue to list on LLVM Github issues.

mlir/test/Dialect/GPU/ops.mlir
261

Nit: Indent CHECK-LABEL on par with the line above.

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 23 2023, 5:38 AM
Herald added subscribers: Moerafaat, zero9178, thopre. · View Herald Transcript

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
GPU/
IR/
32 lines
lib/
Dialect/
GPU/
IR/
5 lines
test/
Dialect/
GPU/
9 lines
11 lines

Diff 460255

View Options

mlir/include/mlir/Dialect/GPU/IR/GPUOps.td

Loading...
View Options

mlir/lib/Dialect/GPU/IR/GPUDialect.cpp

Loading...
View Options

mlir/test/Dialect/GPU/canonicalize.mlir

Loading...
View Options

mlir/test/Dialect/GPU/ops.mlir

Loading...