[mlir] Allow `Attribute::print` to elide the type

[Mogball]

Summary

This patch adds a flag to Attribute::print that prints the attribute
without its type.

Fixes #57689

[lattner]

nice, thank you Jeff!

[rriddle]

mlir/include/mlir/IR/Attributes.h

80

I'd use a default for this as well.

[Mogball]

add default

[mehdi_amini]

Can yo

mlir/include/mlir/IR/Attributes.h

80

This should be documented IMO: it's not clear to me what it does or what the implications are: please include hints about when to use this in the doc (can I parse the attribute back? )

It does not help that not having test makes this basically dead code in the codebase right now

[Mogball]

In D133822#3813420, @mehdi_amini wrote:

Can yo

?

I updated the doc

mlir/include/mlir/IR/Attributes.h

public:
   MLIRContext *getContext() const;
 
   /// Get the dialect this attribute is registered to.
   Dialect &getDialect() const {
     return impl->getAbstractAttribute().getDialect();
   }
 
   /// Print the attribute.
-  void print(raw_ostream &os) const;
-  void print(raw_ostream &os, AsmState &state) const;
+  void print(raw_ostream &os, bool elideType = false) const;
+  void print(raw_ostream &os, AsmState &state, bool elideType = false) const;
   void dump() const;
 
   /// Get an opaque pointer to the attribute.
   const void *getAsOpaquePointer() const { return impl; }
   /// Construct an attribute from the opaque pointer representation.
   static Attribute getFromOpaquePointer(const void *ptr) {
     return Attribute(reinterpret_cast<const ImplType *>(ptr));
   }

mlir/lib/IR/AsmPrinter.cpp

void OperationPrinter::printAffineExprOfSSAIds(AffineExpr expr,
   };
   printAffineExpr(expr, printValueName);
 }
 
 //===----------------------------------------------------------------------===//
 // print and dump methods
 //===----------------------------------------------------------------------===//
 
-void Attribute::print(raw_ostream &os) const {
+void Attribute::print(raw_ostream &os, bool elideType) const {
   if (!*this) {
     os << "<<NULL ATTRIBUTE>>";
     return;
   }
 
   AsmState state(getContext());
-  print(os, state);
+  print(os, state, elideType);
 }
-void Attribute::print(raw_ostream &os, AsmState &state) const {
-  AsmPrinter::Impl(os, state.getImpl()).printAttribute(*this);
+void Attribute::print(raw_ostream &os, AsmState &state, bool elideType) const {
+  using AttrTypeElision = AsmPrinter::Impl::AttrTypeElision;
+  AsmPrinter::Impl(os, state.getImpl())
+      .printAttribute(*this, elideType ? AttrTypeElision::Must
+                                       : AttrTypeElision::Never);
 }
 
 void Attribute::dump() const {
   print(llvm::errs());
   llvm::errs() << "\n";
 }
 
 void Type::print(raw_ostream &os) const {