This is an archive of the discontinued LLVM Phabricator instance.

[GlobalISel][Legalizer] Fix minScalarEltSameAsIf to handle p0 element types.
ClosedPublic

Authored by aemerson on Sep 11 2022, 8:31 AM.

Details

Summary

The mutation the action generates tries to change the input type into the element type of larger vector type. This doesn't work if the larger element type is a vector of pointers since it creates an illegal mutation between scalar and pointer types.

Diff Detail

Event Timeline

aemerson created this revision.Sep 11 2022, 8:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 11 2022, 8:31 AM
Herald added a subscriber: rovka. · View Herald Transcript
aemerson requested review of this revision.Sep 11 2022, 8:31 AM
aemerson edited the summary of this revision. (Show Details)Sep 11 2022, 8:34 AM
arsenm accepted this revision.Sep 12 2022, 5:53 AM
arsenm added inline comments.
llvm/unittests/CodeGen/GlobalISel/LegalizerInfoTest.cpp
441

Also add a test with a non-0 address space

This revision is now accepted and ready to land.Sep 12 2022, 5:53 AM