This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC][NFC] Add test case to show CSR_64_AllRegs_AIX_Dflt_VSX is not correct
Changes PlannedPublic

Authored by tingwang on Sep 8 2022, 6:30 PM.

Details

Reviewers
lkail
ZarkoCA
Group Reviewers
Restricted Project
Summary

Add pre-commit test case for CSR_64_AllRegs_AIX_Dflt_VSX fix.

Diff Detail

Event Timeline

tingwang created this revision.Sep 8 2022, 6:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2022, 6:30 PM
tingwang requested review of this revision.Sep 8 2022, 6:30 PM
lkail added inline comments.Sep 8 2022, 6:45 PM
llvm/test/CodeGen/PowerPC/aix64-patchpoint-regmask.ll
8

Please use another function to replace @llvm.experimental.patchpoint.void, since we don't support JIT on AIX yet.

tingwang added inline comments.Sep 12 2022, 5:09 PM
llvm/test/CodeGen/PowerPC/aix64-patchpoint-regmask.ll
8

I did not find any other logic path that could trigger CSR_64_AllRegs_AIX_Dflt_VSX. If this is the only case, then I may have to just leave it here as the functionality is not supported yet.

amyk added a subscriber: amyk.Sep 14 2022, 9:40 PM
amyk added inline comments.
llvm/test/CodeGen/PowerPC/aix64-patchpoint-regmask.ll
1

Nit: I think this line maybe too long. Perhaps we can try separating this run line further.

4

Minor spelling typo.

tingwang added inline comments.Sep 15 2022, 12:58 AM
llvm/test/CodeGen/PowerPC/aix64-patchpoint-regmask.ll
1

Thank you Amy for looking into this. I'm afraid I have to suspend this patch since the functionality is not supported on AIX...

tingwang planned changes to this revision.Sep 15 2022, 1:34 AM

Suspend this patch since the functionality is not supported on AIX.