This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Change CombiningKind in Vector dialect to EnumAttr.
ClosedPublic

Authored by olegshyshkov on Sep 6 2022, 1:59 AM.

Details

Summary

CombiningKind was implemented before EnumAttr, so it reimplements the same behaviour with the custom code. Except for a few places, EnumAttr is a drop-in replacement.

Diff Detail

Event Timeline

olegshyshkov created this revision.Sep 6 2022, 1:59 AM
olegshyshkov requested review of this revision.Sep 6 2022, 1:59 AM
olegshyshkov edited reviewers, added: pifon2a; removed: aartbik, dcaballe.Sep 6 2022, 2:09 AM
pifon2a accepted this revision.Sep 6 2022, 2:20 AM

Nice, thank you for the clean-up!

This revision is now accepted and ready to land.Sep 6 2022, 2:20 AM

Update CMake files to fix the build.

Run clang-format.

This revision was automatically updated to reflect the committed changes.