Page MenuHomePhabricator

[cmake] do not set execution permission to regular files
ClosedPublic

Authored by sinan on Sep 5 2022, 8:11 AM.

Details

Summary

some regular files(e.g. files that have no shebang and no execute bit in source dir) are wrongly assigned execution permission through cmake install, such as scanview.css and ear.c from libscanbuild, which is unnecessary and introduces warnings in some platforms:

install(PROGRAMS ...) is identical to the install(FILES ...) except that the default permissions for the installed file also include OWNER_EXECUTE, GROUP_EXECUTE, and WORLD_EXECUTE. (https://cmake.org/cmake/help/latest/command/install.html#installing-files)

Diff Detail

Event Timeline

sinan created this revision.Sep 5 2022, 8:11 AM
Herald added a project: Restricted Project. · View Herald Transcript
sinan requested review of this revision.Sep 5 2022, 8:11 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptSep 5 2022, 8:11 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MaskRay accepted this revision.Sep 5 2022, 2:23 PM
This revision is now accepted and ready to land.Sep 5 2022, 2:23 PM
phosek accepted this revision.Sep 5 2022, 7:09 PM

LGTM