This is an archive of the discontinued LLVM Phabricator instance.

[mlir][spirv] Define various spv.GroupNonUniformShuffle ops
ClosedPublic

Authored by antiagainst on Aug 31 2022, 12:12 PM.

Diff Detail

Event Timeline

antiagainst created this revision.Aug 31 2022, 12:12 PM
antiagainst requested review of this revision.Aug 31 2022, 12:12 PM

Fix examples

kuhar accepted this revision.Sep 1 2022, 12:48 PM

LGTM

mlir/include/mlir/Dialect/SPIRV/IR/SPIRVNonUniformOps.td
676

nit: there seem to be some duplicated spaces in this description. Also below, e.g., between Id and must.

This revision is now accepted and ready to land.Sep 1 2022, 12:48 PM
antiagainst marked an inline comment as done.Sep 2 2022, 2:08 PM
antiagainst added inline comments.
mlir/include/mlir/Dialect/SPIRV/IR/SPIRVNonUniformOps.td
676

These are automatically pulled from the HTML spec; so we need to fix the generator for it. I won't bother for now.

This revision was landed with ongoing or failed builds.Sep 2 2022, 2:13 PM
This revision was automatically updated to reflect the committed changes.
antiagainst marked an inline comment as done.