This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Avoid crash when printing call to string literal operator template in hover
ClosedPublic

Authored by nridge on Aug 29 2022, 1:20 AM.

Diff Detail

Event Timeline

nridge created this revision.Aug 29 2022, 1:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2022, 1:20 AM
Herald added a subscriber: arphaman. · View Herald Transcript
nridge requested review of this revision.Aug 29 2022, 1:20 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 29 2022, 1:20 AM

can you move the test into llvm/llvm-project/clang/unittests/AST/StmtPrinterTest.cpp ?

while there, also a test on pack-extended user defined literals would be nice.

nridge updated this revision to Diff 457891.Sep 5 2022, 12:26 AM

Move test to StmtPrinterTests, add test for literal operator using pack

kadircet accepted this revision.Sep 5 2022, 12:37 AM

thanks!

This revision is now accepted and ready to land.Sep 5 2022, 12:37 AM
This revision was landed with ongoing or failed builds.Sep 5 2022, 12:42 AM
This revision was automatically updated to reflect the committed changes.