Currently the diagnostic is printed at the start of the assignment expression, This can be misleading.
Having the location for the diagnostic be the location of the assignment operator is much more intuitive.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang-tools-extra/clang-tidy/bugprone/AssignmentInIfConditionCheck.cpp | ||
---|---|---|
66–67 | Drive-by comment -- an Expr is not a Decl (feel free to defer to a separate patch). |
Drive-by comment -- an Expr is not a Decl (feel free to defer to a separate patch).