Page MenuHomePhabricator

dodohand (dodohand)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 3 2022, 11:13 AM (10 w, 3 d)

Recent Activity

Jul 5 2022

dodohand updated the diff for D127114: new clang-tidy checker for assignments within condition clause of if statement.

somehow, clang-format needed to be re-run.

Jul 5 2022, 10:58 AM · Restricted Project, Restricted Project
dodohand updated the diff for D127114: new clang-tidy checker for assignments within condition clause of if statement.

Updated to merge successfully into latest version of main branch

Jul 5 2022, 9:56 AM · Restricted Project, Restricted Project
dodohand added a comment to D127114: new clang-tidy checker for assignments within condition clause of if statement.

Hi @gribozavr2, I don't have commit access... I'll address the merge issue ASAP though.

Jul 5 2022, 9:45 AM · Restricted Project, Restricted Project
dodohand added a comment to D127114: new clang-tidy checker for assignments within condition clause of if statement.

Addressed comments from gribozavr2

Jul 5 2022, 9:44 AM · Restricted Project, Restricted Project
dodohand updated the diff for D127114: new clang-tidy checker for assignments within condition clause of if statement.

Addressing comments from @gribozavr2 identifying comments needing update/removal/improvement.

Jul 5 2022, 9:43 AM · Restricted Project, Restricted Project
dodohand added a comment to D127114: new clang-tidy checker for assignments within condition clause of if statement.

Hi @alexfh , @aaron.ballman, Could one of you have a look at this? I'd like to get it moving toward resolution and don't know who else ought to do a review...

Jul 5 2022, 9:25 AM · Restricted Project, Restricted Project

Jun 21 2022

dodohand added a comment to D127114: new clang-tidy checker for assignments within condition clause of if statement.

@gribozavr2 , have I successfully addressed the points you brought up?

Jun 21 2022, 5:49 AM · Restricted Project, Restricted Project

Jun 6 2022

dodohand updated the diff for D127114: new clang-tidy checker for assignments within condition clause of if statement.

renamed from misc-assignment-in-if-clause to bugprone-assignment-in-if-condition per review input

Jun 6 2022, 2:15 PM · Restricted Project, Restricted Project
dodohand added inline comments to D127114: new clang-tidy checker for assignments within condition clause of if statement.
Jun 6 2022, 8:54 AM · Restricted Project, Restricted Project
dodohand added inline comments to D127114: new clang-tidy checker for assignments within condition clause of if statement.
Jun 6 2022, 8:08 AM · Restricted Project, Restricted Project
dodohand updated the summary of D127114: new clang-tidy checker for assignments within condition clause of if statement.
Jun 6 2022, 7:41 AM · Restricted Project, Restricted Project
dodohand added a reviewer for D127114: new clang-tidy checker for assignments within condition clause of if statement: alexfh.
Jun 6 2022, 7:41 AM · Restricted Project, Restricted Project
dodohand requested review of D127114: new clang-tidy checker for assignments within condition clause of if statement.
Jun 6 2022, 7:39 AM · Restricted Project, Restricted Project