This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][DWARF] Fix for Handle zero size DW_TAG_inlined_subroutine
ClosedPublic

Authored by ayermolo on Aug 26 2022, 9:54 PM.

Details

Summary

Managed to introduce an error when changing code to fix other tests and the unit
test was no adequate due to --nostdlib being passed in in llvm testing
enviroment.
Original diff: https://reviews.llvm.org/D132059

Updated a test to make sure that original address and the new address are
different.

Diff Detail

Event Timeline

ayermolo created this revision.Aug 26 2022, 9:54 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
ayermolo requested review of this revision.Aug 26 2022, 9:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2022, 9:54 PM
ayermolo edited the summary of this revision. (Show Details)Aug 26 2022, 9:55 PM
ayermolo added a reviewer: Restricted Project.
ayermolo retitled this revision from [BOLT][DWARF][NFC] Fix for Handle zero size DW_TAG_inlined_subroutine to [BOLT][DWARF] Fix for Handle zero size DW_TAG_inlined_subroutine.Dec 13 2022, 3:39 PM
maksfb accepted this revision.Dec 13 2022, 3:39 PM

Remove "NFC" before commit.

bolt/lib/Rewrite/DWARFRewriter.cpp
467
This revision is now accepted and ready to land.Dec 13 2022, 3:39 PM
ayermolo updated this revision to Diff 482653.Dec 13 2022, 4:05 PM

rebase + address comments

ayermolo marked an inline comment as done.Dec 13 2022, 4:06 PM