This is an archive of the discontinued LLVM Phabricator instance.

Differential D132742

[X86][BF16] Add type mangling for Windows
ClosedPublic

Authored by pengfei on Aug 26 2022, 8:15 AM.

Details

Reviewers
FreddyYe
LuoYuanke
craig.topper
RKSimon
skan
Commits
rGa845d8fc57b6: [X86][BF16] Add type mangling for Windows

Diff Detail

Event Timeline

pengfei created this revision.Aug 26 2022, 8:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2022, 8:15 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
pengfei requested review of this revision.Aug 26 2022, 8:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2022, 8:15 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
pengfei mentioned this in D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics.Aug 26 2022, 8:25 AM
pengfei added a child revision: D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics.Aug 26 2022, 8:25 AM
Harbormaster completed remote builds in B183607: Diff 455913.Aug 26 2022, 9:09 AM
FreddyYe accepted this revision.Aug 29 2022, 12:16 AM

LGTM.

This revision is now accepted and ready to land.Aug 29 2022, 12:16 AM
Closed by commit rGa845d8fc57b6: [X86][BF16] Add type mangling for Windows (authored by pengfei). · Explain WhyAug 29 2022, 1:12 AM
This revision was automatically updated to reflect the committed changes.
pengfei added a commit: rGa845d8fc57b6: [X86][BF16] Add type mangling for Windows.
pengfei added a comment.Aug 29 2022, 1:13 AM

Thanks @FreddyYe

Revision Contents

PathSize
clang/
lib/
AST/
5 lines
test/
CodeGen/
X86/
9 lines

Diff 456276

clang/lib/AST/MicrosoftMangle.cpp

Show First 20 Lines • Show All 2,463 Lines • ▼ Show 20 Lines case BuiltinType::Half:
if (!getASTContext().getLangOpts().HLSL) if (!getASTContext().getLangOpts().HLSL)
mangleArtificialTagType(TTK_Struct, "_Half", {"__clang"}); mangleArtificialTagType(TTK_Struct, "_Half", {"__clang"});
else if (getASTContext().getLangOpts().NativeHalfType) else if (getASTContext().getLangOpts().NativeHalfType)
Out << "$f16@"; Out << "$f16@";
else else
Out << "$halff@"; Out << "$halff@";
break; break;
case BuiltinType::BFloat16:
mangleArtificialTagType(TTK_Struct, "__bf16", {"__clang"});
break;
#define SVE_TYPE(Name, Id, SingletonId) \ #define SVE_TYPE(Name, Id, SingletonId) \
case BuiltinType::Id: case BuiltinType::Id:
#include "clang/Basic/AArch64SVEACLETypes.def" #include "clang/Basic/AArch64SVEACLETypes.def"
#define PPC_VECTOR_TYPE(Name, Id, Size) \ #define PPC_VECTOR_TYPE(Name, Id, Size) \
case BuiltinType::Id: case BuiltinType::Id:
#include "clang/Basic/PPCTypes.def" #include "clang/Basic/PPCTypes.def"
#define RVV_TYPE(Name, Id, SingletonId) case BuiltinType::Id: #define RVV_TYPE(Name, Id, SingletonId) case BuiltinType::Id:
#include "clang/Basic/RISCVVTypes.def" #include "clang/Basic/RISCVVTypes.def"
Show All 16 Lines#include "clang/Basic/RISCVVTypes.def"
case BuiltinType::SatUAccum: case BuiltinType::SatUAccum:
case BuiltinType::SatULongAccum: case BuiltinType::SatULongAccum:
case BuiltinType::SatShortFract: case BuiltinType::SatShortFract:
case BuiltinType::SatFract: case BuiltinType::SatFract:
case BuiltinType::SatLongFract: case BuiltinType::SatLongFract:
case BuiltinType::SatUShortFract: case BuiltinType::SatUShortFract:
case BuiltinType::SatUFract: case BuiltinType::SatUFract:
case BuiltinType::SatULongFract: case BuiltinType::SatULongFract:
case BuiltinType::BFloat16:
case BuiltinType::Ibm128: case BuiltinType::Ibm128:
case BuiltinType::Float128: { case BuiltinType::Float128: {
DiagnosticsEngine &Diags = Context.getDiags(); DiagnosticsEngine &Diags = Context.getDiags();
unsigned DiagID = Diags.getCustomDiagID( unsigned DiagID = Diags.getCustomDiagID(
DiagnosticsEngine::Error, "cannot mangle this built-in %0 type yet"); DiagnosticsEngine::Error, "cannot mangle this built-in %0 type yet");
Diags.Report(Range.getBegin(), DiagID) Diags.Report(Range.getBegin(), DiagID)
<< T->getName(Context.getASTContext().getPrintingPolicy()) << Range; << T->getName(Context.getASTContext().getPrintingPolicy()) << Range;
break; break;
▲ Show 20 Lines • Show All 1,446 Lines • Show Last 20 Lines

clang/test/CodeGen/X86/bfloat-mangle.cpp

// RUN: %clang_cc1 -triple i386-unknown-unknown -target-feature +sse2 -emit-llvm -o - %s | FileCheck %s // RUN: %clang_cc1 -triple i386-unknown-unknown -target-feature +sse2 -emit-llvm -o - %s | FileCheck %s --check-prefixes=LINUX
// RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-feature +sse2 -emit-llvm -o - %s | FileCheck %s // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-feature +sse2 -emit-llvm -o - %s | FileCheck %s --check-prefixes=LINUX
// RUN: %clang_cc1 -triple i386-windows-msvc -target-feature +sse2 -emit-llvm -o - %s | FileCheck %s --check-prefixes=WINDOWS
// RUN: %clang_cc1 -triple x86_64-windows-msvc -target-feature +sse2 -emit-llvm -o - %s | FileCheck %s --check-prefixes=WINDOWS
// CHECK: define {{.*}}void @_Z3foou6__bf16(bfloat noundef %b) // LINUX: define {{.*}}void @_Z3foou6__bf16(bfloat noundef %b)
// WINDOWS: define {{.*}}void @"?foo@@YAXU__bf16@__clang@@@Z"(bfloat noundef %b)
void foo(__bf16 b) {} void foo(__bf16 b) {}