[MLIR] Remove unused config attributes from lit.site.cfg.py

[csigg]

Remove some more entries.

[herhut]

Thanks!

[uweigand]

This causes builder failures on s390x to reappear:
https://lab.llvm.org/buildbot/#/builders/199/builds/9247

It seems the

// UNSUPPORTED: s390x-

markers are no longer recognized.

[stella.stamenova]

This broke the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/25321

[hctim]

Also broke the sanitizer buildbots (why it doesn't show up in the blame, not sure): https://lab.llvm.org/buildbot/#/builders/5/builds/27187

https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild

=================================================================
==3324289==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 1024 byte(s) in 1 object(s) allocated from:
    #0 0x4038f62 in operator new(unsigned long, std::align_val_t) /b/sanitizer-x86_64-linux-fast/build/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:107:3
    #1 0x81fbe10 in allocateBuckets /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/DenseMap.h:872:9
    #2 0x81fbe10 in llvm::DenseMap<mlir::OperationName, llvm::Optional<unsigned int>, llvm::DenseMapInfo<mlir::OperationName, void>, llvm::detail::DenseMapPair<mlir::OperationName, llvm::Optional<unsigned int> > >::grow(unsigned int) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/DenseMap.h:806:5
    #3 0x81ef025 in InsertIntoBucketImpl<mlir::OperationName> /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/DenseMap.h
    #4 0x81ef025 in InsertIntoBucket<mlir::OperationName, const llvm::NoneType &> /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/DenseMap.h:547:17
    #5 0x81ef025 in try_emplace<const llvm::NoneType &> /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/DenseMap.h:234:9
    #6 0x81ef025 in mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool) /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/Pass.cpp:724:35
    #7 0x81eb5ec in runOnOperation /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/Pass.cpp:655:5
    #8 0x81eb5ec in mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int) /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/Pass.cpp:468:14
    #9 0x81f3700 in runPipeline /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/Pass.cpp:534:16
    #10 0x81f3700 in mlir::PassManager::runPasses(mlir::Operation*, mlir::AnalysisManager) /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/Pass.cpp:837:10
    #11 0x8212e44 in operator() /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/PassCrashRecovery.cpp:404:33
    #12 0x8212e44 in void llvm::function_ref<void ()>::callback_fn<mlir::PassManager::runWithCrashRecovery(mlir::Operation*, mlir::AnalysisManager)::$_3>(long) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/STLFunctionalExtras.h:45:12
    #13 0x41fe0ea in operator() /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/STLFunctionalExtras.h:68:12
    #14 0x41fe0ea in llvm::CrashRecoveryContext::RunSafely(llvm::function_ref<void ()>) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Support/CrashRecoveryContext.cpp:433:3
    #15 0x41fe7c0 in RunSafelyOnThread_Dispatch(void*) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Support/CrashRecoveryContext.cpp:514:29
    #16 0x41feab2 in Apply<void (*)(void *), (anonymous namespace)::RunSafelyOnThreadInfo *, 0UL> /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/thread.h:42:5
    #17 0x41feab2 in GenericThreadProxy<std::__1::tuple<void (*)(void *), (anonymous namespace)::RunSafelyOnThreadInfo *> > /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/thread.h:50:5
    #18 0x41feab2 in void* llvm::thread::ThreadProxy<std::__1::tuple<void (*)(void*), (anonymous namespace)::RunSafelyOnThreadInfo*> >(void*) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/thread.h:60:5
    #19 0x7f0ec9710b42  (/lib/x86_64-linux-gnu/libc.so.6+0x94b42) (BuildId: 69389d485a9793dbe873f0ea2c93e02efaa9aa3d)
Direct leak of 80 byte(s) in 1 object(s) allocated from:
    #0 0x4038b3d in operator new(unsigned long) /b/sanitizer-x86_64-linux-fast/build/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:95:3
    #1 0x81ef47a in __libcpp_operator_new<unsigned long> /b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan/include/c++/v1/new:264:10
    #2 0x81ef47a in __libcpp_allocate /b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan/include/c++/v1/new:290:10
    #3 0x81ef47a in allocate /b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan/include/c++/v1/__memory/allocator.h:112:38
    #4 0x81ef47a in __allocate_at_least<std::__1::allocator<std::__1::atomic<bool> > > /b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan/include/c++/v1/__memory/allocate_at_least.h:54:19
    #5 0x81ef47a in __vallocate /b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan/include/c++/v1/vector:686:29
    #6 0x81ef47a in vector /b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan/include/c++/v1/vector:1085:9
    #7 0x81ef47a in mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool) /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/Pass.cpp:742:34
    #8 0x81eb5ec in runOnOperation /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/Pass.cpp:655:5
    #9 0x81eb5ec in mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int) /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/Pass.cpp:468:14
    #10 0x81f3700 in runPipeline /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/Pass.cpp:534:16
    #11 0x81f3700 in mlir::PassManager::runPasses(mlir::Operation*, mlir::AnalysisManager) /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/Pass.cpp:837:10
    #12 0x8212e44 in operator() /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/PassCrashRecovery.cpp:404:33
    #13 0x8212e44 in void llvm::function_ref<void ()>::callback_fn<mlir::PassManager::runWithCrashRecovery(mlir::Operation*, mlir::AnalysisManager)::$_3>(long) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/STLFunctionalExtras.h:45:12
    #14 0x41fe0ea in operator() /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/STLFunctionalExtras.h:68:12
    #15 0x41fe0ea in llvm::CrashRecoveryContext::RunSafely(llvm::function_ref<void ()>) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Support/CrashRecoveryContext.cpp:433:3
    #16 0x41fe7c0 in RunSafelyOnThread_Dispatch(void*) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Support/CrashRecoveryContext.cpp:514:29
    #17 0x41feab2 in Apply<void (*)(void *), (anonymous namespace)::RunSafelyOnThreadInfo *, 0UL> /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/thread.h:42:5
    #18 0x41feab2 in GenericThreadProxy<std::__1::tuple<void (*)(void *), (anonymous namespace)::RunSafelyOnThreadInfo *> > /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/thread.h:50:5
    #19 0x41feab2 in void* llvm::thread::ThreadProxy<std::__1::tuple<void (*)(void*), (anonymous namespace)::RunSafelyOnThreadInfo*> >(void*) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/thread.h:60:5
    #20 0x7f0ec9710b42  (/lib/x86_64-linux-gnu/libc.so.6+0x94b42) (BuildId: 69389d485a9793dbe873f0ea2c93e02efaa9aa3d)
Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x4038b3d in operator new(unsigned long) /b/sanitizer-x86_64-linux-fast/build/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:95:3
    #1 0x81eee49 in __libcpp_operator_new<unsigned long> /b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan/include/c++/v1/new:264:10
    #2 0x81eee49 in __libcpp_allocate /b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan/include/c++/v1/new:290:10
    #3 0x81eee49 in allocate /b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan/include/c++/v1/__memory/allocator.h:112:38
    #4 0x81eee49 in __allocate_at_least<std::__1::allocator<OpPMInfo> > /b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan/include/c++/v1/__memory/allocate_at_least.h:54:19
    #5 0x81eee49 in __split_buffer /b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan/include/c++/v1/__split_buffer:320:29
    #6 0x81eee49 in __emplace_back_slow_path<unsigned int &, mlir::Operation *, mlir::AnalysisManager> /b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan/include/c++/v1/vector:1581:49
    #7 0x81eee49 in emplace_back<unsigned int &, mlir::Operation *, mlir::AnalysisManager> /b/sanitizer-x86_64-linux-fast/build/libcxx_build_asan/include/c++/v1/vector:1604:9
    #8 0x81eee49 in mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool) /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/Pass.cpp:732:17
    #9 0x81eb5ec in runOnOperation /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/Pass.cpp:655:5
    #10 0x81eb5ec in mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int) /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/Pass.cpp:468:14
    #11 0x81f3700 in runPipeline /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/Pass.cpp:534:16
    #12 0x81f3700 in mlir::PassManager::runPasses(mlir::Operation*, mlir::AnalysisManager) /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/Pass.cpp:837:10
    #13 0x8212e44 in operator() /b/sanitizer-x86_64-linux-fast/build/llvm-project/mlir/lib/Pass/PassCrashRecovery.cpp:404:33
    #14 0x8212e44 in void llvm::function_ref<void ()>::callback_fn<mlir::PassManager::runWithCrashRecovery(mlir::Operation*, mlir::AnalysisManager)::$_3>(long) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/STLFunctionalExtras.h:45:12
    #15 0x41fe0ea in operator() /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/STLFunctionalExtras.h:68:12
    #16 0x41fe0ea in llvm::CrashRecoveryContext::RunSafely(llvm::function_ref<void ()>) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Support/CrashRecoveryContext.cpp:433:3
    #17 0x41fe7c0 in RunSafelyOnThread_Dispatch(void*) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Support/CrashRecoveryContext.cpp:514:29
    #18 0x41feab2 in Apply<void (*)(void *), (anonymous namespace)::RunSafelyOnThreadInfo *, 0UL> /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/thread.h:42:5
    #19 0x41feab2 in GenericThreadProxy<std::__1::tuple<void (*)(void *), (anonymous namespace)::RunSafelyOnThreadInfo *> > /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/thread.h:50:5
    #20 0x41feab2 in void* llvm::thread::ThreadProxy<std::__1::tuple<void (*)(void*), (anonymous namespace)::RunSafelyOnThreadInfo*> >(void*) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/Support/thread.h:60:5
    #21 0x7f0ec9710b42  (/lib/x86_64-linux-gnu/libc.so.6+0x94b42) (BuildId: 69389d485a9793dbe873f0ea2c93e02efaa9aa3d)
SUMMARY: AddressSanitizer: 1128 byte(s) leaked in 3 allocation(s).

[vitalybuka]

mlir/test/lit.site.cfg.py.in

32

llvm_use_sanitizer is used to setup available_features

[csigg]

mlir/test/lit.site.cfg.py.in

32

llvm_use_sanitizer is used to setup available_features

Specifically, this is where it's translated to available_features:
https://github.com/llvm/llvm-project/blob/1ba8be315d924fb44ed1303d7e18f69d0ff6aa42/llvm/utils/lit/lit/llvm/config.py#L101

Thanks Vitaly for noticing and fixing forward in commit 4ff5bf2!

mlir/examples/standalone/test/lit.site.cfg.py.in

 @LIT_SITE_CFG_IN_HEADER@
 
 config.llvm_tools_dir = lit_config.substitute("@LLVM_TOOLS_DIR@")
-config.lit_tools_dir = "@LLVM_LIT_TOOLS_DIR@"
 config.mlir_obj_dir = "@MLIR_BINARY_DIR@"
-config.python_executable = "@Python3_EXECUTABLE@"
 config.enable_bindings_python = @MLIR_ENABLE_BINDINGS_PYTHON@
-config.standalone_src_root = "@CMAKE_SOURCE_DIR@"
 config.standalone_obj_root = "@CMAKE_BINARY_DIR@"
 
 import lit.llvm
 lit.llvm.initialize(lit_config, config)
 
 # Let the main config do the real work.
 lit_config.load_config(config, "@CMAKE_SOURCE_DIR@/test/lit.cfg.py")

mlir/test/Unit/lit.site.cfg.py.in

 @LIT_SITE_CFG_IN_HEADER@
 
 import sys
 
-config.llvm_src_root = "@LLVM_SOURCE_DIR@"
-config.llvm_obj_root = "@LLVM_BINARY_DIR@"
 config.llvm_tools_dir = lit_config.substitute("@LLVM_TOOLS_DIR@")
 config.llvm_build_mode = lit_config.substitute("@LLVM_BUILD_MODE@")
-config.enable_shared = @ENABLE_SHARED@
-config.shlibdir = lit_config.substitute("@SHLIBDIR@")
-config.mlir_src_root = "@MLIR_SOURCE_DIR@"
 config.mlir_obj_root = "@MLIR_BINARY_DIR@"
-config.mlir_tools_dir = "@MLIR_TOOLS_DIR@"
 
 # Let the main config do the real work.
 lit_config.load_config(config, "@MLIR_SOURCE_DIR@/test/Unit/lit.cfg.py")

mlir/test/lit.site.cfg.py.in

 @LIT_SITE_CFG_IN_HEADER@
 
 import sys
 
-config.host_triple = "@LLVM_HOST_TRIPLE@"
-config.target_triple = "@LLVM_TARGET_TRIPLE@"
-config.llvm_src_root = "@LLVM_SOURCE_DIR@"
-config.llvm_obj_root = "@LLVM_BINARY_DIR@"
 config.llvm_tools_dir = lit_config.substitute("@LLVM_TOOLS_DIR@")
-config.llvm_lib_dir = lit_config.substitute("@LLVM_LIBS_DIR@")
-config.llvm_shlib_dir = lit_config.substitute("@SHLIBDIR@")
 config.llvm_shlib_ext = "@SHLIBEXT@"
-config.llvm_exe_ext = "@EXEEXT@"
-config.lit_tools_dir = "@LLVM_LIT_TOOLS_DIR@"
 config.python_executable = "@Python3_EXECUTABLE@"
-config.gold_executable = "@GOLD_EXECUTABLE@"
-config.ld64_executable = "@LD64_EXECUTABLE@"
-config.enable_shared = @ENABLE_SHARED@
 config.enable_assertions = @ENABLE_ASSERTIONS@
-config.targets_to_build = "@TARGETS_TO_BUILD@"
 config.native_target = "@LLVM_NATIVE_ARCH@"
-config.llvm_bindings = "@LLVM_BINDINGS@".split(' ')
 config.host_os = "@HOST_OS@"
 config.host_cc = "@HOST_CC@"
 config.host_cxx = "@HOST_CXX@"
 config.enable_libcxx = "@LLVM_ENABLE_LIBCXX@"
 config.host_cmake = "@CMAKE_COMMAND@"
 config.host_cmake_generator = "@CMAKE_GENERATOR@"
-# Note: ldflags can contain double-quoted paths, so must use single quotes here.
-config.host_ldflags = '@HOST_LDFLAGS@'
 config.llvm_use_linker = "@LLVM_USE_LINKER@"
-config.llvm_use_sanitizer = "@LLVM_USE_SANITIZER@"
-config.llvm_host_triple = '@LLVM_HOST_TRIPLE@'
 config.host_arch = "@HOST_ARCH@"
 config.mlir_src_root = "@MLIR_SOURCE_DIR@"
 config.mlir_obj_root = "@MLIR_BINARY_DIR@"
 config.mlir_runner_utils_dir = "@MLIR_RUNNER_UTILS_DIR@"
 config.mlir_tools_dir = "@MLIR_TOOLS_DIR@"
 config.mlir_cmake_dir = "@MLIR_CMAKE_DIR@"
 config.linalg_test_lib_dir = "@MLIR_DIALECT_LINALG_INTEGRATION_TEST_LIB_DIR@"
 config.build_examples = @LLVM_BUILD_EXAMPLES@