Enables fixed sized vectors to detect SK_Splice shuffle patterns and provides basic X86 cost support
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I can't speak to the X86 costs, but the isSpliceMask changes look good. Do we want to use it in improveShuffleKindFromMask too?
Comment Actions
Rename non-static ShuffleVectorInst::isSpliceMask -> ShuffleVectorInst::isSplice to match other implementations
llvm/lib/IR/Instructions.cpp | ||
---|---|---|
2309 | Do we also need to check if we are extracting exactly half the original elements here? I see isSplice checks the length isn't changed, but other calls of isSpliceMask don't seem to do it (in BasicTTI) |
llvm/lib/IR/Instructions.cpp | ||
---|---|---|
2309 | None of the static shuffle kind matches know the width of the input types - they assume they match Mask.size() |
Do we also need to check if we are extracting exactly half the original elements here? I see isSplice checks the length isn't changed, but other calls of isSpliceMask don't seem to do it (in BasicTTI)