Page MenuHomePhabricator

[Flang] Enable lowering of CONVERT specifier in OPEN statements
ClosedPublic

Authored by jpenix-quic on Aug 12 2022, 3:43 PM.

Details

Summary

The runtime function is implemented and the specifier is
handled, but it seems lowering was never added, so enable
lowering this feature.

Diff Detail

Event Timeline

jpenix-quic created this revision.Aug 12 2022, 3:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2022, 3:43 PM
jpenix-quic requested review of this revision.Aug 12 2022, 3:43 PM
jpenix-quic added subscribers: chrisj, mnadeem.
peixin added inline comments.Aug 12 2022, 6:09 PM
flang/test/Lower/io-statement-open-options.f90
11

Can you add the IR check for "BIG_ENDIAN" argument specifically since this patch is supporting that?

Add IR checks to make sure that the BIG_ENDIAN string and string length are correctly set and passed into SetConvert.

jpenix-quic added inline comments.Aug 15 2022, 10:38 AM
flang/test/Lower/io-statement-open-options.f90
11

Added!

peixin accepted this revision.Aug 15 2022, 5:58 PM

LGTM. Please wait for one more approval. @jeanPerier

This revision is now accepted and ready to land.Aug 15 2022, 5:58 PM

@jeanPerier @clementval Can this be merged now? This will help test -fconvert= option in https://reviews.llvm.org/D130513.