Page MenuHomePhabricator

jpenix-quic (Jonathon Penix)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 15 2022, 9:02 AM (11 w, 3 d)

Recent Activity

Yesterday

jpenix-quic added a comment to D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

The lowering part looks good to me (I only have a minor comment inlined about a header used in lowering).

Mon, Oct 3, 4:48 PM · Restricted Project, Restricted Project, Restricted Project
jpenix-quic updated the diff for D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

Add /*overwrite=*/ comment I missed previously, move Runtime/environment-defaults.h to Lower/EnvironmentDefault.h

Mon, Oct 3, 4:13 PM · Restricted Project, Restricted Project, Restricted Project
jpenix-quic committed rG403d0b7a4e13: [flang] Skip creating AggregateStores for common block associated aggregates (authored by jpenix-quic).
[flang] Skip creating AggregateStores for common block associated aggregates
Mon, Oct 3, 12:21 PM · Restricted Project, Restricted Project
jpenix-quic closed D134828: [flang] Skip creating AggregateStores for common block associated aggregates.
Mon, Oct 3, 12:21 PM · Restricted Project, Restricted Project

Thu, Sep 29

jpenix-quic added inline comments to D134828: [flang] Skip creating AggregateStores for common block associated aggregates.
Thu, Sep 29, 2:56 PM · Restricted Project, Restricted Project
jpenix-quic updated the diff for D134828: [flang] Skip creating AggregateStores for common block associated aggregates.

Implement @jeanPerier's suggestion and update the title/summary accordingly. Also fixed "equivaleneced" -> "equivalenced" in the test comment.

Thu, Sep 29, 2:54 PM · Restricted Project, Restricted Project

Wed, Sep 28

jpenix-quic requested review of D134828: [flang] Skip creating AggregateStores for common block associated aggregates.
Wed, Sep 28, 1:03 PM · Restricted Project, Restricted Project

Tue, Sep 20

jpenix-quic added a comment to D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

The build still fails.

Tue, Sep 20, 6:09 PM · Restricted Project, Restricted Project, Restricted Project
jpenix-quic added inline comments to D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.
Tue, Sep 20, 5:16 PM · Restricted Project, Restricted Project, Restricted Project
jpenix-quic updated the diff for D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

Move comment, see if build will cooperate.

Tue, Sep 20, 4:56 PM · Restricted Project, Restricted Project, Restricted Project
jpenix-quic updated the diff for D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

Address comments from @awarzynski, @rovka, and @peixin. Also fixed the file header comments for EnvironmentDefaults.h, environment-defaults.h, and environment-default-list.h to match others in their respective folders.

Tue, Sep 20, 4:34 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 19

jpenix-quic committed rGbfcd536a8ef6: [flang] Give explicit convert= specifiers precedence over FORT_CONVERT (authored by jpenix-quic).
[flang] Give explicit convert= specifiers precedence over FORT_CONVERT
Mon, Sep 19, 8:48 PM · Restricted Project, Restricted Project
jpenix-quic closed D133237: [flang] Give explicit convert= specifiers precedence over FORT_CONVERT.
Mon, Sep 19, 8:47 PM · Restricted Project, Restricted Project
jpenix-quic added inline comments to D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.
Mon, Sep 19, 7:20 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Sep 16

jpenix-quic added inline comments to D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.
Fri, Sep 16, 11:43 AM · Restricted Project, Restricted Project, Restricted Project
jpenix-quic updated the diff for D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

Remove unneeded braces and unnecessary changes to NameUniquer.

Fri, Sep 16, 10:29 AM · Restricted Project, Restricted Project, Restricted Project

Sep 2 2022

jpenix-quic requested review of D133237: [flang] Give explicit convert= specifiers precedence over FORT_CONVERT.
Sep 2 2022, 3:13 PM · Restricted Project, Restricted Project
jpenix-quic added inline comments to D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.
Sep 2 2022, 12:00 PM · Restricted Project, Restricted Project, Restricted Project

Aug 26 2022

jpenix-quic added inline comments to D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.
Aug 26 2022, 12:27 PM · Restricted Project, Restricted Project, Restricted Project
jpenix-quic updated the diff for D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

Fixed up/simplified environment-default-list.h (and associated tests/lowering) for C/C++ compatibility. Also cleaned up a declaration and a few autos in the lowering component. Rebased.

Aug 26 2022, 12:00 PM · Restricted Project, Restricted Project, Restricted Project

Aug 24 2022

jpenix-quic committed rG15dc516e1f34: [Flang] Enable lowering of CONVERT specifier in OPEN statements (authored by jpenix-quic).
[Flang] Enable lowering of CONVERT specifier in OPEN statements
Aug 24 2022, 3:22 PM · Restricted Project, Restricted Project
jpenix-quic closed D131814: [Flang] Enable lowering of CONVERT specifier in OPEN statements.
Aug 24 2022, 3:22 PM · Restricted Project, Restricted Project

Aug 22 2022

jpenix-quic added a comment to D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

@klausler Could you please take a look at this again and let me know if it is more in line with your suggestion above?

Aug 22 2022, 4:10 PM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2022

jpenix-quic added inline comments to D132162: [flang] Avoid spurious error message in function result compatibility.
Aug 19 2022, 9:33 AM · Restricted Project, Restricted Project

Aug 18 2022

jpenix-quic added inline comments to D132162: [flang] Avoid spurious error message in function result compatibility.
Aug 18 2022, 11:48 AM · Restricted Project, Restricted Project
jpenix-quic added a comment to D132168: [flang][runtime] Handle endian-swapped record headers & footers on input.

LGTM, thank you!

Aug 18 2022, 11:42 AM · Restricted Project, Restricted Project

Aug 15 2022

jpenix-quic added inline comments to D131814: [Flang] Enable lowering of CONVERT specifier in OPEN statements.
Aug 15 2022, 10:38 AM · Restricted Project, Restricted Project
jpenix-quic updated the diff for D131814: [Flang] Enable lowering of CONVERT specifier in OPEN statements.

Add IR checks to make sure that the BIG_ENDIAN string and string length are correctly set and passed into SetConvert.

Aug 15 2022, 10:35 AM · Restricted Project, Restricted Project

Aug 12 2022

jpenix-quic updated subscribers of D131814: [Flang] Enable lowering of CONVERT specifier in OPEN statements.
Aug 12 2022, 3:44 PM · Restricted Project, Restricted Project
jpenix-quic requested review of D131814: [Flang] Enable lowering of CONVERT specifier in OPEN statements.
Aug 12 2022, 3:43 PM · Restricted Project, Restricted Project

Aug 9 2022

jpenix-quic updated the diff for D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

Rebase to address conflicts, use string substitution blocks in my tests.

Aug 9 2022, 11:42 AM · Restricted Project, Restricted Project, Restricted Project

Aug 8 2022

jpenix-quic added inline comments to D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.
Aug 8 2022, 12:06 PM · Restricted Project, Restricted Project, Restricted Project
jpenix-quic updated the diff for D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

Change hasMainProgram to be a local variable and update summary to reflect the new approach.

Aug 8 2022, 11:55 AM · Restricted Project, Restricted Project, Restricted Project

Aug 4 2022

jpenix-quic updated the diff for D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

Hopefully fix Window's build errors by using the proper Windows-specific environment utilities (_putenv_s vs setenv).

Aug 4 2022, 12:31 AM · Restricted Project, Restricted Project, Restricted Project

Aug 3 2022

jpenix-quic added a comment to D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

BTW, can you continue working on the lowering of the convert argument of open statement?

Aug 3 2022, 10:57 PM · Restricted Project, Restricted Project, Restricted Project
jpenix-quic updated the diff for D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

Attempted to address comments suggesting a different approach for the implementation. Rather than add a call to a new set_convert() runtime function, create a list of environment variable defaults that is passed into and set by the runtime via a "known" extern data structure. Also rebased.

Aug 3 2022, 10:19 PM · Restricted Project, Restricted Project, Restricted Project

Jul 26 2022

jpenix-quic added inline comments to D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.
Jul 26 2022, 3:03 PM · Restricted Project, Restricted Project, Restricted Project
jpenix-quic updated the diff for D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

Added changes to address feedback about missing braces and where I am adding options::OPT_fconvert_EQ (and removing the extra formatting change). Also removes an unnecessary include I had mistakenly added.

Jul 26 2022, 2:48 PM · Restricted Project, Restricted Project, Restricted Project

Jul 25 2022

jpenix-quic added inline comments to D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.
Jul 25 2022, 10:58 PM · Restricted Project, Restricted Project, Restricted Project
jpenix-quic added a comment to D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

Thank you for taking a look at this and thank you for the feedback!

Jul 25 2022, 4:27 PM · Restricted Project, Restricted Project, Restricted Project
jpenix-quic added a comment to D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.

I do have a few related lingering questions as well:

Jul 25 2022, 1:19 PM · Restricted Project, Restricted Project, Restricted Project
jpenix-quic requested review of D130513: [Flang] Add -fconvert option to swap endianness for unformatted files.
Jul 25 2022, 1:16 PM · Restricted Project, Restricted Project, Restricted Project

Jul 15 2022

jpenix-quic added reviewers for D129879: [Flang] Set constructExit for Where and Forall constructs: mnadeem, chrisj.
Jul 15 2022, 11:59 AM · Restricted Project, Restricted Project
jpenix-quic updated the diff for D129879: [Flang] Set constructExit for Where and Forall constructs.

Removing accidental whitespace change.

Jul 15 2022, 10:01 AM · Restricted Project, Restricted Project
jpenix-quic requested review of D129879: [Flang] Set constructExit for Where and Forall constructs.
Jul 15 2022, 9:51 AM · Restricted Project, Restricted Project