This is an archive of the discontinued LLVM Phabricator instance.

[clang][dataflow] Don't skip the entry block
AcceptedPublic

Authored by li.zhe.hua on Aug 10 2022, 9:52 PM.

Details

Summary

In D131646, we implement widen by taking the block state upon entry
into the loop and copying it to the block that represents the
back-edge in order to initialize the state for the "0th" iteration of
the loop. If the loop is the first thing after the entry block,
skipping the entry block means we don't have an opportunity to do this
initialization, so we want to analyze the entry block, even as it has
zero statements, to keep the logic consistent.

Diff Detail

Event Timeline

li.zhe.hua created this revision.Aug 10 2022, 9:52 PM
Herald added a project: Restricted Project. · View Herald Transcript
li.zhe.hua requested review of this revision.Aug 10 2022, 9:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2022, 9:53 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Fix commit message

li.zhe.hua edited the summary of this revision. (Show Details)Aug 10 2022, 10:04 PM
li.zhe.hua edited reviewers, added: xazax.hun, ymandel; removed: NoQ.
ymandel accepted this revision.Aug 11 2022, 5:09 AM
This revision is now accepted and ready to land.Aug 11 2022, 5:09 AM
ymandel added a subscriber: gribozavr.
sgatev accepted this revision.Aug 11 2022, 6:00 AM
xazax.hun accepted this revision.Aug 11 2022, 9:13 AM
gribozavr2 accepted this revision.Aug 11 2022, 12:48 PM