Switch option name to SuppressElaboration

In D149677#4349523, @aaron.ballman wrote:

In D149677#4320178, @li.zhe.hua wrote:

Some additional context: I'm working on a refactoring tool to, in part, deprecate an alias by replacing it with its definition. That functionality by itself could be provided through something like a clang-tidy, so I say "initially".

We typically don't add new printing policies in tree without some need for them in the project itself (otherwise this becomes a maintenance problem), and I'm not certain I see a strong need for this to live in Clang. I think it might be best to wait until you're closer to having a clang-tidy check that would use this functionality before we continue with this patch. WDYT?

In D149677#4319646, @aaron.ballman wrote:

Will this new printing policy be used in tree?

Accept suggested edits.

Update test name

Try this again...

Upload correct commit this time...

Fix description.
Remove default argument.
Fix copy/paste error.

Address comments

Yeah, that seems like it'd work just fine for us.

So the two functions I added were because previously using Annotations required knowledge of the annotation names a priori. If you are constructing one and using it directly yourself in a test, great. If you handed the Annotations object to a helper function, you'd also need to hand the two sets of names with it (one for points and one for ranges), otherwise the helper function doesn't know what annotations exist. In our case, the helper function is a googletest matcher verifying matches on AST nodes are bound to IDs matching the annotations listed. However, if no nodes are matched, we can't verify that all annotated nodes were matched without a lot of extra (possibly error-prone) boilerplate.

Appease clang-format, add constexpr to operator<.

Address comments

Address comments

Fix incorrect assumption that back edge blocks have an empty body.

In D131645#3716464, @xazax.hun wrote:

probably you are already aware of most of this

Add FIXME

Address comments

Fix commit message

Bah, I think I screwed up arc at some point. This was committed as 18034aee63eeac673496a88d9e90c8dd73d15927.

Explicitly name TransferOptions

Address comments.

In D128807#3620573, @ymandel wrote:

Eric -- what do you think? You've thought a lot more about metadata recently.

In D128848#3620185, @ymandel wrote:

Looks like you and Stanislav had the same idea?
https://reviews.llvm.org/D128833

Address reviewer comment.

Accidentally a word...

Address reviewer comments.