This is an archive of the discontinued LLVM Phabricator instance.

[Attributor][FIX] Visit same instructions with different scopes
ClosedPublic

Authored by jdoerfert on Aug 10 2022, 10:31 AM.

Details

Summary

If we collect potential values we need to visit a value even if we have
seen it before if the scope is different. The scope is part of the
result after all. Test included.

Fixes https://github.com/llvm/llvm-project/issues/56753

Diff Detail

Event Timeline

jdoerfert created this revision.Aug 10 2022, 10:31 AM
Herald added a project: Restricted Project. · View Herald Transcript
jdoerfert requested review of this revision.Aug 10 2022, 10:31 AM
Herald added a project: Restricted Project. · View Herald Transcript
jhuber6 accepted this revision.Aug 10 2022, 11:53 AM
This revision is now accepted and ready to land.Aug 10 2022, 11:53 AM

This patch addresses my bug report and passes multiple level of tests I have done so far.

ye-luo accepted this revision.Aug 10 2022, 12:03 PM
This revision was landed with ongoing or failed builds.Aug 10 2022, 2:02 PM
This revision was automatically updated to reflect the committed changes.