This is an archive of the discontinued LLVM Phabricator instance.

Differential D131455

[Driver] Add -Xclang= as an alias for -Xclang
ClosedPublic

Authored by MaskRay on Aug 8 2022, 5:10 PM.

Details

Reviewers
jhuber6
rnk
jdoerfert
Commits
rG8d9d27db4759: [Driver] Add -Xclang= as an alias for -Xclang
Summary

Driver options taking a value typically use = as the separator, instead of a
space. Unfortunately many older driver options do not stick with the rule, but I
find -Xclang used a lot and will be convenient if -Xclang= exists.

For build systems using a string array instead of a string to indicate compiler options,
["-Xclang=-foo"] is more convenient than ["-Xclang", "-foo"].
If a tool wants to filter out -Xclang=-foo, it is trivial for the = form, but
complex for the space separated form.

Diff Detail

Event Timeline

MaskRay created this revision.Aug 8 2022, 5:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 5:10 PM
Herald added subscribers: jeroen.dobbelaere, StephenFan. · View Herald Transcript
MaskRay requested review of this revision.Aug 8 2022, 5:10 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptAug 8 2022, 5:10 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: cfe-commits, sstefan1. · View Herald Transcript
MaskRay edited the summary of this revision. (Show Details)Aug 8 2022, 5:11 PM
MaskRay edited the summary of this revision. (Show Details)
jhuber6 accepted this revision.Aug 8 2022, 6:30 PM

LG

-Xopenmp-target= is somewhat different. The first joined argument is used to select a toolchain and the second, separate argument is the argument to pass. So something like -Xopenmp-target=nvptx64 -march=sm_70 would pass the architecture argument to the Nvidia toolchain only. The use of = can be a little confusing in this case.

This revision is now accepted and ready to land.Aug 8 2022, 6:30 PM
MaskRay added a comment.Aug 8 2022, 7:01 PM
In D131455#3708621, @jhuber6 wrote:

LG

-Xopenmp-target= is somewhat different. The first joined argument is used to select a toolchain and the second, separate argument is the argument to pass. So something like -Xopenmp-target=nvptx64 -march=sm_70 would pass the architecture argument to the Nvidia toolchain only. The use of = can be a little confusing in this case.

Thanks. Perhaps let me just drop -Xopenmp-target= from the description.

MaskRay edited the summary of this revision. (Show Details)Aug 8 2022, 7:01 PM
This revision was landed with ongoing or failed builds.Aug 8 2022, 7:05 PM
Closed by commit rG8d9d27db4759: [Driver] Add -Xclang= as an alias for -Xclang (authored by MaskRay). · Explain Why
This revision was automatically updated to reflect the committed changes.
MaskRay added a commit: rG8d9d27db4759: [Driver] Add -Xclang= as an alias for -Xclang.
Harbormaster completed remote builds in B180070: Diff 451006.Aug 8 2022, 9:53 PM
MaskRay mentioned this in D143325: [Driver] Add -mllvm= as an alias for -mllvm.Feb 4 2023, 12:58 PM
MaskRay mentioned this in rG90094ab8850e: [Driver] Add -mllvm= as an alias for -mllvm.Feb 5 2023, 10:30 AM

Revision Contents

PathSize
clang/
include/
clang/
Driver/
4 lines
test/
Driver/
4 lines

Diff 451026

clang/include/clang/Driver/Options.td

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 809 Lines • ▼ Show 20 Lines
def Xarch_host : Separate<["-"], "Xarch_host">, Flags<[NoXarchOption]>, def Xarch_host : Separate<["-"], "Xarch_host">, Flags<[NoXarchOption]>,
HelpText<"Pass <arg> to the CUDA/HIP host compilation">, MetaVarName<"<arg>">; HelpText<"Pass <arg> to the CUDA/HIP host compilation">, MetaVarName<"<arg>">;
def Xarch_device : Separate<["-"], "Xarch_device">, Flags<[NoXarchOption]>, def Xarch_device : Separate<["-"], "Xarch_device">, Flags<[NoXarchOption]>,
HelpText<"Pass <arg> to the CUDA/HIP device compilation">, MetaVarName<"<arg>">; HelpText<"Pass <arg> to the CUDA/HIP device compilation">, MetaVarName<"<arg>">;
def Xassembler : Separate<["-"], "Xassembler">, def Xassembler : Separate<["-"], "Xassembler">,
HelpText<"Pass <arg> to the assembler">, MetaVarName<"<arg>">, HelpText<"Pass <arg> to the assembler">, MetaVarName<"<arg>">,
Group<CompileOnly_Group>; Group<CompileOnly_Group>;
def Xclang : Separate<["-"], "Xclang">, def Xclang : Separate<["-"], "Xclang">,
HelpText<"Pass <arg> to the clang compiler">, MetaVarName<"<arg>">, HelpText<"Pass <arg> to clang -cc1">, MetaVarName<"<arg>">,
Flags<[NoXarchOption, CoreOption]>, Group<CompileOnly_Group>; Flags<[NoXarchOption, CoreOption]>, Group<CompileOnly_Group>;
def : Joined<["-"], "Xclang=">, Group<CompileOnly_Group>, Flags<[NoXarchOption, CoreOption]>, Alias<Xclang>,
HelpText<"Alias for -Xclang">, MetaVarName<"<arg>">;
def Xcuda_fatbinary : Separate<["-"], "Xcuda-fatbinary">, def Xcuda_fatbinary : Separate<["-"], "Xcuda-fatbinary">,
HelpText<"Pass <arg> to fatbinary invocation">, MetaVarName<"<arg>">; HelpText<"Pass <arg> to fatbinary invocation">, MetaVarName<"<arg>">;
def Xcuda_ptxas : Separate<["-"], "Xcuda-ptxas">, def Xcuda_ptxas : Separate<["-"], "Xcuda-ptxas">,
HelpText<"Pass <arg> to the ptxas assembler">, MetaVarName<"<arg>">; HelpText<"Pass <arg> to the ptxas assembler">, MetaVarName<"<arg>">;
def Xopenmp_target : Separate<["-"], "Xopenmp-target">, Group<CompileOnly_Group>, def Xopenmp_target : Separate<["-"], "Xopenmp-target">, Group<CompileOnly_Group>,
HelpText<"Pass <arg> to the target offloading toolchain.">, MetaVarName<"<arg>">; HelpText<"Pass <arg> to the target offloading toolchain.">, MetaVarName<"<arg>">;
def Xopenmp_target_EQ : JoinedAndSeparate<["-"], "Xopenmp-target=">, Group<CompileOnly_Group>, def Xopenmp_target_EQ : JoinedAndSeparate<["-"], "Xopenmp-target=">, Group<CompileOnly_Group>,
HelpText<"Pass <arg> to the target offloading toolchain identified by <triple>.">, HelpText<"Pass <arg> to the target offloading toolchain identified by <triple>.">,
▲ Show 20 Lines • Show All 6,093 Lines • Show Last 20 Lines

clang/test/Driver/disable-llvm.c

// We support a CC1 option for disabling LLVM's passes. // We support a CC1 option for disabling LLVM's passes.
// RUN: %clang -O2 -Xclang -disable-llvm-passes -### %s 2>&1 \ // RUN: %clang -O2 -Xclang -disable-llvm-passes -### %s 2>&1 \
// RUN: | FileCheck --check-prefix=DISABLED %s // RUN: | FileCheck --check-prefix=DISABLED %s
// Try -Xclang=.
// RUN: %clang -O2 -Xclang=-disable-llvm-passes -### %s 2>&1 \
// RUN: | FileCheck --check-prefix=DISABLED %s
// DISABLED: -cc1 // DISABLED: -cc1
// DISABLED-NOT: "-mllvm" "-disable-llvm-passes" // DISABLED-NOT: "-mllvm" "-disable-llvm-passes"
// DISABLED: "-disable-llvm-passes" // DISABLED: "-disable-llvm-passes"
// //
// We also support two alternative spellings for historical reasons. // We also support two alternative spellings for historical reasons.
// RUN: %clang -O2 -Xclang -disable-llvm-optzns -### %s 2>&1 \ // RUN: %clang -O2 -Xclang -disable-llvm-optzns -### %s 2>&1 \
// RUN: | FileCheck --check-prefix=DISABLED-LEGACY %s // RUN: | FileCheck --check-prefix=DISABLED-LEGACY %s
// RUN: %clang -O2 -mllvm -disable-llvm-optzns -### %s 2>&1 \ // RUN: %clang -O2 -mllvm -disable-llvm-optzns -### %s 2>&1 \
Show All 11 Lines