This is an archive of the discontinued LLVM Phabricator instance.

Differential D131398

[AMDGPU][MC][GFX11][NFC] Rename tests
ClosedPublic

Authored by dp on Aug 8 2022, 6:57 AM.

Details

Reviewers
Joe_Nash
foad
dstuttard
Commits
rG9d1eeefbfe04: [AMDGPU][MC][GFX11][NFC] Rename tests
Summary

Make test names more uniform.

Diff Detail

Unit TestsFailed

TimeTest
60,050 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

dp created this revision.Aug 8 2022, 6:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 6:57 AM
Herald added subscribers: kosarev, kerbowa, t-tye and 5 others. · View Herald Transcript
dp requested review of this revision.Aug 8 2022, 6:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 6:57 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
Joe_Nash added a comment.Aug 8 2022, 7:05 AM

Making things uniform is good. Isn't having asm or dasm in the filename redundant given the path?

dp added a comment.Aug 8 2022, 7:17 AM

I agree, the suffices are redundant. I was reluctant to remove the _asm/_dasm suffices because they have been used for many pre-GFX11 tests.
I can remove these suffices - for all targets or for GFX11 only. What do you think would be better?

Joe_Nash accepted this revision.Aug 8 2022, 7:29 AM
Joe_Nash added a reviewer: dstuttard.
In D131398#3706536, @dp wrote:

I agree, the suffices are redundant. I was reluctant to remove the _asm/_dasm suffices because they have been used for many pre-GFX11 tests.
I can remove these suffices - for all targets or for GFX11 only. What do you think would be better?

The only reason I can think that the name would matter is if people scripted against the old names. If you don't want to rename the old ones you have to trade off between uniformity (include asm/dasm) and simplicity on GFX11. I'm agnostic about it.

This revision is now accepted and ready to land.Aug 8 2022, 7:29 AM
Harbormaster completed remote builds in B179906: Diff 450789.Aug 8 2022, 9:16 AM
This revision was landed with ongoing or failed builds.Aug 9 2022, 3:59 AM
Closed by commit rG9d1eeefbfe04: [AMDGPU][MC][GFX11][NFC] Rename tests (authored by dp). · Explain Why
This revision was automatically updated to reflect the committed changes.
dp added a commit: rG9d1eeefbfe04: [AMDGPU][MC][GFX11][NFC] Rename tests.

Revision Contents

Diff 450789

llvm/test/MC/AMDGPU/exp-gfx11.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_exp.s.

llvm/test/MC/AMDGPU/flat-gfx11-mnemonic.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_flat_mnemonic.s.

llvm/test/MC/AMDGPU/gfx11-flat-errs.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_flat_errs.s.

llvm/test/MC/AMDGPU/gfx11_asm_ds.s

  • This file was moved from llvm/test/MC/AMDGPU/gfx11_ds.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_asm_err.s

  • This file was moved from llvm/test/MC/AMDGPU/gfx11_err.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_asm_exp.s

  • This file was moved from llvm/test/MC/AMDGPU/exp-gfx11.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_asm_flat.s

  • This file was moved from llvm/test/MC/AMDGPU/gfx11_flat.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_asm_flat_errs.s

  • This file was moved from llvm/test/MC/AMDGPU/gfx11-flat-errs.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_asm_flat_mnemonic.s

  • This file was moved from llvm/test/MC/AMDGPU/flat-gfx11-mnemonic.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_asm_ldsdir.s

  • This file was moved from llvm/test/MC/AMDGPU/ldsdir.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_asm_mtbuf.s

  • This file was moved from llvm/test/MC/AMDGPU/gfx11_mtbuf.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_asm_mtbuf_alias.s

  • This file was moved from llvm/test/MC/AMDGPU/gfx11_mtbuf_alias.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_asm_mubuf.s

  • This file was moved from llvm/test/MC/AMDGPU/gfx11_mubuf.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_asm_mubuf_alias.s

  • This file was moved from llvm/test/MC/AMDGPU/gfx11_mubuf_alias.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_asm_sopp.s

  • This file was moved from llvm/test/MC/AMDGPU/sopp-gfx11.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_asm_vinterp.s

  • This file was moved from llvm/test/MC/AMDGPU/vinterp.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_asm_vop3p.s

  • This file was moved from llvm/test/MC/AMDGPU/gfx11_vop3p.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_asm_vopd.s

  • This file was moved from llvm/test/MC/AMDGPU/vopd.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_asm_wmma.s

  • This file was moved from llvm/test/MC/AMDGPU/gfx11_wmma.s.
The contents of this file were not changed.

llvm/test/MC/AMDGPU/gfx11_ds.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_ds.s.

llvm/test/MC/AMDGPU/gfx11_err.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_err.s.

llvm/test/MC/AMDGPU/gfx11_flat.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_flat.s.

llvm/test/MC/AMDGPU/gfx11_mtbuf.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_mtbuf.s.

llvm/test/MC/AMDGPU/gfx11_mtbuf_alias.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_mtbuf_alias.s.

llvm/test/MC/AMDGPU/gfx11_mubuf.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_mubuf.s.

llvm/test/MC/AMDGPU/gfx11_mubuf_alias.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_mubuf_alias.s.

llvm/test/MC/AMDGPU/gfx11_vop3p.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_vop3p.s.

llvm/test/MC/AMDGPU/gfx11_wmma.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_wmma.s.

llvm/test/MC/AMDGPU/ldsdir.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_ldsdir.s.

llvm/test/MC/AMDGPU/sopp-gfx11.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_sopp.s.

llvm/test/MC/AMDGPU/vinterp.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_vinterp.s.

llvm/test/MC/AMDGPU/vopd.s

  • This file was moved to llvm/test/MC/AMDGPU/gfx11_asm_vopd.s.

llvm/test/MC/Disassembler/AMDGPU/ds_gfx11.txt

  • This file was moved to llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_ds.txt.

llvm/test/MC/Disassembler/AMDGPU/exp_gfx11.txt

  • This file was moved to llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_exp.txt.

llvm/test/MC/Disassembler/AMDGPU/flat-gfx11.txt

  • This file was moved to llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_flat.txt.

llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_ds.txt

  • This file was moved from llvm/test/MC/Disassembler/AMDGPU/ds_gfx11.txt.
The contents of this file were not changed.

llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_exp.txt

  • This file was moved from llvm/test/MC/Disassembler/AMDGPU/exp_gfx11.txt.
The contents of this file were not changed.

llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_flat.txt

  • This file was moved from llvm/test/MC/Disassembler/AMDGPU/flat-gfx11.txt.
The contents of this file were not changed.

llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_mimg.txt

  • This file was moved from llvm/test/MC/Disassembler/AMDGPU/gfx11_mimg.txt.
The contents of this file were not changed.

llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_mtbuf.txt

  • This file was moved from llvm/test/MC/Disassembler/AMDGPU/mtbuf_dasm_gfx11.txt.
The contents of this file were not changed.

llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_mubuf.txt

  • This file was moved from llvm/test/MC/Disassembler/AMDGPU/mubuf_dasm_gfx11.txt.
The contents of this file were not changed.

llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vinterp.txt

  • This file was moved from llvm/test/MC/Disassembler/AMDGPU/vinterp.txt.
The contents of this file were not changed.

llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_wmma.txt

  • This file was moved from llvm/test/MC/Disassembler/AMDGPU/gfx11_wmma.txt.
The contents of this file were not changed.

llvm/test/MC/Disassembler/AMDGPU/gfx11_mimg.txt

  • This file was moved to llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_mimg.txt.

llvm/test/MC/Disassembler/AMDGPU/gfx11_wmma.txt

  • This file was moved to llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_wmma.txt.

llvm/test/MC/Disassembler/AMDGPU/mtbuf_dasm_gfx11.txt

  • This file was moved to llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_mtbuf.txt.

llvm/test/MC/Disassembler/AMDGPU/mubuf_dasm_gfx11.txt

  • This file was moved to llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_mubuf.txt.

llvm/test/MC/Disassembler/AMDGPU/vinterp.txt

  • This file was moved to llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vinterp.txt.