[compiler-rt][BF16] Do not compile truncdfbf2.c and truncsfbf2.c if `__bf16` is not supported

[pengfei]

Summary

#56854 shows a backwards compatibility problem when builtins of compiler-rt don't follow ABI. We need to prevent to fall into the trap again for BF16.

[bkramer]

Works for me. This will still have the 32 bit x86 problem we're seeing on FreeBSD though.

[pengfei]

Thanks @bkramer. I considered the method in D130718, but we don't a macro like __FLT16_MAX__ for BF16. OTOH, I still believe using 64-bits configuration directly for i386 is somehow misuse. And simply adding a -msse2 can solve the problem.

[mib]

@pengfei This patch broke the macOS bot : https://green.lab.llvm.org/green/job/lldb-cmake/45984/

[pengfei]

In D131147#3711517, @mib wrote:

@pengfei This patch broke the macOS bot : https://green.lab.llvm.org/green/job/lldb-cmake/45984/

Thanks @mib for the information. It's odd. The reland patch should have solved the problem. I'll keep watching on the following build results. Thanks!

[mib]

In D131147#3711527, @pengfei wrote:

In D131147#3711517, @mib wrote:

@pengfei This patch broke the macOS bot : https://green.lab.llvm.org/green/job/lldb-cmake/45984/

Thanks @mib for the information. It's odd. The reland patch should have solved the problem. I'll keep watching on the following build results. Thanks!

The failure seems also to be happening with the reland patch (ab4e5ed441d475ead43bc4ce1cdef842688292f4), so I reverted it. Let me know if you need help reproducing the issue :)

[pengfei]

In D131147#3711532, @mib wrote:

In D131147#3711527, @pengfei wrote:

In D131147#3711517, @mib wrote:

@pengfei This patch broke the macOS bot : https://green.lab.llvm.org/green/job/lldb-cmake/45984/

Thanks @mib for the information. It's odd. The reland patch should have solved the problem. I'll keep watching on the following build results. Thanks!

The failure seems also to be happening with the reland patch (ab4e5ed441d475ead43bc4ce1cdef842688292f4), so I reverted it. Let me know if you need help reproducing the issue :)

Thank! I have found some clues in the log:

[1104/4435] Building C object CMakeFiles/clang_rt.builtins_x86_64_iossim.dir/truncdfbf2.c.o
... ...
[1168/4435] Building C object CMakeFiles/clang_rt.builtins_armv7_ios.dir/truncdfbf2.c.o

FAILED: CMakeFiles/clang_rt.builtins_armv7_ios.dir/truncdfbf2.c.o 
/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/./bin/clang --target=x86_64-apple-darwin19.5.0   -O3 -DNDEBUG -arch armv7 -isysroot ...

So the X86 runtimes are built successfully as expected. The problem is we are building armv7 target using the same cmake configure generated for X86 which enabled -DCOMPILER_RT_HAS_BFLOAT16. Let me think about how to solve the problem. But I wonder if it is also a problem for the buildbot?

[pengfei]

Another try rG0729d00

[pengfei]

Do not compile truncdfbf2.c and truncsfbf2.c if __bf16 is not supported.

This solves buildbot error "error: ISO C requires a translation unit to contain at least one declaration [-Werror,-Wempty-translation-unit]"

[pengfei]

Exclude APPLE targets.

compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake

macro(darwin_add_builtin_libraries)
 
   set(CFLAGS -fPIC -O3 -fvisibility=hidden -DVISIBILITY_HIDDEN -Wall -fomit-frame-pointer)
   set(CMAKE_C_FLAGS "")
   set(CMAKE_CXX_FLAGS "")
   set(CMAKE_ASM_FLAGS "")
 
   append_list_if(COMPILER_RT_HAS_ASM_LSE -DHAS_ASM_LSE CFLAGS)
 
+  append_list_if(COMPILER_RT_HAS_BFLOAT16 -DCOMPILER_RT_HAS_BFLOAT16 CFLAGS)
+
   set(PROFILE_SOURCES ../profile/InstrProfiling.c
                       ../profile/InstrProfilingBuffer.c
                       ../profile/InstrProfilingPlatformDarwin.c
                       ../profile/InstrProfilingWriter.c
                       ../profile/InstrProfilingInternal.c
                       ../profile/InstrProfilingVersionVar.c)
   foreach (os ${ARGN})
     list_intersect(DARWIN_BUILTIN_ARCHS DARWIN_${os}_BUILTIN_ARCHS BUILTIN_SUPPORTED_ARCH)

compiler-rt/cmake/builtin-config-ix.cmake

 builtin_check_c_compiler_source(COMPILER_RT_HAS_FLOAT16
 "
 _Float16 foo(_Float16 x) {
  return x;
 }
 "
 )
 
+builtin_check_c_compiler_source(COMPILER_RT_HAS_BFLOAT16
+"
+__bf16 foo(__bf16 x) {
+ return x;
+}
+"
+)
+
 builtin_check_c_compiler_source(COMPILER_RT_HAS_ASM_LSE
 "
 asm(\".arch armv8-a+lse\");
 asm(\"cas w0, w1, [x2]\");
 ")
 
 set(ARM64 aarch64)
 set(ARM32 arm armhf armv6m armv7m armv7em armv7 armv7s armv7k armv8m.main armv8.1m.main)

compiler-rt/lib/builtins/CMakeLists.txt

else ()
   set(BUILTIN_CFLAGS "")
 
   if (COMPILER_RT_HAS_FCF_PROTECTION_FLAG)
     append_list_if(COMPILER_RT_ENABLE_CET -fcf-protection=full BUILTIN_CFLAGS)
   endif()
 
   append_list_if(COMPILER_RT_HAS_FLOAT16 -DCOMPILER_RT_HAS_FLOAT16 BUILTIN_CFLAGS)
 
+  append_list_if(COMPILER_RT_HAS_BFLOAT16 -DCOMPILER_RT_HAS_BFLOAT16 BUILTIN_CFLAGS)
+
   append_list_if(COMPILER_RT_HAS_STD_C11_FLAG -std=c11 BUILTIN_CFLAGS)
 
   # These flags would normally be added to CMAKE_C_FLAGS by the llvm
   # cmake step. Add them manually if this is a standalone build.
   if(COMPILER_RT_STANDALONE_BUILD)
     if(COMPILER_RT_BUILTINS_ENABLE_PIC)
       append_list_if(COMPILER_RT_HAS_FPIC_FLAG -fPIC BUILTIN_CFLAGS)
     endif()

compiler-rt/lib/builtins/fp_trunc.h

 #else
 typedef uint16_t dst_t;
 #endif
 typedef uint16_t dst_rep_t;
 #define DST_REP_C UINT16_C
 static const int dstSigBits = 10;
 
 #elif defined DST_BFLOAT
-typedef uint16_t dst_t;
+typedef __bf16 dst_t;
 typedef uint16_t dst_rep_t;
 #define DST_REP_C UINT16_C
 static const int dstSigBits = 7;
 
 #else
 #error Destination should be single precision or double precision!
 #endif // end destination precision
 

compiler-rt/lib/builtins/truncsfbf2.c

 //===-- lib/truncsfbf2.c - single -> bfloat conversion ------------*- C -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
+#if defined(COMPILER_RT_HAS_BFLOAT16)
 #define SRC_SINGLE
 #define DST_BFLOAT
 #include "fp_trunc_impl.inc"
 
 COMPILER_RT_ABI dst_t __truncsfbf2(float a) { return __truncXfYf2__(a); }
+
+#endif