Implements part of:
- P1614R2 The Mothership has Landed
Fixes LWG3427
Paths
| Differential D130852
[libc++] Implement `operator<=>` for `shared_ptr` ClosedPublic Authored by avogelsgesang on Jul 31 2022, 12:43 PM.
Details
Summary Implements part of:
Fixes LWG3427
Diff Detail
Event TimelineComment Actions Thanks for your contribution! When resolving the review comments please look whether they apply to your other patches too. (I first want to look at this patch, once approved I'll look at the others.) For the CI, feel free to ignore the error of the format CI, this is a soft-error at the moment.
Comment Actions
Thank you for your review!
I will do so. I will let you know as soon as the other reviews are updated (probably only after we land this one, so I don't have to update the other commits multiple times)
Comment Actions In general I'm happy, one nit remaining. I like to see the CI green before approving.
avogelsgesang marked 2 inline comments as done. Comment Actions
This revision is now accepted and ready to land.Aug 3 2022, 9:30 AM Closed by commit rG3b217f2f127e: [libc++] Implement `operator<=>` for `shared_ptr` (authored by avogelsgesang, committed by Mordante). · Explain WhyAug 3 2022, 9:32 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 449353 libcxx/docs/Status/Cxx2bIssues.csv
libcxx/docs/Status/SpaceshipProjects.csv
libcxx/include/__memory/shared_ptr.h
libcxx/include/memory
libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.cmp/cmp.pass.cpp
libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.cmp/cmp_nullptr.pass.cpp
libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.cmp/eq.pass.cpp
libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.cmp/lt.pass.cpp
|