This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Implement `operator==` for `filesystem::space_info`
ClosedPublic

Authored by avogelsgesang on Jul 31 2022, 4:31 PM.

Details

Summary

Implements part of P1614R2 "The Mothership has Landed"

Diff Detail

Event Timeline

avogelsgesang created this revision.Jul 31 2022, 4:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2022, 4:31 PM
avogelsgesang requested review of this revision.Jul 31 2022, 4:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2022, 4:31 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
avogelsgesang planned changes to this revision.Aug 1 2022, 2:47 PM

need to update based on comments in https://reviews.llvm.org/D130852

update based on first feedback on https://reviews.llvm.org/D130852

Fix test cases

update synopsis

Add missing _LIBCPP_HIDE_FROM_ABI

LGTM, except for the missing constexpr test. I want to see that before approving.

libcxx/test/std/input.output/filesystems/fs.filesystem.synopsis/space_info.pass.cpp
28

Please also test as constexpr since the defaulted is a constexpr function. (http://eel.is/c++draft/class.compare.default#4)

Add constexpr test

avogelsgesang marked an inline comment as done.Aug 7 2022, 6:50 AM

Remove debug include

Mordante accepted this revision.Aug 8 2022, 8:36 AM

LGTM!

This revision is now accepted and ready to land.Aug 8 2022, 8:36 AM