This is an archive of the discontinued LLVM Phabricator instance.

[libc++][doc] Update spaceship status page
ClosedPublic

Authored by avogelsgesang on Jul 31 2022, 1:15 PM.

Details

Reviewers
ldionne
Mordante
philnik
Group Reviewers
Restricted Project
Commits
rGceebf91744a3: [libc++][doc] Update spaceship status page
Summary
  • operator<=> for iota_view::iterator was enabled in 8320017b79eb8
  • Removed P2405R0 which was not accepted and seems inactive (https://github.com/cplusplus/papers/issues/1075)
  • Added the previously missing operator== for filesystem::space_info to the tracking list.
  • Updated the "Assignee" for string_view, string as Mark de Wever mentioned he is working on them in Discord
  • Updated the status of the items for which I sent review requests yesterday.

Diff Detail

Event Timeline

avogelsgesang created this revision.Jul 31 2022, 1:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2022, 1:15 PM
Herald added a subscriber: yaxunl. · View Herald Transcript
avogelsgesang requested review of this revision.Jul 31 2022, 1:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2022, 1:15 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Fix incorrect state: 'Done' -> 'Complete'

Mordante requested changes to this revision.Aug 1 2022, 8:48 AM

As discussed on Discord there are more documentation updates missing.

This revision now requires changes to proceed.Aug 1 2022, 8:48 AM

Additional updates

avogelsgesang edited the summary of this revision. (Show Details)Aug 1 2022, 9:55 AM
Mordante accepted this revision.Aug 2 2022, 10:42 AM

Thanks for the update, LGTM!
Do you need assistance with landing the patch? If so please provide the name and e-mail address you want to use. (I'm not sure whether you used them uploading the patch in Phabricator.)

This revision is now accepted and ready to land.Aug 2 2022, 10:42 AM

Do you need assistance with landing the patch? If so please provide the name and e-mail address you want to use.

Yes, I need assistance. I do not have merge privileges.
Name: Adrian Vogelsgesang
Email: avogelsgesang@salesforce.com

This revision was automatically updated to reflect the committed changes.

Do you need assistance with landing the patch? If so please provide the name and e-mail address you want to use.

Yes, I need assistance. I do not have merge privileges.
Name: Adrian Vogelsgesang
Email: avogelsgesang@salesforce.com

I've landed on your behalf.