Implements part of P1614R2 "The Mothership has Landed"
ldionne Mordante philnik
- Group Reviewers
- rGb3ab3bece0bf: [libc++] Implement `operator<=>` for `filesystem::path`
clang-format proposed this change when posting the commit for review. Please let me know if you prefer me to undo it
fix clang-format CI failure (I don't understand why it wants this indentation - but I don't care to fit it...)
not sure where I should put them, if I change them to be friends.
The path class is only forward-declared in the synopsis.
Path has its own synopsis hidden in http://eel.is/c++draft/fs.class.path.general#6
We could add that to the main synopsis. We've done that in other places too, but not in a consistent fashion.
I have added a synopsis for class path now. Please let me know if this is what you had in mind
We normally don't do this, but it's interesting to do this for those "hidden" synopsis.
is your comment an ask to remove this and follow the established way of not including this?
Sorry if I was unclear.
I think it's useful and we might even consider doing that for other "hidden" synopsis too. That is sometimes useful during review. I noticed with ranges it's sometimes not easy to find where to look in the Standard.