[mlir] Add has_value and value to OptionalParseResult

[kazu]

Summary

llvm::Optional is in the process of switching to the
std::optional-like interface with has_value/value as opposed to
hasValue/getValue.

This patch adds has_value and value to enable the same transition.

[jpienaar]

I don't quite follow how changes to llvm::Optional necessitates changes to OptionalParseResult's API. llvm::Optional is an implementation detail not a user facing one.

[kazu]

In D130819#3689098, @jpienaar wrote:

I don't quite follow how changes to llvm::Optional necessitates changes to OptionalParseResult's API. llvm::Optional is an implementation detail not a user facing one.

This patch is for consistency with updates to llvm::Optional so that people don't have to worry about whether to use hasValue or has_value. As you mentioned, changes to llvm::Optional do not necessitate changes to OptionalParseResult.

[rriddle]

Seems fine I suppose to match the API of Optional.

mlir/include/mlir/IR/OpDefinition.h

public:
   OptionalParseResult() = default;
   OptionalParseResult(LogicalResult result) : impl(result) {}
   OptionalParseResult(ParseResult result) : impl(result) {}
   OptionalParseResult(const InFlightDiagnostic &)
       : OptionalParseResult(failure()) {}
   OptionalParseResult(llvm::NoneType) : impl(llvm::None) {}
 
   /// Returns true if we contain a valid ParseResult value.
+  bool has_value() const { return impl.has_value(); }
   bool hasValue() const { return impl.has_value(); }
 
   /// Access the internal ParseResult value.
+  ParseResult value() const { return impl.value(); }
   ParseResult getValue() const { return impl.value(); }
   ParseResult operator*() const { return getValue(); }
 
 private:
   Optional<ParseResult> impl;
 };
 
 // These functions are out-of-line utilities, which avoids them being template