This is an archive of the discontinued LLVM Phabricator instance.

Split class ValueRange to a new file
ClosedPublic

Authored by lipracer on Jul 21 2022, 10:23 PM.

Details

Summary

When we apply parent patch : https://reviews.llvm.org/D129475
The prompt I get with the clang compiler is: ValueRange is imcomplete type,ValueRange is a forward declaration in the file TypeRange.h, and the file OperationSupport.h already includes the file TypeRange.h.The class TypeRange and the class ValueRange depend on each other.

Diff Detail

Event Timeline

lipracer created this revision.Jul 21 2022, 10:23 PM
lipracer requested review of this revision.Jul 21 2022, 10:23 PM
rriddle accepted this revision.Jul 21 2022, 10:28 PM
rriddle added inline comments.
mlir/include/mlir/IR/ValueRange.h
1–2

Please fix this.

392–393
mlir/lib/IR/ValueRange.cpp
1–2

Please fix this.

This revision is now accepted and ready to land.Jul 21 2022, 10:28 PM
lipracer updated this revision to Diff 446745.Jul 22 2022, 2:00 AM
lipracer removed subscribers: mgorny, mehdi_amini, shauheen and 20 others.

format

lipracer marked 3 inline comments as done.Jul 22 2022, 2:01 AM
Mogball accepted this revision.Jul 22 2022, 12:19 PM
Mogball added inline comments.
mlir/include/mlir/IR/ValueRange.h
2

There's usually a little summary up here

mlir/lib/IR/ValueRange.cpp
2

Nit: there's usually a description here

lipracer marked 2 inline comments as done.Jul 24 2022, 2:33 AM

I can land this in a bit

This revision was automatically updated to reflect the committed changes.