Page MenuHomePhabricator

lipracer (long.chen)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 2 2021, 10:51 PM (39 w, 6 d)

Recent Activity

Sun, Jul 24

lipracer added a comment to D130332: Split class ValueRange to a new file.

Thanks.

Sun, Jul 24, 8:50 PM · Restricted Project, Restricted Project
lipracer updated the diff for D130332: Split class ValueRange to a new file.

format

Sun, Jul 24, 2:33 AM · Restricted Project, Restricted Project

Fri, Jul 22

lipracer added a comment to D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity.

Is the build status up to date?

Fri, Jul 22, 9:45 PM · Restricted Project, Restricted Project
lipracer updated the diff for D130332: Split class ValueRange to a new file.

format

Fri, Jul 22, 2:00 AM · Restricted Project, Restricted Project

Thu, Jul 21

lipracer added a comment to D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity.

Can you move the splitting of the files into another patch? It's kind of hard to review the diff otherwise

Thu, Jul 21, 10:25 PM · Restricted Project, Restricted Project
lipracer requested review of D130332: Split class ValueRange to a new file.
Thu, Jul 21, 10:23 PM · Restricted Project, Restricted Project
lipracer updated the diff for D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity.

regression

Thu, Jul 21, 10:15 PM · Restricted Project, Restricted Project

Wed, Jul 20

lipracer added inline comments to D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity.
Wed, Jul 20, 10:32 PM · Restricted Project, Restricted Project
lipracer added inline comments to D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity.
Wed, Jul 20, 10:25 PM · Restricted Project, Restricted Project
lipracer added inline comments to D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity.
Wed, Jul 20, 10:15 PM · Restricted Project, Restricted Project
lipracer updated the diff for D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity.

Split out ValueRange declare from OperationSupport.h

Wed, Jul 20, 1:02 AM · Restricted Project, Restricted Project

Tue, Jul 19

lipracer added inline comments to D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity.
Tue, Jul 19, 6:29 PM · Restricted Project, Restricted Project
lipracer added a reviewer for D128537: [mlir][NFC] Use proper c++ namespaces in .td files: Mogball.
Tue, Jul 19, 1:01 AM · Restricted Project, Restricted Project

Mon, Jul 18

lipracer added inline comments to D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity.
Mon, Jul 18, 6:26 PM · Restricted Project, Restricted Project
lipracer added reviewers for D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity: jpienaar, mehdi_amini, Mogball.
Mon, Jul 18, 1:59 AM · Restricted Project, Restricted Project

Thu, Jul 14

lipracer updated the diff for D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity.

format

Thu, Jul 14, 11:53 PM · Restricted Project, Restricted Project
lipracer updated the diff for D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity.

build fail

Thu, Jul 14, 10:09 AM · Restricted Project, Restricted Project

Wed, Jul 13

lipracer added a comment to D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity.

The msvc reported error is that: When we pass a parameter MutableArrayRef<BlockArgument> to the following function:

TypeRange(ValueTypeRange<ValueRangeT> values)
    : TypeRange(ValueRangeT(values.begin().getCurrent(),
                            values.end().getCurrent())) {}

then call delegating constructor:
TypeRange(ValueRange values); and TypeRange(const iterator_range<iterator> &range values) inherits from indexed_accessor_range_base
My second update trying to explicit call TypeRange(ValueRange values);
the clang reported error incomplete type 'mlir::ValueRange' and it defined in the OperationSupport.h file, and this file inclue<TypeRange.h>
I wonder if putting the ValueRange definition in a new file will work well.

Wed, Jul 13, 8:22 AM · Restricted Project, Restricted Project

Tue, Jul 12

lipracer added a comment to D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity.

The windows failure looks real, can you take a look?

Tue, Jul 12, 11:20 AM · Restricted Project, Restricted Project
lipracer updated the diff for D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity.

windows msvc and gcc7 build error

Tue, Jul 12, 11:19 AM · Restricted Project, Restricted Project

Mon, Jul 11

lipracer requested review of D129475: [mlir][NFC] Remove TypeRange's constructors that cause ambiguity.
Mon, Jul 11, 2:31 AM · Restricted Project, Restricted Project

Jun 30 2022

lipracer added a comment to D128537: [mlir][NFC] Use proper c++ namespaces in .td files.

I don't have permission to commit.Can you help to commit this?

Jun 30 2022, 7:17 PM · Restricted Project, Restricted Project

Jun 27 2022

lipracer added a comment to D128537: [mlir][NFC] Use proper c++ namespaces in .td files.

done.

Jun 27 2022, 7:31 PM · Restricted Project, Restricted Project
lipracer retitled D128537: [mlir][NFC] Use proper c++ namespaces in .td files from 0001-mlir-NFC-Use-proper-c-namespaces-in-.td-files.patch to [mlir][NFC] Use proper c++ namespaces in .td files.
Jun 27 2022, 7:30 PM · Restricted Project, Restricted Project
lipracer retitled D128537: [mlir][NFC] Use proper c++ namespaces in .td files from code cleanup to 0001-mlir-NFC-Use-proper-c-namespaces-in-.td-files.patch.
Jun 27 2022, 7:29 PM · Restricted Project, Restricted Project

Jun 24 2022

lipracer requested review of D128537: [mlir][NFC] Use proper c++ namespaces in .td files.
Jun 24 2022, 8:14 AM · Restricted Project, Restricted Project

Jun 10 2022

lipracer added inline comments to rG96bbe1bd61c6: [mlir] Rename mlir::SmallVector -> llvm::SmallVector.
Jun 10 2022, 4:51 AM · Restricted Project, Restricted Project

Jun 9 2022

lipracer added inline comments to rG96bbe1bd61c6: [mlir] Rename mlir::SmallVector -> llvm::SmallVector.
Jun 9 2022, 8:54 PM · Restricted Project, Restricted Project

Mar 28 2022

lipracer added reviewers for D122599: [mlir] tosa: build error when building with clang: Mogball, mehdi_amini.

@hpmorgan Could you please review it, It's very strange why we get normal clang-format results when we change the macro definition to uppercase.

Mar 28 2022, 10:41 AM · Restricted Project, Restricted Project
lipracer added a comment to D121513: [mlir][tosa] : adding folder and canonicalizer for select.

Hi @lipracer, this change has caused a build error when building with clang:

/usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DMLIR_CUDA_CONVERSIONS_ENABLED=0 -DMLIR_ROCM_CONVERSIONS_ENABLED=0 -D_DEBUG -D_GNU_SOURCE -DSTDC_CONSTANT_MACROS -DSTDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/mnt/vss/_work/1/b/llvm/Release/tools/mlir/lib/Dialect/Tosa -I/mnt/vss/_work/1/llvm-project/mlir/lib/Dialect/Tosa -I/mnt/vss/_work/1/b/llvm/Release/include -I/mnt/vss/_work/1/llvm-project/llvm/include -I/mnt/vss/_work/1/llvm-project/mlir/include -I/mnt/vss/_work/1/b/llvm/Release/tools/mlir/include -fPIC -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -Werror=mismatched-tags -Werror=global-constructors -O3 -DNDEBUG -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT tools/mlir/lib/Dialect/Tosa/CMakeFiles/obj.MLIRTosa.dir/IR/TosaOps.cpp.o -MF tools/mlir/lib/Dialect/Tosa/CMakeFiles/obj.MLIRTosa.dir/IR/TosaOps.cpp.o.d -o tools/mlir/lib/Dialect/Tosa/CMakeFiles/obj.MLIRTosa.dir/IR/TosaOps.cpp.o -c /mnt/vss/_work/1/llvm-project/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
/mnt/vss/_work/1/llvm-project/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp:599:26: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
ReduceFolder(ReduceAllOp);

Mar 28 2022, 10:38 AM · Restricted Project, Restricted Project
lipracer requested review of D122599: [mlir] tosa: build error when building with clang.
Mar 28 2022, 10:35 AM · Restricted Project, Restricted Project
lipracer added a comment to D121513: [mlir][tosa] : adding folder and canonicalizer for select.
Mar 28 2022, 9:48 AM · Restricted Project, Restricted Project

Mar 26 2022

lipracer added a comment to D122527: Eliminate gcc7 compiler warnings.

Thanks for the review.
If we use c++20, we can write verify function like this:

Mar 26 2022, 10:34 AM · Restricted Project, Restricted Project
lipracer requested review of D122527: Eliminate gcc7 compiler warnings.
Mar 26 2022, 6:50 AM · Restricted Project, Restricted Project

Mar 25 2022

lipracer added a comment to D121513: [mlir][tosa] : adding folder and canonicalizer for select.

Thanks,Can you help me commit this? user.name: lipracer user.email: lipracer@gmail.com

Mar 25 2022, 1:00 AM · Restricted Project, Restricted Project
lipracer updated the diff for D121513: [mlir][tosa] : adding folder and canonicalizer for select.

format code style with clang-format

Mar 25 2022, 12:35 AM · Restricted Project, Restricted Project

Mar 24 2022

lipracer updated the diff for D121513: [mlir][tosa] : adding folder and canonicalizer for select.

fix typo

Mar 24 2022, 9:01 PM · Restricted Project, Restricted Project
lipracer updated the diff for D121513: [mlir][tosa] : adding folder and canonicalizer for select.

wrap setOperands with updateRootInPlace

Mar 24 2022, 8:57 PM · Restricted Project, Restricted Project
lipracer reclaimed D121513: [mlir][tosa] : adding folder and canonicalizer for select.
Mar 24 2022, 1:12 AM · Restricted Project, Restricted Project
lipracer abandoned D121513: [mlir][tosa] : adding folder and canonicalizer for select.
Mar 24 2022, 1:11 AM · Restricted Project, Restricted Project

Mar 12 2022

lipracer updated the diff for D121513: [mlir][tosa] : adding folder and canonicalizer for select.
Mar 12 2022, 12:04 PM · Restricted Project, Restricted Project
lipracer added inline comments to D121513: [mlir][tosa] : adding folder and canonicalizer for select.
Mar 12 2022, 11:52 AM · Restricted Project, Restricted Project
lipracer updated the diff for D121513: [mlir][tosa] : adding folder and canonicalizer for select.

refine

Mar 12 2022, 11:52 AM · Restricted Project, Restricted Project
lipracer added a reviewer for D121513: [mlir][tosa] : adding folder and canonicalizer for select: mehdi_amini.
Mar 12 2022, 6:49 AM · Restricted Project, Restricted Project
lipracer updated the diff for D121513: [mlir][tosa] : adding folder and canonicalizer for select.

update patch rebase on latest

Mar 12 2022, 12:00 AM · Restricted Project, Restricted Project

Mar 11 2022

lipracer requested review of D121513: [mlir][tosa] : adding folder and canonicalizer for select.
Mar 11 2022, 10:09 PM · Restricted Project, Restricted Project

Dec 30 2021

lipracer retitled D116389: [MLIR] Add explicit using getElementType for base class to disambiguate between multiple implementations from [MLIR] remove redundant define of getElementType to [MLIR] Add explicit using getElementType for base class to disambiguate between multiple implementations.
Dec 30 2021, 4:43 AM · Restricted Project
lipracer retitled D116389: [MLIR] Add explicit using getElementType for base class to disambiguate between multiple implementations from [MLIR] remove rundant define of getElementType to [MLIR] remove redundant define of getElementType.
Dec 30 2021, 4:41 AM · Restricted Project

Dec 29 2021

lipracer added a comment to D116389: [MLIR] Add explicit using getElementType for base class to disambiguate between multiple implementations.

(I'd need the name and email you want to be used for the commit if you need me to land it)

Dec 29 2021, 11:51 PM · Restricted Project
lipracer added a comment to D116389: [MLIR] Add explicit using getElementType for base class to disambiguate between multiple implementations.

Your commit title is confusing to me, you wrote "remove rundant define of getElementType" but wouldn't it be more accurate to say "Add explicit using getElementType for base class to disambiguate between multiple implementations" or something like that?

Dec 29 2021, 11:01 PM · Restricted Project
lipracer updated the diff for D116389: [MLIR] Add explicit using getElementType for base class to disambiguate between multiple implementations.

Difference patch with full context.

Dec 29 2021, 9:32 PM · Restricted Project
lipracer requested review of D116389: [MLIR] Add explicit using getElementType for base class to disambiguate between multiple implementations.
Dec 29 2021, 7:22 PM · Restricted Project

Nov 10 2021

lipracer added a comment to D113363: [mlir](arithmetic) Add ceildivui to the arithmetic dialect.

Thank very much for your feedback.

Nov 10 2021, 5:31 PM · Restricted Project

Nov 9 2021

lipracer added a comment to D113363: [mlir](arithmetic) Add ceildivui to the arithmetic dialect.

nex what I need to do? I don't have permission to commit.

Nov 9 2021, 6:55 PM · Restricted Project
lipracer updated the diff for D113363: [mlir](arithmetic) Add ceildivui to the arithmetic dialect.

update for format error

Nov 9 2021, 6:52 PM · Restricted Project
lipracer added inline comments to D113363: [mlir](arithmetic) Add ceildivui to the arithmetic dialect.
Nov 9 2021, 9:04 AM · Restricted Project
lipracer updated the diff for D113363: [mlir](arithmetic) Add ceildivui to the arithmetic dialect.

format code with clang-format-13.0

Nov 9 2021, 1:11 AM · Restricted Project

Nov 8 2021

lipracer updated the diff for D113363: [mlir](arithmetic) Add ceildivui to the arithmetic dialect.
Nov 8 2021, 7:44 PM · Restricted Project
lipracer added inline comments to D113363: [mlir](arithmetic) Add ceildivui to the arithmetic dialect.
Nov 8 2021, 6:00 PM · Restricted Project

Nov 7 2021

lipracer retitled D113363: [mlir](arithmetic) Add ceildivui to the arithmetic dialect from Add ceildivui floordivui to the arithmetic dialect to [mlir](arithmetic) Add ceildivui floordivui to the arithmetic dialect.
Nov 7 2021, 6:48 PM · Restricted Project
lipracer updated the diff for D113363: [mlir](arithmetic) Add ceildivui to the arithmetic dialect.

Format the code with the latest clang-format.

Nov 7 2021, 3:28 AM · Restricted Project
lipracer updated the summary of D113363: [mlir](arithmetic) Add ceildivui to the arithmetic dialect.
Nov 7 2021, 3:07 AM · Restricted Project
lipracer updated the summary of D113363: [mlir](arithmetic) Add ceildivui to the arithmetic dialect.
Nov 7 2021, 3:06 AM · Restricted Project
lipracer requested review of D113363: [mlir](arithmetic) Add ceildivui to the arithmetic dialect.
Nov 7 2021, 3:04 AM · Restricted Project