This is an archive of the discontinued LLVM Phabricator instance.

Differential D130026

[clang-tidy] Remove unnecessary code from ReadabilityModuleTest
ClosedPublic

Authored by njames93 on Jul 18 2022, 10:05 AM.

Details

Reviewers
LegalizeAdulthood
aaron.ballman
kwk
serge-sans-paille
Commits
rG6357f1c1aa76: [clang-tidy] Remove unnecessary code from ReadabilityModuleTest
Summary

D56303 added testing code that was then made redundant by the changes in D125026. However this code wasn't completely removed in the latter patch.

Diff Detail

Event Timeline

njames93 created this revision.Jul 18 2022, 10:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2022, 10:05 AM
Herald added subscribers: xazax.hun, mgorny. · View Herald Transcript
njames93 requested review of this revision.Jul 18 2022, 10:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2022, 10:05 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaron.ballman accepted this revision.Jul 18 2022, 11:34 AM

LGTM!

This revision is now accepted and ready to land.Jul 18 2022, 11:34 AM
Harbormaster completed remote builds in B176070: Diff 445555.Jul 18 2022, 12:11 PM
Closed by commit rG6357f1c1aa76: [clang-tidy] Remove unnecessary code from ReadabilityModuleTest (authored by njames93). · Explain WhyJul 18 2022, 9:21 PM
This revision was automatically updated to reflect the committed changes.
njames93 added a commit: rG6357f1c1aa76: [clang-tidy] Remove unnecessary code from ReadabilityModuleTest.

Revision Contents

PathSize
clang-tools-extra/
unittests/
clang-tidy/
1 line
33 lines

Diff 445555

clang-tools-extra/unittests/clang-tidy/CMakeLists.txt

Show All 37 Lines
clang_target_link_libraries(ClangTidyTests clang_target_link_libraries(ClangTidyTests
PRIVATE PRIVATE
clangAST clangAST
clangASTMatchers clangASTMatchers
clangBasic clangBasic
clangFrontend clangFrontend
clangLex clangLex
clangSerialization clangSerialization
clangTesting
clangTooling clangTooling
clangToolingCore clangToolingCore
clangTransformer clangTransformer
) )
target_link_libraries(ClangTidyTests target_link_libraries(ClangTidyTests
PRIVATE PRIVATE
clangTidy clangTidy
clangTidyAndroidModule clangTidyAndroidModule
clangTidyGoogleModule clangTidyGoogleModule
clangTidyLLVMModule clangTidyLLVMModule
clangTidyModernizeModule clangTidyModernizeModule
clangTidyObjCModule clangTidyObjCModule
clangTidyReadabilityModule clangTidyReadabilityModule
clangTidyUtils clangTidyUtils
LLVMTestingSupport LLVMTestingSupport
) )

clang-tools-extra/unittests/clang-tidy/ReadabilityModuleTest.cpp

#include "../../clang/unittests/ASTMatchers/ASTMatchersTest.h"
#include "ClangTidyTest.h" #include "ClangTidyTest.h"
#include "readability/BracesAroundStatementsCheck.h" #include "readability/BracesAroundStatementsCheck.h"
#include "readability/NamespaceCommentCheck.h" #include "readability/NamespaceCommentCheck.h"
#include "readability/SimplifyBooleanExprCheck.h" #include "readability/SimplifyBooleanExprCheck.h"
#include "gtest/gtest.h" #include "gtest/gtest.h"
namespace clang { namespace clang {
namespace tidy { namespace tidy {
namespace test { namespace test {
using readability::BracesAroundStatementsCheck; using readability::BracesAroundStatementsCheck;
using readability::NamespaceCommentCheck; using readability::NamespaceCommentCheck;
using readability::SimplifyBooleanExprCheck; using readability::SimplifyBooleanExprCheck;
using namespace ast_matchers;
// Copied from ASTMatchersTests
static std::vector<TestClangConfig> allTestClangConfigs() {
std::vector<TestClangConfig> all_configs;
for (TestLanguage lang : {Lang_C89, Lang_C99, Lang_CXX03, Lang_CXX11,
Lang_CXX14, Lang_CXX17, Lang_CXX20}) {
TestClangConfig config;
config.Language = lang;
// Use an unknown-unknown triple so we don't instantiate the full system
// toolchain. On Linux, instantiating the toolchain involves stat'ing
// large portions of /usr/lib, and this slows down not only this test, but
// all other tests, via contention in the kernel.
//
// FIXME: This is a hack to work around the fact that there's no way to do
// the equivalent of runToolOnCodeWithArgs without instantiating a full
// Driver. We should consider having a function, at least for tests, that
// invokes cc1.
config.Target = "i386-unknown-unknown";
all_configs.push_back(config);
// Windows target is interesting to test because it enables
// `-fdelayed-template-parsing`.
config.Target = "x86_64-pc-win32-msvc";
all_configs.push_back(config);
}
return all_configs;
}
INSTANTIATE_TEST_SUITE_P(ASTMatchersTests, ASTMatchersTest,
testing::ValuesIn(allTestClangConfigs()));
TEST(NamespaceCommentCheckTest, Basic) { TEST(NamespaceCommentCheckTest, Basic) {
EXPECT_EQ("namespace i {\n} // namespace i", EXPECT_EQ("namespace i {\n} // namespace i",
runCheckOnCode<NamespaceCommentCheck>("namespace i {\n}")); runCheckOnCode<NamespaceCommentCheck>("namespace i {\n}"));
EXPECT_EQ("namespace {\n} // namespace", EXPECT_EQ("namespace {\n} // namespace",
runCheckOnCode<NamespaceCommentCheck>("namespace {\n}")); runCheckOnCode<NamespaceCommentCheck>("namespace {\n}"));
EXPECT_EQ("namespace i { namespace j {\n} // namespace j\n } // namespace i", EXPECT_EQ("namespace i { namespace j {\n} // namespace j\n } // namespace i",
runCheckOnCode<NamespaceCommentCheck>( runCheckOnCode<NamespaceCommentCheck>(
▲ Show 20 Lines • Show All 496 Lines • Show Last 20 Lines