This is an archive of the discontinued LLVM Phabricator instance.

[ValueTypes] Define MVT for v3i8
Needs RevisionPublic

Authored by alonkom on Jul 18 2022, 8:00 AM.

Details

Diff Detail

Event Timeline

alonkom created this revision.Jul 18 2022, 8:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2022, 8:00 AM
alonkom requested review of this revision.Jul 18 2022, 8:00 AM
alonkom updated this revision to Diff 445508.Jul 18 2022, 8:01 AM
alonkom added a reviewer: guyblank.
alonkom retitled this revision from [ValueTypes] Define MVTs for v3i8 to [ValueTypes] Define MVT for v3i8.Jul 19 2022, 12:07 AM
alonkom added reviewers: craig.topper, RKSimon.

which target is this from - and does a MVT::v3i1 need adding at the same time?

which target is this from - and does a MVT::v3i1 need adding at the same time?

This is an out-of-tree target compiling OpenCL code that has vector types. Among them char3/uchar3 vector types.

RKSimon accepted this revision.Aug 2 2022, 5:30 AM

LGTM - I still expect we'll end up having to add MVT::v3i1 at some point - but since we've done without it with various v3iX types already it can probably wait for now.

This revision is now accepted and ready to land.Aug 2 2022, 5:30 AM

LGTM - I still expect we'll end up having to add MVT::v3i1 at some point - but since we've done without it with various v3iX types already it can probably wait for now.

Thanks. Can you commit on my behalf? I'm still having permission issues.

@alonkom Please can you send me your email details for the git commit message?

@alonkom Please can you send me your email details for the git commit message?

Name: Alon Kom
Mail: alon.kom@mobileye.com

RKSimon requested changes to this revision.Aug 8 2022, 5:00 AM

This is failing a lot of tests when run with all targets under 'ninja check-llvm' - please can you take another look?

This revision now requires changes to proceed.Aug 8 2022, 5:00 AM