User Details
User Details
- User Since
- Jun 18 2016, 10:44 PM (353 w, 4 d)
Mar 17 2021
Mar 17 2021
guyblank added inline comments to D88851: InstCombine: Fix infinite loop in copy-constant-to-alloca transform.
Mar 17 2021, 9:15 AM · Restricted Project
guyblank added inline comments to D88851: InstCombine: Fix infinite loop in copy-constant-to-alloca transform.
Mar 17 2021, 5:33 AM · Restricted Project
Feb 7 2018
Feb 7 2018
guyblank added a comment to D42770: [X86] Don't emit KTEST instructions unless only the Z flag is being used.
maybe use the update_mir_test_checks.py script for the mir test?
Dec 18 2017
Dec 18 2017
guyblank accepted D41327: [X86] Refactor DomainReassignment pass to make the Closure class not stores references to the main data structures of the pass itself.
LGTM, thanks.
Dec 17 2017
Dec 17 2017
guyblank added a comment to D40462: [LLVM][X86] Converting X86 intrinisics movmsk{ps|pd}{|256} and pmovmskb{128|256}.
you've uploaded the clang patch instead of the llvm one.
Dec 14 2017
Dec 14 2017
guyblank added inline comments to D40462: [LLVM][X86] Converting X86 intrinisics movmsk{ps|pd}{|256} and pmovmskb{128|256}.
Dec 13 2017
Dec 13 2017
guyblank added inline comments to D40465: [Clang][X86] Converting X86 intrinisics movmsk{ps|pd}{|256} and pmovmskb{128|256}.
Dec 12 2017
Dec 12 2017
guyblank added a comment to D39569: [AVX512] Adding support for extract element(mask i8) from a vector .
this is not needed after rL319745
Dec 7 2017
Dec 7 2017
Dec 5 2017
Dec 5 2017
guyblank committed rL319745: [X86] Fix a bug in handling GRXX subclasses in Domain Reassignment pass.
[X86] Fix a bug in handling GRXX subclasses in Domain Reassignment pass
Nov 29 2017
Nov 29 2017
guyblank added a comment to D40290: [X86] Fix a bug in handling GRXX subclasses in Domain Reassignment pass.
ping
Nov 23 2017
Nov 23 2017
guyblank added inline comments to D40290: [X86] Fix a bug in handling GRXX subclasses in Domain Reassignment pass.
Nov 22 2017
Nov 22 2017
guyblank added a reviewer for D40290: [X86] Fix a bug in handling GRXX subclasses in Domain Reassignment pass: m_zuckerman.
Nov 21 2017
Nov 21 2017
Oct 22 2017
Oct 22 2017
[X86] Add a pass to convert instruction chains between domains.
Oct 15 2017
Oct 15 2017
guyblank added a comment to D37251: [X86] Add a pass to convert instruction chains between domains.
ping
Oct 2 2017
Oct 2 2017
guyblank updated the diff for D37251: [X86] Add a pass to convert instruction chains between domains.
Address comments by @aaboud and some other offline comments.
Sep 18 2017
Sep 18 2017
guyblank updated the diff for D37251: [X86] Add a pass to convert instruction chains between domains.
Added mir test
Sep 3 2017
Sep 3 2017
guyblank updated the diff for D37251: [X86] Add a pass to convert instruction chains between domains.
addressed comments
guyblank added a comment to D37251: [X86] Add a pass to convert instruction chains between domains.
Thank you all for the comments.
guyblank added a comment to D37388: [X86] Allow cross-lane permutations for sub targets supporting AVX2..
If you want the llvm-commits mailing list to be notified when you create a review, you need to add it as a subscriber when creating the review, not afterwards.
When you add it after the initial creation, there will be no mail notification to the list.
So in your case, the first message the list got was the 'ping'.
If llvm-commits was added upon creation, the first message would have been:
jatin created this revision.
<the description of the revision>
guyblank added a comment to D37388: [X86] Allow cross-lane permutations for sub targets supporting AVX2..
Hi Jatin,
Thanks for working on this.
You didn't add llvm-commits as a subscriber upon review creation, so this won't show up on the mailing list. Can you open a new review?
Sep 2 2017
Sep 2 2017
guyblank accepted D37320: [X86] Teach fastisel to handle zext/sext i8->i16 and sext i1->i8/i16/i32/i64.
LGTM
Aug 31 2017
Aug 31 2017
guyblank added inline comments to D37320: [X86] Teach fastisel to handle zext/sext i8->i16 and sext i1->i8/i16/i32/i64.
Aug 30 2017
Aug 30 2017
LGTM
guyblank added inline comments to D37261: [GlobalISel][X86] Support variadic function call..
Aug 29 2017
Aug 29 2017
guyblank updated the diff for D37251: [X86] Add a pass to convert instruction chains between domains.
added a test (gpr-to-mask.ll) to show some cross BB issues
[X86] Add a test cases to demonstrate selecting GPR instructions when
guyblank added a reviewer for D37251: [X86] Add a pass to convert instruction chains between domains: DavidKreitzer.
Aug 28 2017
Aug 28 2017
Aug 22 2017
Aug 22 2017
Aug 13 2017
Aug 13 2017
[X86][AVX512] Add combine for TESTM
guyblank closed D36536: [X86][AVX512] Add combine for TESTM by committing rL310787: [X86][AVX512] Add combine for TESTM.
Aug 10 2017
Aug 10 2017
guyblank committed rL310593: [SelectionDAG] Allow constant folding for implicitly truncating BUILD_VECTOR….
[SelectionDAG] Allow constant folding for implicitly truncating BUILD_VECTOR…
guyblank added a comment to D36506: [SelectionDAG] Allow constant folding for implicitly truncating BUILD_VECTOR nodes.
Sure, I'll add a TODO, thanks.
Aug 9 2017
Aug 9 2017
guyblank updated the diff for D36536: [X86][AVX512] Add combine for TESTM.
Address Simon's comments.
guyblank added inline comments to D36536: [X86][AVX512] Add combine for TESTM.
[X86][AVX512] Choose correct registers in vpbroadcastb/w
guyblank added inline comments to D36479: [X86][AVX512] Choose correct registers in vpbroadcastb/w.
Aug 8 2017
Aug 8 2017
Aug 6 2017
Aug 6 2017
guyblank committed rL310239: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks.
[SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks
Aug 3 2017
Aug 3 2017
guyblank updated subscribers of D30751: [MachineCopyPropagation] Extend pass to do COPY source forwarding.
Aug 1 2017
Aug 1 2017
guyblank accepted D35829: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF16 stride 4)..
LGTM with one minor comment.
Jul 31 2017
Jul 31 2017
[X86][AVX512] Add masked MOVS[S|D] patterns
Jul 30 2017
Jul 30 2017
guyblank updated the diff for D35897: [X86][AVX512] Add masked MOVS[S|D] patterns.
fit into 80 columns
guyblank added inline comments to D35897: [X86][AVX512] Add masked MOVS[S|D] patterns.
Jul 26 2017
Jul 26 2017
forgot llvm-commits
Jul 25 2017
Jul 25 2017
guyblank added a comment to D35700: DAGCombiner: Extend reduceBuildVecToTrunc to handle non-zero offset.
I'm ok with this.
Jul 23 2017
Jul 23 2017
guyblank added inline comments to D35700: DAGCombiner: Extend reduceBuildVecToTrunc to handle non-zero offset.
guyblank added inline comments to D35700: DAGCombiner: Extend reduceBuildVecToTrunc to handle non-zero offset.
Jul 11 2017
Jul 11 2017
[X86][AVX512] regenerate avx512-insert-extract.ll
Jul 10 2017
Jul 10 2017
guyblank added inline comments to D35178: [GlobalISel][X86] Support G_LOAD/G_STORE i1..
Jul 9 2017
Jul 9 2017
Jul 3 2017
Jul 3 2017
guyblank added inline comments to D34816: [GlobalISel][X86] support G_FPEXT operation..
Jul 2 2017
Jul 2 2017
LGTM
Jun 29 2017
Jun 29 2017
lgtm
Jun 28 2017
Jun 28 2017
LGTM
Jun 26 2017
Jun 26 2017
guyblank added inline comments to D33958: [GlobalISel][X86] Support vector type G_MERGE_VALUES selection..
Jun 25 2017
Jun 25 2017
lgtm
Jun 22 2017
Jun 22 2017
guyblank added inline comments to D33957: [GlobalISel][X86] Support vector type G_EXTRACT selection..
LGTM with minor comment.
Jun 21 2017
Jun 21 2017
Closed by commit rL305883: [DAGCombiner] Add another combine from build vector to shuffle
[DAGCombiner] Add another combine from build vector to shuffle
Jun 20 2017
Jun 20 2017
guyblank added a comment to D33994: [DAGCombiner] Add another combine from build vector to shuffle.
ping
guyblank added a comment to D33435: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks .
ping
LGTM
Jun 19 2017
Jun 19 2017
guyblank updated the diff for D33994: [DAGCombiner] Add another combine from build vector to shuffle.
rebased after updating the test case
guyblank accepted D33888: [GlobalISel][X86] Fold FI/G_GEP into LDR/STR instruction addressing mode..
LGTM
[X86] Simplify vector-shuffle-v48 test. NFC.
Jun 14 2017
Jun 14 2017
guyblank added inline comments to D33994: [DAGCombiner] Add another combine from build vector to shuffle.
Jun 7 2017
Jun 7 2017
guyblank added a comment to D33435: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks .
@t.p.northover
does committing this patch and opening a PR for the AArch64 Isel issue sound reasonable?
[X86] Add test to demonstrate inefficient lowering of v48i8 shuffle.
Jun 1 2017
Jun 1 2017
guyblank added a comment to D33435: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks .
@ahatanak
seeing that you're doing AArch64 codegen commits, can you please take a look at this?
guyblank added a reviewer for D33435: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks : ahatanak.
May 29 2017
May 29 2017
guyblank added a comment to D33435: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks .
ping
May 24 2017
May 24 2017
guyblank updated the diff for D33435: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks .
May 23 2017
May 23 2017
May 19 2017
May 19 2017
[X86][AVX512] Make i1 illegal in the CodeGen