Page MenuHomePhabricator

guyblank (Guy Blank)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2016, 10:44 PM (161 w, 1 d)

Recent Activity

Feb 7 2018

guyblank accepted D42770: [X86] Don't emit KTEST instructions unless only the Z flag is being used.
Feb 7 2018, 10:45 PM
guyblank accepted D42772: [X86] Allow KORTEST instruction to be used for testing if a mask is all ones.
Feb 7 2018, 7:06 AM
guyblank added a comment to D42770: [X86] Don't emit KTEST instructions unless only the Z flag is being used.

maybe use the update_mir_test_checks.py script for the mir test?

Feb 7 2018, 6:09 AM

Dec 18 2017

guyblank accepted D41327: [X86] Refactor DomainReassignment pass to make the Closure class not stores references to the main data structures of the pass itself.

LGTM, thanks.

Dec 18 2017, 10:56 PM
guyblank added inline comments to D41327: [X86] Refactor DomainReassignment pass to make the Closure class not stores references to the main data structures of the pass itself.
Dec 18 2017, 12:13 AM

Dec 17 2017

guyblank added inline comments to D41327: [X86] Refactor DomainReassignment pass to make the Closure class not stores references to the main data structures of the pass itself.
Dec 17 2017, 8:56 AM
guyblank added a comment to D40462: [LLVM][X86] Converting X86 intrinisics movmsk{ps|pd}{|256} and pmovmskb{128|256}.

you've uploaded the clang patch instead of the llvm one.

Dec 17 2017, 8:45 AM

Dec 14 2017

guyblank added inline comments to D40462: [LLVM][X86] Converting X86 intrinisics movmsk{ps|pd}{|256} and pmovmskb{128|256}.
Dec 14 2017, 1:23 AM

Dec 13 2017

guyblank added inline comments to D40465: [Clang][X86] Converting X86 intrinisics movmsk{ps|pd}{|256} and pmovmskb{128|256}.
Dec 13 2017, 7:11 AM

Dec 12 2017

guyblank added a comment to D39569: [AVX512] Adding support for extract element(mask i8) from a vector .

this is not needed after rL319745

Dec 12 2017, 12:50 AM

Dec 7 2017

guyblank created D40957: [X86] Fix crash caused by not properly marking visited registers in Domain Reassignment pass.
Dec 7 2017, 7:50 AM

Dec 5 2017

guyblank committed rL319745: [X86] Fix a bug in handling GRXX subclasses in Domain Reassignment pass.
[X86] Fix a bug in handling GRXX subclasses in Domain Reassignment pass
Dec 5 2017, 1:09 AM
guyblank closed D40290: [X86] Fix a bug in handling GRXX subclasses in Domain Reassignment pass by committing rL319745: [X86] Fix a bug in handling GRXX subclasses in Domain Reassignment pass.
Dec 5 2017, 1:08 AM

Nov 29 2017

guyblank added a comment to D40290: [X86] Fix a bug in handling GRXX subclasses in Domain Reassignment pass.

ping

Nov 29 2017, 5:54 AM

Nov 23 2017

guyblank added inline comments to D40290: [X86] Fix a bug in handling GRXX subclasses in Domain Reassignment pass.
Nov 23 2017, 12:18 AM

Nov 22 2017

guyblank added a reviewer for D40290: [X86] Fix a bug in handling GRXX subclasses in Domain Reassignment pass: m_zuckerman.
Nov 22 2017, 1:00 AM

Nov 21 2017

guyblank created D40290: [X86] Fix a bug in handling GRXX subclasses in Domain Reassignment pass.
Nov 21 2017, 2:12 AM

Oct 22 2017

guyblank committed rL316288: [X86] Add a pass to convert instruction chains between domains..
[X86] Add a pass to convert instruction chains between domains.
Oct 22 2017, 4:43 AM
guyblank closed D37251: [X86] Add a pass to convert instruction chains between domains by committing rL316288: [X86] Add a pass to convert instruction chains between domains..
Oct 22 2017, 4:43 AM
guyblank accepted D38729: X86: Register the X86CallFrameOptimization pass.

lgtm

Oct 22 2017, 3:58 AM

Oct 15 2017

guyblank added a comment to D37251: [X86] Add a pass to convert instruction chains between domains.

ping

Oct 15 2017, 12:21 AM

Oct 2 2017

guyblank updated the diff for D37251: [X86] Add a pass to convert instruction chains between domains.

Address comments by @aaboud and some other offline comments.

Oct 2 2017, 1:04 AM

Sep 18 2017

guyblank updated the diff for D37251: [X86] Add a pass to convert instruction chains between domains.

Added mir test

Sep 18 2017, 8:07 AM

Sep 3 2017

guyblank updated the diff for D37251: [X86] Add a pass to convert instruction chains between domains.

addressed comments

Sep 3 2017, 9:42 AM
guyblank added a comment to D37251: [X86] Add a pass to convert instruction chains between domains.

Thank you all for the comments.

Sep 3 2017, 9:40 AM
guyblank added a comment to D37388: [X86] Allow cross-lane permutations for sub targets supporting AVX2..

Hi Jatin,
Thanks for working on this.
You didn't add llvm-commits as a subscriber upon review creation, so this won't show up on the mailing list. Can you open a new review?

Hi Guy,

llvm-commits is already on subscriber's list for this differential revision. I did not not get your point in opeining a new review.

Thanks

If you want the llvm-commits mailing list to be notified when you create a review, you need to add it as a subscriber when creating the review, not afterwards.
When you add it after the initial creation, there will be no mail notification to the list.
So in your case, the first message the list got was the 'ping'.
If llvm-commits was added upon creation, the first message would have been:
jatin created this revision.
<the description of the revision>

Sep 3 2017, 4:22 AM
guyblank added a comment to D37388: [X86] Allow cross-lane permutations for sub targets supporting AVX2..

Hi Jatin,
Thanks for working on this.
You didn't add llvm-commits as a subscriber upon review creation, so this won't show up on the mailing list. Can you open a new review?

Sep 3 2017, 1:06 AM

Sep 2 2017

guyblank accepted D37320: [X86] Teach fastisel to handle zext/sext i8->i16 and sext i1->i8/i16/i32/i64.

LGTM

Sep 2 2017, 7:33 AM

Aug 31 2017

guyblank added inline comments to D37320: [X86] Teach fastisel to handle zext/sext i8->i16 and sext i1->i8/i16/i32/i64.
Aug 31 2017, 1:18 AM

Aug 30 2017

guyblank accepted D37261: [GlobalISel][X86] Support variadic function call..

LGTM

Aug 30 2017, 7:07 AM
guyblank added inline comments to D37261: [GlobalISel][X86] Support variadic function call..
Aug 30 2017, 1:42 AM

Aug 29 2017

guyblank added inline comments to D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
Aug 29 2017, 10:49 PM
guyblank added inline comments to D36960: [X86][LLVM]Expanding Supports lowerInterleavedLoad() in X86InterleavedAccess (VF{8|16|32} stride 3)..
Aug 29 2017, 11:47 AM
guyblank updated the diff for D37251: [X86] Add a pass to convert instruction chains between domains.

added a test (gpr-to-mask.ll) to show some cross BB issues

Aug 29 2017, 5:42 AM
guyblank committed rL311996: [X86] Add a test cases to demonstrate selecting GPR instructions when.
[X86] Add a test cases to demonstrate selecting GPR instructions when
Aug 29 2017, 4:59 AM
guyblank added a reviewer for D37251: [X86] Add a pass to convert instruction chains between domains: DavidKreitzer.
Aug 29 2017, 4:43 AM

Aug 28 2017

guyblank created D37251: [X86] Add a pass to convert instruction chains between domains.
Aug 28 2017, 10:50 PM

Aug 22 2017

guyblank accepted D36733: [GlobalISel][X86] Support G_IMPLICIT_DEF..

LGTM

Aug 22 2017, 12:18 AM

Aug 13 2017

guyblank accepted D36652: [AVX512] Remove leftover code for when i1 was a legal type from the fast isel load/store code..
Aug 13 2017, 11:43 PM
guyblank committed rL310787: [X86][AVX512] Add combine for TESTM.
[X86][AVX512] Add combine for TESTM
Aug 13 2017, 1:05 AM
guyblank closed D36536: [X86][AVX512] Add combine for TESTM by committing rL310787: [X86][AVX512] Add combine for TESTM.
Aug 13 2017, 1:04 AM

Aug 10 2017

guyblank committed rL310593: [SelectionDAG] Allow constant folding for implicitly truncating BUILD_VECTOR….
[SelectionDAG] Allow constant folding for implicitly truncating BUILD_VECTOR…
Aug 10 2017, 7:10 AM
guyblank closed D36506: [SelectionDAG] Allow constant folding for implicitly truncating BUILD_VECTOR nodes by committing rL310593: [SelectionDAG] Allow constant folding for implicitly truncating BUILD_VECTOR….
Aug 10 2017, 7:10 AM
guyblank added a comment to D36506: [SelectionDAG] Allow constant folding for implicitly truncating BUILD_VECTOR nodes.

Sure, I'll add a TODO, thanks.

Aug 10 2017, 7:03 AM

Aug 9 2017

guyblank updated the diff for D36536: [X86][AVX512] Add combine for TESTM.

Address Simon's comments.

Aug 9 2017, 11:05 PM
guyblank added inline comments to D36536: [X86][AVX512] Add combine for TESTM.
Aug 9 2017, 10:57 PM
guyblank created D36536: [X86][AVX512] Add combine for TESTM.
Aug 9 2017, 10:55 AM
guyblank committed rL310498: [X86][AVX512] Choose correct registers in vpbroadcastb/w.
[X86][AVX512] Choose correct registers in vpbroadcastb/w
Aug 9 2017, 10:22 AM
guyblank closed D36479: [X86][AVX512] Choose correct registers in vpbroadcastb/w by committing rL310498: [X86][AVX512] Choose correct registers in vpbroadcastb/w.
Aug 9 2017, 10:21 AM
guyblank added inline comments to D36479: [X86][AVX512] Choose correct registers in vpbroadcastb/w.
Aug 9 2017, 9:03 AM

Aug 8 2017

guyblank created D36506: [SelectionDAG] Allow constant folding for implicitly truncating BUILD_VECTOR nodes.
Aug 8 2017, 11:00 PM
guyblank created D36479: [X86][AVX512] Choose correct registers in vpbroadcastb/w.
Aug 8 2017, 11:49 AM

Aug 6 2017

guyblank committed rL310239: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks.
[SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks
Aug 6 2017, 10:52 PM
guyblank closed D33435: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks by committing rL310239: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks.
Aug 6 2017, 10:52 PM

Aug 3 2017

guyblank updated subscribers of D30751: [MachineCopyPropagation] Extend pass to do COPY source forwarding.
Aug 3 2017, 12:15 AM

Aug 1 2017

guyblank accepted D35829: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF16 stride 4)..

LGTM with one minor comment.

Aug 1 2017, 11:20 PM

Jul 31 2017

guyblank committed rL309546: [X86][AVX512] Add masked MOVS[S|D] patterns.
[X86][AVX512] Add masked MOVS[S|D] patterns
Jul 31 2017, 1:27 AM
guyblank closed D35897: [X86][AVX512] Add masked MOVS[S|D] patterns by committing rL309546: [X86][AVX512] Add masked MOVS[S|D] patterns.
Jul 31 2017, 1:26 AM

Jul 30 2017

guyblank updated the diff for D35897: [X86][AVX512] Add masked MOVS[S|D] patterns.

fit into 80 columns

Jul 30 2017, 1:20 AM
guyblank added inline comments to D35897: [X86][AVX512] Add masked MOVS[S|D] patterns.
Jul 30 2017, 1:11 AM

Jul 26 2017

guyblank created D35897: [X86][AVX512] Add masked MOVS[S|D] patterns.
Jul 26 2017, 9:07 AM
guyblank abandoned D35895: [X86][AVX512] Add masked MOVS[S|D] paatterns.

forgot llvm-commits

Jul 26 2017, 9:05 AM
guyblank created D35895: [X86][AVX512] Add masked MOVS[S|D] paatterns.
Jul 26 2017, 9:05 AM
guyblank added inline comments to D35829: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF16 stride 4)..
Jul 26 2017, 5:05 AM

Jul 25 2017

guyblank added a comment to D35700: DAGCombiner: Extend reduceBuildVecToTrunc to handle non-zero offset.

I'm ok with this.

Jul 25 2017, 4:44 AM

Jul 23 2017

guyblank added inline comments to D35700: DAGCombiner: Extend reduceBuildVecToTrunc to handle non-zero offset.
Jul 23 2017, 8:46 AM
guyblank added inline comments to D35700: DAGCombiner: Extend reduceBuildVecToTrunc to handle non-zero offset.
Jul 23 2017, 7:59 AM

Jul 11 2017

guyblank committed rL307654: [X86][AVX512] regenerate avx512-insert-extract.ll.
[X86][AVX512] regenerate avx512-insert-extract.ll
Jul 11 2017, 4:52 AM

Jul 10 2017

guyblank accepted D35178: [GlobalISel][X86] Support G_LOAD/G_STORE i1..
Jul 10 2017, 1:33 AM
guyblank added inline comments to D35178: [GlobalISel][X86] Support G_LOAD/G_STORE i1..
Jul 10 2017, 12:32 AM

Jul 9 2017

guyblank accepted D35177: [GlobalISel][X86] extend G_ZEXT support..

LGTM

Jul 9 2017, 6:31 AM

Jul 3 2017

guyblank added inline comments to D34816: [GlobalISel][X86] support G_FPEXT operation..
Jul 3 2017, 7:34 AM

Jul 2 2017

guyblank accepted D34754: [GlobalISel][X86] Support G_BRCOND operation..

lgtm

Jul 2 2017, 7:07 AM
guyblank accepted D34738: [GlobalISel][X86] Support G_GLOBAL_VALUE operation..

LGTM

Jul 2 2017, 1:31 AM

Jun 29 2017

guyblank accepted D33958: [GlobalISel][X86] Support vector type G_MERGE_VALUES selection..

lgtm

Jun 29 2017, 1:47 AM

Jun 28 2017

guyblank accepted D33665: [GlobalISel][X86] Support vector type G_UNMERGE_VALUES selection..

LGTM

Jun 28 2017, 9:53 AM

Jun 26 2017

guyblank added inline comments to D33958: [GlobalISel][X86] Support vector type G_MERGE_VALUES selection..
Jun 26 2017, 8:51 AM

Jun 25 2017

guyblank accepted D33957: [GlobalISel][X86] Support vector type G_EXTRACT selection..

lgtm

Jun 25 2017, 1:45 AM

Jun 22 2017

guyblank added inline comments to D33957: [GlobalISel][X86] Support vector type G_EXTRACT selection..
Jun 22 2017, 3:46 AM
guyblank accepted D33956: [GlobalISel][X86] Support vector type G_INSERT legalization/selection..

LGTM with minor comment.

Jun 22 2017, 1:40 AM

Jun 21 2017

guyblank closed D33994: [DAGCombiner] Add another combine from build vector to shuffle.

Closed by commit rL305883: [DAGCombiner] Add another combine from build vector to shuffle

Jun 21 2017, 7:16 AM
guyblank committed rL305883: [DAGCombiner] Add another combine from build vector to shuffle.
[DAGCombiner] Add another combine from build vector to shuffle
Jun 21 2017, 12:39 AM

Jun 20 2017

guyblank added a comment to D33994: [DAGCombiner] Add another combine from build vector to shuffle.

ping

Jun 20 2017, 11:00 PM
guyblank added a comment to D33435: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks .

ping

Jun 20 2017, 11:00 PM
guyblank accepted D33952: [GlobalISel][X86] Get correct RegClass for given RegBank..

LGTM

Jun 20 2017, 12:02 AM

Jun 19 2017

guyblank updated the diff for D33994: [DAGCombiner] Add another combine from build vector to shuffle.

rebased after updating the test case

Jun 19 2017, 4:34 AM
guyblank accepted D33888: [GlobalISel][X86] Fold FI/G_GEP into LDR/STR instruction addressing mode..

LGTM

Jun 19 2017, 4:08 AM
guyblank committed rL305670: [X86] Simplify vector-shuffle-v48 test. NFC..
[X86] Simplify vector-shuffle-v48 test. NFC.
Jun 19 2017, 1:59 AM

Jun 14 2017

guyblank added inline comments to D33994: [DAGCombiner] Add another combine from build vector to shuffle.
Jun 14 2017, 12:17 AM

Jun 7 2017

guyblank added a comment to D33435: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks .

@t.p.northover
does committing this patch and opening a PR for the AArch64 Isel issue sound reasonable?

Jun 7 2017, 8:28 AM
guyblank created D33994: [DAGCombiner] Add another combine from build vector to shuffle.
Jun 7 2017, 8:24 AM
guyblank committed rL304915: [X86] Add test to demonstrate inefficient lowering of v48i8 shuffle..
[X86] Add test to demonstrate inefficient lowering of v48i8 shuffle.
Jun 7 2017, 7:29 AM

Jun 1 2017

guyblank added a comment to D33435: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks .

@ahatanak
seeing that you're doing AArch64 codegen commits, can you please take a look at this?

Jun 1 2017, 12:49 AM
guyblank added a reviewer for D33435: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks : ahatanak.
Jun 1 2017, 12:47 AM

May 29 2017

guyblank added a comment to D33435: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks .

ping

May 29 2017, 10:32 AM

May 24 2017

guyblank updated the diff for D33435: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks .
May 24 2017, 12:11 AM

May 23 2017

guyblank created D33435: [SelectionDAG] reset NewNodesMustHaveLegalTypes flag between basic blocks .
May 23 2017, 3:37 AM

May 19 2017

guyblank committed rL303421: [X86][AVX512] Make i1 illegal in the CodeGen.
[X86][AVX512] Make i1 illegal in the CodeGen
May 19 2017, 5:49 AM
guyblank closed D32273: [X86][AVX512] Make i1 illegal in the CodeGen by committing rL303421: [X86][AVX512] Make i1 illegal in the CodeGen.
May 19 2017, 5:48 AM

May 18 2017

guyblank committed rL303346: [MVT] add v1i1 MVT.
[MVT] add v1i1 MVT
May 18 2017, 4:43 AM