This is an archive of the discontinued LLVM Phabricator instance.

[NFC][SVE] Add tests for zext(cmpeq(x, splat(0)))
ClosedPublic

Authored by c-rhodes on Jul 13 2022, 2:43 AM.

Details

Summary

In preparation for follow up patch folding above to CNOT.

Diff Detail

Event Timeline

c-rhodes created this revision.Jul 13 2022, 2:43 AM
Herald added a project: Restricted Project. · View Herald Transcript
c-rhodes requested review of this revision.Jul 13 2022, 2:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2022, 2:43 AM
peterwaller-arm accepted this revision.Jul 13 2022, 3:16 AM
This revision is now accepted and ready to land.Jul 13 2022, 3:16 AM
paulwalker-arm accepted this revision.Jul 13 2022, 3:17 AM

Is it worth adding tests for all the legal floating point types? i.e. vscale x 2 x half, ....

c-rhodes updated this revision to Diff 444229.Jul 13 2022, 5:06 AM

Add tests for all legal FP types.

Is it worth adding tests for all the legal floating point types? i.e. vscale x 2 x half, ....

Done, thanks for reviewing.

c-rhodes updated this revision to Diff 444256.Jul 13 2022, 7:39 AM

Remove FP tests. I noticed there was no ucvtf after the mov in some tests, I mis-generated them somehow, but I'm not entirely sure the fold to CNOT is correct for FP types anyway, so I've removed them.

Remove FP tests. I noticed there was no ucvtf after the mov in some tests, I mis-generated them somehow, but I'm not entirely sure the fold to CNOT is correct for FP types anyway, so I've removed them.

It seems sensible to retain the tests with the correct check lines in any case. It may be possible to use a cnot if no-signed-zeros is in effect, but that's a patch for another day.

Matt added a subscriber: Matt.Jul 13 2022, 4:14 PM
This revision was landed with ongoing or failed builds.Jul 14 2022, 2:33 AM
This revision was automatically updated to reflect the committed changes.