This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Increase complexity of RVV element extraction patterns
ClosedPublic

Authored by pcwang-thead on Jul 8 2022, 3:51 AM.

Details

Summary

Somehow some tests failed in our downstream because it matched
VFMV+FSD pattern first. Both FSD and VSE patterns have the same
complexity, while FSD is matched before VSE in the generated
matcher table.

This problem only occurs in our downstream (so sorry that I can't
provide a test here) and increasing the value of AddedComplexity
can fix it.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2022, 3:51 AM
pcwang-thead requested review of this revision.Jul 8 2022, 3:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2022, 3:51 AM
StephenFan accepted this revision.Jul 8 2022, 5:40 AM

LGTM. But you probably want to wait for @craig.topper.

This revision is now accepted and ready to land.Jul 8 2022, 5:40 AM
This revision was landed with ongoing or failed builds.Jul 10 2022, 7:54 PM
This revision was automatically updated to reflect the committed changes.