This is an archive of the discontinued LLVM Phabricator instance.

[flang][NFC] Make LEN parameters homogenous
ClosedPublic

Authored by clementval on Jul 6 2022, 4:19 AM.

Details

Summary

This patch is part of the upstreaming effort from fir-dev branch.

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>

Diff Detail

Event Timeline

clementval created this revision.Jul 6 2022, 4:19 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 6 2022, 4:19 AM
Herald added a subscriber: mehdi_amini. · View Herald Transcript
clementval requested review of this revision.Jul 6 2022, 4:19 AM
jeanPerier added inline comments.Jul 6 2022, 4:58 AM
flang/lib/Lower/Bridge.cpp
496

I think this was added recently in https://github.com/llvm/llvm-project/commit/27afb362b1e85dac21744b95ed9b48f7e9fd016c and should probably be kept (build bots are complaining in openmp copyin tests).

clementval added inline comments.Jul 6 2022, 5:00 AM
flang/lib/Lower/Bridge.cpp
496

My bad. I’ll revert that

clementval updated this revision to Diff 442529.Jul 6 2022, 5:19 AM
clementval marked an inline comment as done.

Keep the setInsertionPointAfter

This revision is now accepted and ready to land.Jul 6 2022, 11:27 PM
This revision was automatically updated to reflect the committed changes.