This is an archive of the discontinued LLVM Phabricator instance.

Differential D129176

[ORC][LLJIT] Enable AutoClaimWeakHiddenSymbols option in PPC64 environment.
AbandonedPublic

Authored by sunho on Jul 6 2022, 1:26 AM.

Details

Reviewers
lhames
sgraenitz
v.g.vassilev
Summary

This fixes "JIT session error: Symbols not found: [ DW.ref.__gxx_personality_v0 ]" error which happens when exception is used.

Diff Detail

Event Timeline

sunho created this revision.Jul 6 2022, 1:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2022, 1:26 AM
Herald added subscribers: StephenFan, shchenz, hiraditya. · View Herald Transcript
sunho requested review of this revision.Jul 6 2022, 1:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2022, 1:26 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
sunho added a parent revision: D129175: [ORC] Fix weak hidden symbols failure on PPC with runtimedyld.Jul 6 2022, 1:26 AM
sunho retitled this revision from [ORC][LLJIT] Enable ClaimWeakHiddenSymbols option in PPC64 environment. to [ORC][LLJIT] Enable AutoClaimWeakHiddenSymbols option in PPC64 environment..
sunho updated this revision to Diff 442465.Jul 6 2022, 1:40 AM
sunho abandoned this revision.Jul 6 2022, 2:47 AM
sunho removed a parent revision: D129175: [ORC] Fix weak hidden symbols failure on PPC with runtimedyld.Jul 6 2022, 2:53 AM
Harbormaster completed remote builds in B173823: Diff 442465.Jul 6 2022, 2:54 AM

Revision Contents

PathSize
llvm/
lib/
ExecutionEngine/
Orc/
5 lines

Diff 442462

llvm/lib/ExecutionEngine/Orc/LLJIT.cpp

Show First 20 Lines • Show All 739 Lines • ▼ Show 20 LinesLLJIT::createObjectLinkingLayer(LLJITBuilderState &S, ExecutionSession &ES) {
auto Layer = auto Layer =
std::make_unique<RTDyldObjectLinkingLayer>(ES, std::move(GetMemMgr)); std::make_unique<RTDyldObjectLinkingLayer>(ES, std::move(GetMemMgr));
if (S.JTMB->getTargetTriple().isOSBinFormatCOFF()) { if (S.JTMB->getTargetTriple().isOSBinFormatCOFF()) {
Layer->setOverrideObjectFlagsWithResponsibilityFlags(true); Layer->setOverrideObjectFlagsWithResponsibilityFlags(true);
Layer->setAutoClaimResponsibilityForObjectSymbols(true); Layer->setAutoClaimResponsibilityForObjectSymbols(true);
} }
if (S.JTMB->getTargetTriple().getArch() == Triple::ArchType::ppc64 ||
S.JTMB->getTargetTriple().getArch() == Triple::ArchType::ppc64le) {
Layer->setAutoClaimResponsibilityForWeakHiddenSymbols(true);
}
// FIXME: Explicit conversion to std::unique_ptr<ObjectLayer> added to silence // FIXME: Explicit conversion to std::unique_ptr<ObjectLayer> added to silence
// errors from some GCC / libstdc++ bots. Remove this conversion (i.e. // errors from some GCC / libstdc++ bots. Remove this conversion (i.e.
// just return ObjLinkingLayer) once those bots are upgraded. // just return ObjLinkingLayer) once those bots are upgraded.
return std::unique_ptr<ObjectLayer>(std::move(Layer)); return std::unique_ptr<ObjectLayer>(std::move(Layer));
} }
Expected<std::unique_ptr<IRCompileLayer::IRCompiler>> Expected<std::unique_ptr<IRCompileLayer::IRCompiler>>
LLJIT::createCompileFunction(LLJITBuilderState &S, LLJIT::createCompileFunction(LLJITBuilderState &S,
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines