This is an archive of the discontinued LLVM Phabricator instance.

Differential D129092

[Orc][LLJIT] Use JITLink on RISC-V
ClosedPublic

Authored by Hahnfeld on Jul 4 2022, 10:35 AM.

Details

Reviewers
lhames
StephenFan
fourdim
Commits
rGa4e2c1f76295: [Orc][LLJIT] Use JITLink on RISC-V
Summary

RuntimeDyld does not support RISC-V, so it makes sense to enable
JITLink by default. This also makes relocations work without support
for a large code model.

Diff Detail

Event Timeline

Hahnfeld created this revision.Jul 4 2022, 10:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2022, 10:35 AM
Herald added subscribers: sunshaoce, VincentWu, luke957 and 12 others. · View Herald Transcript
Hahnfeld requested review of this revision.Jul 4 2022, 10:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2022, 10:35 AM
Herald added subscribers: llvm-commits, • pcwang-thead. · View Herald Transcript
Harbormaster completed remote builds in B173581: Diff 442122.Jul 4 2022, 11:45 AM
lhames accepted this revision.Jul 4 2022, 1:33 PM

LGTM. Thanks @Hahnfeld!

This revision is now accepted and ready to land.Jul 4 2022, 1:33 PM
This revision was landed with ongoing or failed builds.Jul 4 2022, 2:10 PM
Closed by commit rGa4e2c1f76295: [Orc][LLJIT] Use JITLink on RISC-V (authored by Hahnfeld). · Explain Why
This revision was automatically updated to reflect the committed changes.
Hahnfeld added a commit: rGa4e2c1f76295: [Orc][LLJIT] Use JITLink on RISC-V.

Revision Contents

PathSize
llvm/
lib/
ExecutionEngine/
Orc/
5 lines

Diff 442122

llvm/lib/ExecutionEngine/Orc/LLJIT.cpp

Show First 20 Lines • Show All 660 Lines • ▼ Show 20 Lines LLVM_DEBUG({
dbgs() << "Using explicitly specified ExecutorProcessControl instance " dbgs() << "Using explicitly specified ExecutorProcessControl instance "
<< EPC.get() << "\n"; << EPC.get() << "\n";
}); });
// If the client didn't configure any linker options then auto-configure the // If the client didn't configure any linker options then auto-configure the
// JIT linker. // JIT linker.
if (!CreateObjectLinkingLayer) { if (!CreateObjectLinkingLayer) {
auto &TT = JTMB->getTargetTriple(); auto &TT = JTMB->getTargetTriple();
if (TT.isOSBinFormatMachO() && if (TT.getArch() == Triple::riscv64 ||
(TT.getArch() == Triple::aarch64 || TT.getArch() == Triple::x86_64)) { (TT.isOSBinFormatMachO() &&
(TT.getArch() == Triple::aarch64 || TT.getArch() == Triple::x86_64))) {
JTMB->setRelocationModel(Reloc::PIC_); JTMB->setRelocationModel(Reloc::PIC_);
JTMB->setCodeModel(CodeModel::Small); JTMB->setCodeModel(CodeModel::Small);
CreateObjectLinkingLayer = CreateObjectLinkingLayer =
[](ExecutionSession &ES, [](ExecutionSession &ES,
const Triple &) -> Expected<std::unique_ptr<ObjectLayer>> { const Triple &) -> Expected<std::unique_ptr<ObjectLayer>> {
auto ObjLinkingLayer = std::make_unique<ObjectLinkingLayer>(ES); auto ObjLinkingLayer = std::make_unique<ObjectLinkingLayer>(ES);
ObjLinkingLayer->addPlugin(std::make_unique<EHFrameRegistrationPlugin>( ObjLinkingLayer->addPlugin(std::make_unique<EHFrameRegistrationPlugin>(
▲ Show 20 Lines • Show All 275 Lines • Show Last 20 Lines