This is an archive of the discontinued LLVM Phabricator instance.

[llvm-lib] Ignore /NODEFAULTLIB flag
ClosedPublic

Authored by pzheng on Jul 1 2022, 7:31 PM.

Details

Summary

It doesn't look like there is anything llvm-lib needs to handle based on
Microsoft's description of the flag.

https://docs.microsoft.com/en-us/cpp/build/reference/managing-a-library?view=msvc-170

Diff Detail

Event Timeline

pzheng created this revision.Jul 1 2022, 7:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2022, 7:31 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
pzheng requested review of this revision.Jul 1 2022, 7:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2022, 7:31 PM
thakis accepted this revision.Jul 4 2022, 1:38 PM

Looks fine to me.

May I ask what motivates all these changes? Are you trying to build a particular project? Is it difficult to not pass link.exe-only flags to lib.exe in that project for some reason?

This revision is now accepted and ready to land.Jul 4 2022, 1:38 PM

Looks fine to me.

May I ask what motivates all these changes? Are you trying to build a particular project? Is it difficult to not pass link.exe-only flags to lib.exe in that project for some reason?

Thanks, @thakis. What motivated these changes are some build errors we encountered when building proprietary projects with clang. We don't have control over the flags passed to llvm-lib, so need a way to work around these flag compatibility issues for now.

This revision was landed with ongoing or failed builds.Jul 5 2022, 10:28 AM
This revision was automatically updated to reflect the committed changes.