Page MenuHomePhabricator

[Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument
Changes PlannedPublic

Authored by tianshilei1992 on Jul 1 2022, 10:39 AM.

Details

Reviewers
jdoerfert
ABataev
Summary

This patch fixes the issue that the globalized variable is not properly
initialized when it is a byval struct function argument.

Fixes #56218.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Jul 1 2022, 10:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2022, 10:39 AM
tianshilei1992 requested review of this revision.Jul 1 2022, 10:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2022, 10:39 AM

fix unused variable

rebase and fix test error

tianshilei1992 edited the summary of this revision. (Show Details)Jul 6 2022, 8:51 AM

cleanup/destructor test missing.

@ABataev WDYT?

cleanup/destructor test missing.

@ABataev WDYT?

Looks good in general, extra tests would be good

tianshilei1992 planned changes to this revision.Jul 8 2022, 5:01 PM

callCStructCopyConstructor is actually for Objective-C…Cannot use it here.

callCStructCopyConstructor is actually for Objective-C…Cannot use it here.

Don't we generate copies of things elsewhere already?